callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

em-formatter: Remove unneeded attachment-expander button's 'data' attribute

Browse Source 
The 'data' attribute contained HTML code, which had been used a bit later
in the HTML structure and, more importantly, it was not accessed anywhere,
thus it only made the HTML code larger with no gain. Also, the attribute
value could cause HTML structure breakage, when the 'data' attribute
contained double quotes.
This commit is contained in:
Milan Crha
2020-04-09 12:14:38 +02:00
parent 00a0e61c1e
commit 93b56ca40f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/em-format/e-mail-formatter-attachment.c
+2 -2
View File
@@ -260,7 +260,7 @@ emfe_attachment_format (EMailFormatterExtension *extension,
"<table width=\"100%%\" border=\"0\" style=\"border-spacing: 0px\">"
"<tr valign=\"middle\">"
"<td align=\"left\" width=\"1px\" style=\"white-space:pre;\">"
"<button type=\"button\" class=\"attachment-expander\" id=\"%s\" value=\"%p\" data=\"%s\" style=\"vertical-align:middle; margin:0px;\">"
"<button type=\"button\" class=\"attachment-expander\" id=\"%s\" value=\"%p\" style=\"vertical-align:middle; margin:0px;\">"
"<img id=\"attachment-expander-img-%p\" src=\"gtk-stock://%s?size=%d\" width=\"%dpx\" height=\"%dpx\" style=\"vertical-align:middle;\">"
"<img src=\"%s\" width=\"%dpx\" height=\"%dpx\" style=\"vertical-align:middle;\">"
"</button>"
@@ -268,7 +268,7 @@ emfe_attachment_format (EMailFormatterExtension *extension,
"<img src=\"gtk-stock://x-evolution-arrow-down?size=%d\" width=\"%dpx\" height=\"%dpx\" style=\"vertical-align:middle;\">"
"</button>"
"</td><td align=\"left\">%s</td></tr>",
part_id, attachment_ptr, html, attachment_ptr,
part_id, attachment_ptr, attachment_ptr,
e_mail_part_should_show_inline (part) ? "go-down" : e_mail_part_attachment_get_expandable (empa) ? "go-next" : "go-top",
GTK_ICON_SIZE_BUTTON, icon_width, icon_height,
icon_uri, icon_width, icon_height,