From 93b56ca40f62fbe1acd623a93b99e71cdd60409a Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Thu, 9 Apr 2020 12:14:38 +0200 Subject: [PATCH] em-formatter: Remove unneeded attachment-expander button's 'data' attribute The 'data' attribute contained HTML code, which had been used a bit later in the HTML structure and, more importantly, it was not accessed anywhere, thus it only made the HTML code larger with no gain. Also, the attribute value could cause HTML structure breakage, when the 'data' attribute contained double quotes. --- src/em-format/e-mail-formatter-attachment.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/em-format/e-mail-formatter-attachment.c b/src/em-format/e-mail-formatter-attachment.c index 9a186618d7..a91871475a 100644 --- a/src/em-format/e-mail-formatter-attachment.c +++ b/src/em-format/e-mail-formatter-attachment.c @@ -260,7 +260,7 @@ emfe_attachment_format (EMailFormatterExtension *extension, "" "" "", - part_id, attachment_ptr, html, attachment_ptr, + part_id, attachment_ptr, attachment_ptr, e_mail_part_should_show_inline (part) ? "go-down" : e_mail_part_attachment_get_expandable (empa) ? "go-next" : "go-top", GTK_ICON_SIZE_BUTTON, icon_width, icon_height, icon_uri, icon_width, icon_height,
" - "" @@ -268,7 +268,7 @@ emfe_attachment_format (EMailFormatterExtension *extension, "" "" "%s