Don't reference last_cursor if it is null. Fixes crash when rotating the

2001-02-13  Alexander Larsson  <alexl@redhat.com>

	* gdk/linux-fb/gdkcursor-fb.c (gdk_fb_cursor_unhide):
	Don't reference last_cursor if it is null. Fixes crash when rotating
	the screen before having moved the mouse.

	* gdk/linux-fb/gdkcc-fb.c: Zapp!

	* gdk/linux-fb/Makefile.am: Don't compile gdkcc-fb.c

	* gdk/linux-fb/gdkwindow-fb.c: Fix typo. width->height. Fixes redraw when
	using 90 or 270 degrees rotation.
This commit is contained in:
Alexander Larsson
2001-02-13 13:35:48 +00:00
committed by Alexander Larsson
parent 2097d764a7
commit e86265ecf3
12 changed files with 95 additions and 1735 deletions

View File

@ -1,3 +1,16 @@
2001-02-13 Alexander Larsson <alexl@redhat.com>
* gdk/linux-fb/gdkcursor-fb.c (gdk_fb_cursor_unhide):
Don't reference last_cursor if it is null. Fixes crash when rotating
the screen before having moved the mouse.
* gdk/linux-fb/gdkcc-fb.c: Zapp!
* gdk/linux-fb/Makefile.am: Don't compile gdkcc-fb.c
* gdk/linux-fb/gdkwindow-fb.c: Fix typo. width->height. Fixes redraw when
using 90 or 270 degrees rotation.
2001-02-12 Havoc Pennington <hp@pobox.com>
* gdk/gdkpango.c (gdk_pango_get_gc): fix bug where

View File

@ -1,3 +1,16 @@
2001-02-13 Alexander Larsson <alexl@redhat.com>
* gdk/linux-fb/gdkcursor-fb.c (gdk_fb_cursor_unhide):
Don't reference last_cursor if it is null. Fixes crash when rotating
the screen before having moved the mouse.
* gdk/linux-fb/gdkcc-fb.c: Zapp!
* gdk/linux-fb/Makefile.am: Don't compile gdkcc-fb.c
* gdk/linux-fb/gdkwindow-fb.c: Fix typo. width->height. Fixes redraw when
using 90 or 270 degrees rotation.
2001-02-12 Havoc Pennington <hp@pobox.com>
* gdk/gdkpango.c (gdk_pango_get_gc): fix bug where

View File

@ -1,3 +1,16 @@
2001-02-13 Alexander Larsson <alexl@redhat.com>
* gdk/linux-fb/gdkcursor-fb.c (gdk_fb_cursor_unhide):
Don't reference last_cursor if it is null. Fixes crash when rotating
the screen before having moved the mouse.
* gdk/linux-fb/gdkcc-fb.c: Zapp!
* gdk/linux-fb/Makefile.am: Don't compile gdkcc-fb.c
* gdk/linux-fb/gdkwindow-fb.c: Fix typo. width->height. Fixes redraw when
using 90 or 270 degrees rotation.
2001-02-12 Havoc Pennington <hp@pobox.com>
* gdk/gdkpango.c (gdk_pango_get_gc): fix bug where

View File

@ -1,3 +1,16 @@
2001-02-13 Alexander Larsson <alexl@redhat.com>
* gdk/linux-fb/gdkcursor-fb.c (gdk_fb_cursor_unhide):
Don't reference last_cursor if it is null. Fixes crash when rotating
the screen before having moved the mouse.
* gdk/linux-fb/gdkcc-fb.c: Zapp!
* gdk/linux-fb/Makefile.am: Don't compile gdkcc-fb.c
* gdk/linux-fb/gdkwindow-fb.c: Fix typo. width->height. Fixes redraw when
using 90 or 270 degrees rotation.
2001-02-12 Havoc Pennington <hp@pobox.com>
* gdk/gdkpango.c (gdk_pango_get_gc): fix bug where

View File

@ -1,3 +1,16 @@
2001-02-13 Alexander Larsson <alexl@redhat.com>
* gdk/linux-fb/gdkcursor-fb.c (gdk_fb_cursor_unhide):
Don't reference last_cursor if it is null. Fixes crash when rotating
the screen before having moved the mouse.
* gdk/linux-fb/gdkcc-fb.c: Zapp!
* gdk/linux-fb/Makefile.am: Don't compile gdkcc-fb.c
* gdk/linux-fb/gdkwindow-fb.c: Fix typo. width->height. Fixes redraw when
using 90 or 270 degrees rotation.
2001-02-12 Havoc Pennington <hp@pobox.com>
* gdk/gdkpango.c (gdk_pango_get_gc): fix bug where

View File

@ -1,3 +1,16 @@
2001-02-13 Alexander Larsson <alexl@redhat.com>
* gdk/linux-fb/gdkcursor-fb.c (gdk_fb_cursor_unhide):
Don't reference last_cursor if it is null. Fixes crash when rotating
the screen before having moved the mouse.
* gdk/linux-fb/gdkcc-fb.c: Zapp!
* gdk/linux-fb/Makefile.am: Don't compile gdkcc-fb.c
* gdk/linux-fb/gdkwindow-fb.c: Fix typo. width->height. Fixes redraw when
using 90 or 270 degrees rotation.
2001-02-12 Havoc Pennington <hp@pobox.com>
* gdk/gdkpango.c (gdk_pango_get_gc): fix bug where

View File

@ -1,3 +1,16 @@
2001-02-13 Alexander Larsson <alexl@redhat.com>
* gdk/linux-fb/gdkcursor-fb.c (gdk_fb_cursor_unhide):
Don't reference last_cursor if it is null. Fixes crash when rotating
the screen before having moved the mouse.
* gdk/linux-fb/gdkcc-fb.c: Zapp!
* gdk/linux-fb/Makefile.am: Don't compile gdkcc-fb.c
* gdk/linux-fb/gdkwindow-fb.c: Fix typo. width->height. Fixes redraw when
using 90 or 270 degrees rotation.
2001-02-12 Havoc Pennington <hp@pobox.com>
* gdk/gdkpango.c (gdk_pango_get_gc): fix bug where

View File

@ -31,7 +31,6 @@ libgdkinclude_HEADERS= \
libgdk_linux_fb_la_SOURCES = \
gdkcolor-fb.c \
gdkcc-fb.c \
gdkcursor-fb.c \
gdkdnd-fb.c \
gdkdrawable-fb2.c \

File diff suppressed because it is too large Load Diff

View File

@ -203,7 +203,7 @@ gdk_colormap_new (GdkVisual *visual,
#define MIN_SYNC_TIME 2
void
static void
gdk_colormap_sync (GdkColormap *colormap,
gboolean force)
{

View File

@ -362,7 +362,6 @@ gdk_fb_cursor_unhide()
GdkDrawableFBData *pixmap_last;
last_private = GDK_CURSOR_FB (last_cursor);
pixmap_last = GDK_DRAWABLE_IMPL_FBDATA (last_private->cursor);
cursor_visibility_count++;
g_assert (cursor_visibility_count <= 1);
if (cursor_visibility_count < 1)
@ -373,6 +372,8 @@ gdk_fb_cursor_unhide()
if (last_cursor)
{
pixmap_last = GDK_DRAWABLE_IMPL_FBDATA (last_private->cursor);
if (!last_contents ||
pixmap_last->width > GDK_DRAWABLE_IMPL_FBDATA (last_contents)->width ||
pixmap_last->height > GDK_DRAWABLE_IMPL_FBDATA (last_contents)->height)

View File

@ -1578,7 +1578,7 @@ gdk_window_fb_get_visible_region (GdkDrawable *drawable)
screen_rect.x = -priv->abs_x;
screen_rect.y = -priv->abs_y;
screen_rect.width = gdk_display->fb_width;
screen_rect.height = gdk_display->fb_width;
screen_rect.height = gdk_display->fb_height;
gdk_rectangle_intersect (&result_rect, &screen_rect, &result_rect);