callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

do_move_region_bits_on_impl needs to copy from overlapping native windows too

Browse Source 
It can happen that another native window is re-shaped over the region to
be moved, this will not destroy the data (since we're unsetting the background
when we reshape), but it will mean we need to read from this window.

We already used INCLUDE_INFERIORS, but that only handle subwindows. We fix
this by doing the copy on the toplevel, offsetting the copy to compensate for
this.
This commit is contained in:
Alexander Larsson
2009-01-20 22:29:19 +01:00
committed by Alexander Larsson
parent 6b15e248fa
commit df4f4c14c7
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gdk/gdkwindow.c
View File

@ -2447,9 +2447,21 @@ do_move_region_bits_on_impl (GdkWindowObject *private,
gdk_region_get_clipbox (region, &copy_rect);
gdk_region_offset (region, -dest_off_x, -dest_off_y);
/* We need to get data from subwindows here, because we might have
moved or shaped a native window over the moving region (with bg none,
so the pixels are still there). */
* shaped a native window over the moving region (with bg none,
* so the pixels are still there). In fact we might need to get data
* from overlapping native window that are not children of this window,
* so we copy from the toplevel with INCLUDE_INFERIORS.
*/
private = gdk_window_get_impl_window (private);
while (private->parent != NULL &&
GDK_WINDOW_TYPE (private->parent) != GDK_WINDOW_ROOT)
{
dx -= private->parent->abs_x + private->x;
dy -= private->parent->abs_y + private->y;
private = gdk_window_get_impl_window (private->parent);
}
tmp_gc = _gdk_drawable_get_subwindow_scratch_gc ((GdkWindow *)private);
gdk_gc_set_clip_region (tmp_gc, region);
gdk_draw_drawable (dest,