gtkplacessidebar.c: add bookmark null checking
This fixes nautilus crash and perhaps other callers issues. Nautilus (and sometimes glib) crashes with malformed URI inside of the bookmarks file .config/gtk-3.0/bookmarks when it has no LABEL. This is result from the closed glib MR #2065 analysis and agreement. https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2065#note_1091979 Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> Fixes: #4643
This commit is contained in:
		 Geyslan G. Bem
					Geyslan G. Bem
				
			
				
					committed by
					
						 Matthias Clasen
						Matthias Clasen
					
				
			
			
				
	
			
			
			 Matthias Clasen
						Matthias Clasen
					
				
			
						parent
						
							84386c6466
						
					
				
				
					commit
					c7f9c80eb5
				
			| @ -866,6 +866,9 @@ on_bookmark_query_info_complete (GObject      *source, | ||||
|     { | ||||
|       /* Don't add non-UTF-8 bookmarks */ | ||||
|       bookmark_name = g_file_get_basename (root); | ||||
|       if (bookmark_name == NULL) | ||||
|         goto out; | ||||
|  | ||||
|       if (!g_utf8_validate (bookmark_name, -1, NULL)) | ||||
|         { | ||||
|           g_free (bookmark_name); | ||||
|  | ||||
		Reference in New Issue
	
	Block a user