callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ref the popover before activating the item

Browse Source 
Otherwise the item could cause the popover to be destroyed,
for example a Quit item, and cause a warning to be printed.
This commit is contained in:
Garrett Regier
2014-08-23 06:55:07 -07:00
parent 08066b1009
commit 907dae414a
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
gtk/gtkmenusectionbox.c
View File

@ -145,11 +145,24 @@ gtk_popover_item_activate (GtkWidget *button,
gpointer user_data)
{
GtkMenuTrackerItem *item = user_data;
GtkWidget *popover = NULL;
if (gtk_menu_tracker_item_get_role (item) == GTK_MENU_TRACKER_ITEM_ROLE_NORMAL)
{
/* Activating the item could cause the popover
* to be free'd, for example if it is a Quit item
*/
popover = g_object_ref (gtk_widget_get_ancestor (button,
GTK_TYPE_POPOVER));
}
gtk_menu_tracker_item_activated (item);
if (gtk_menu_tracker_item_get_role (item) == GTK_MENU_TRACKER_ITEM_ROLE_NORMAL)
gtk_widget_hide (gtk_widget_get_ancestor (button, GTK_TYPE_POPOVER));
if (popover != NULL)
{
gtk_widget_hide (popover);
g_object_unref (popover);
}
}
static void