Commit Graph

8664 Commits

Author SHA1 Message Date
ca9825ecc5 added macro GIMP_PERSPECTIVE_CLONE_TOOL_GET_OPTIONS()
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpperspectiveclonetool.h: added macro
	GIMP_PERSPECTIVE_CLONE_TOOL_GET_OPTIONS()

	* app/tools/gimpperspectiveclonetool.c: use it. Some minor
	cleanups, removed unused includes.
2006-09-13 18:00:30 +00:00
1303b872e7 tools/pdbgen/pdb/color.pdb tools/pdbgen/pdb/drawable.pdb
2006-09-13  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/color.pdb
	* tools/pdbgen/pdb/drawable.pdb
	* tools/pdbgen/pdb/image.pdb
	* tools/pdbgen/pdb/layer.pdb
	* tools/pdbgen/pdb/paint_tools.pdb
	* tools/pdbgen/pdb/selection_tools.pdb: use the canonical form
when
	refering to parameters in the procedure description.
2006-09-13 17:56:40 +00:00
d607b7da4d cosmetic cleanups, renamed gimp_smudge_nonclipped_painthit_coords() to
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpsmudge.c: cosmetic cleanups, renamed
	gimp_smudge_nonclipped_painthit_coords() to
	gimp_smudge_brush_coords ().
2006-09-13 17:32:36 +00:00
0fb9104817 removed "Resize" from the tool name and description.
2006-09-13  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcroptool.c (gimp_crop_tool_register): removed
	"Resize" from the tool name and description.
2006-09-13 16:03:24 +00:00
56cf1aba38 changed mnemonics (bug #355761).
2006-09-13  Sven Neumann  <sven@gimp.org>

	* app/dialogs/preferences-dialog.c: changed mnemonics (bug #355761).
2006-09-13 15:50:39 +00:00
7b53b46ba1 ref the context before destroying the dialog.
2006-09-13  Sven Neumann  <sven@gimp.org>

	* app/dialogs/image-new-dialog.c (image_new_create_image): ref the
	context before destroying the dialog.
2006-09-13 12:13:33 +00:00
a4edd11b28 simplified by calling gimp_draw_tool_pause/resume() unconditionally (it
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpbrushtool.c: simplified by calling
	gimp_draw_tool_pause/resume() unconditionally (it does no harm,
	regardless of whether the tool is in color picking mode or not).
	Return early in gimp_brush_tool_draw() if color picking is
	enabled.

	* app/tools/gimpsmudgetool.c (gimp_smudge_tool_init): don't enable
	color picking, the tool doesn't use FG or BG.
2006-09-13 11:04:49 +00:00
2e0f6b6b02 chain up before clearing src_drawable and src_display, so the draw tool
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpsourcetool.c (gimp_source_tool_control): chain
	up before clearing src_drawable and src_display, so the draw
	tool can undraw the source marker. Fixes bug #355746.
2006-09-13 10:56:24 +00:00
c8800a628b don't access the src_pickable when cloning from a pattern. Fixes runtime
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpclone.c (gimp_clone_motion): don't access the
	src_pickable when cloning from a pattern. Fixes runtime warnings.
2006-09-13 10:53:22 +00:00
0a341138e2 app/tools/gimpmeasuretool.h fixed _GET_OPTIONS() macros.
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpmeasuretool.h
	* app/tools/gimppainttool.h: fixed _GET_OPTIONS() macros.
2006-09-13 10:44:40 +00:00
bd754a97b0 update coordinates in status bar.
2006-09-13  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpblendtool.c (gimp_blend_tool_active_modifier_key):
	update coordinates in status bar.
2006-09-13 10:06:49 +00:00
7dc4ad0f8e update status bar and optional dialog window.
2006-09-13  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpmeasuretool.c
(gimp_measure_tool_active_modifier_key):
	update status bar and optional dialog window.
2006-09-13 06:49:20 +00:00
3bc9a7af2d added local "gboolean press" variables to improve readability.
2006-09-13  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimptool.c (gimp_tool_set_active_modifier_state):
	added local "gboolean press" variables to improve readability.

2
2006-09-12 22:55:03 +00:00
2ab5d86ae8 implement active_modifier_key() and give immediate feedback when Control
2006-09-12  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpmeasuretool.[ch]: implement active_modifier_key()
	and give immediate feedback when Control (constrain to 15 degrees)
	is toggled. Did a s/mtool/measure/g.
2006-09-12 20:24:50 +00:00
8f9864755f reset the active_modifier_state *after* invoking the tool's
2006-09-12  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimptool.c (gimp_tool_button_release): reset the
	active_modifier_state *after* invoking the tool's button_release().

	* app/tools/gimpblendtool.[ch]: implement active_modifier_key()
	and give immediate feedback when Control (constrain to 15 degrees)
	is toggled.
2006-09-12 19:36:05 +00:00
868b8afbff Added new tool API for modifier key events while the tool is active and
2006-09-12  Michael Natterer  <mitch@gimp.org>

	Added new tool API for modifier key events while the tool
	is active and implement it in the rect select and crop tools.
	Fixes bug #316156 and bug #355302.

	* app/tools/gimptool.[ch]: added GimpTool::active_modifier_key()
	and public function gimp_tool_set_active_motifier_state(). Remember
	the active_state at button_press and reset it on button_release.
	Ignore releases of modifiers that were pressed at button_press (but
	only ignore them once).

	* app/tools/tool_manager.[ch]: added wrapper
	tool_manager_active_modifier_state_active().

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_events): return FALSE for all modifiers even
	when mouse button 1 is pressed.

	(gimp_display_shell_canvas_tool_events): when bouse button 1 is
	pressed *and* the tool is active, dispatch the new active_modifier
	events to tools.

	* app/tools/gimpcroptool.c
	* app/tools/gimprectangleselecttool.c
	* app/tools/gimprectangletool.[ch]: implement active_modifier_key()
	instead of modifier_key().
2006-09-12 18:41:09 +00:00
79d3d2915c need to restart the selection here. Should fix bug #355395 and bug
2006-09-12  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-selection.c (selection_undraw):
need
	to restart the selection here. Should fix bug #355395 and bug
#355456.
2006-09-12 18:04:08 +00:00
7cbb46b2f0 if the "bad" cursor modifier is set, show the cursor regardless of the
2006-09-12  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpbrushtool.c (gimp_brush_tool_cursor_update): if
	the "bad" cursor modifier is set, show the cursor regardless of
	the gimprc "show-paint-tool-cursor" setting.
2006-09-12 14:24:10 +00:00
ff45766f9b made gimp_source_core_motion() a public function for the time being,
2006-09-12  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpsourcecore.[ch]: made gimp_source_core_motion() a
	public function for the time being, pending further refactoring.

	* app/paint/gimpperspectiveclone.[ch]: derive from GimpClone and
	remove everything that is already imeplemented in the parent
	classes. Particullarly, removed motion() implementation in favor
	of a get_source() implementation and simply use GimpClone's
	motion(). Also refuse to work on indexed drawables.

	* app/paint/gimpperspectivecloneoptions.[ch]: derive from
	GimpCloneOptions and remove everything that is already done by the
	parent classes.

	* app/tools/gimpperspectiveclonetool.c: changed
	accordingly. Doesn't derive from GimpSourceTool yet since there is
	some virtual function refactoring in GimpSourceTool missing.
2006-09-12 12:57:55 +00:00
a03e14af1a app/composite/gimp-composite-generic.c app/core/gimpimage-convert.c
2006-09-12  Sven Neumann  <sven@gimp.org>

	* app/composite/gimp-composite-generic.c
	* app/core/gimpimage-convert.c
	* app/actions/view-actions.c
	* app/dialogs/grid-dialog.c
	* app/dialogs/offset-dialog.c
	* app/dialogs/palette-import-dialog.c
	* app/display/gimpnavigationeditor.c
	* app/tools/gimpiscissorstool.c
	* app/widgets/gimptoolbox-image-area.c
	* plug-ins/common/CML_explorer.c
	* plug-ins/common/apply_lens.c
	* plug-ins/common/cubism.c
	* plug-ins/common/curve_bend.c
	* plug-ins/common/exchange.c
	* plug-ins/common/fp.c
	* plug-ins/common/gif.c
	* plug-ins/common/iwarp.c
	* plug-ins/common/laplace.c
	* plug-ins/common/mapcolor.c
	* plug-ins/common/nlfilt.c
	* plug-ins/common/nova.c
	* plug-ins/common/psp.c
	* plug-ins/common/randomize.c
	* plug-ins/common/sparkle.c
	* plug-ins/common/tga.c
	* plug-ins/common/threshold_alpha.c
	* plug-ins/common/unsharp.c
	* plug-ins/common/vpropagate.c
	* plug-ins/gfig/gfig-dialog.c
	* plug-ins/gflare/gflare.c
	* plug-ins/ifscompose/ifscompose.c: removed unused macros.
2006-09-12 11:46:10 +00:00
541d75a00b removed unused variables.
2006-09-12  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpviewrenderer-frame.c: removed unused variables.
2006-09-12 10:46:07 +00:00
d19c796234 applied a modified patch from David Gowers that changes the search
2006-09-12  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimppaletteeditor.c (gimp_palette_editor_get_index):
	applied a modified patch from David Gowers that changes the search
	behaviour to favour colors in the neighborhood of the selected color
	(bug #355520).
2006-09-12 10:37:45 +00:00
d61e8e49e6 chain up to activate/halt the tool.
2006-09-12  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpcolortool.c (gimp_color_tool_button_press)
	(gimp_color_tool_button_release): chain up to activate/halt the tool.

	* app/tools/gimppainttool.c (gimp_paint_tool_button_press)
	(gimp_paint_tool_button_release)
	(gimp_paint_tool_motion): if the color tool is enabled, chain up
	early and return. Fixes selection PAUSE/RESUME mismatch that was
	hiding this display's selection forever when moving sample points.
2006-09-12 09:05:41 +00:00
05cd50c9f6 app/display/gimpdisplayshell-callbacks.c
2006-09-12  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-callbacks.c
	* app/tools/gimpforegroundselecttool.c
	* app/tools/gimpmovetool.c
	* app/tools/gimppainttool.c
	* app/tools/gimprectangletool.c
	* app/tools/gimpselectiontool.c
	* app/tools/gimpsourcetool.c
	* app/tools/gimpvectortool.c: back out change committed on
	2006-08-21 which passed modifier events to tools even while mouse1
	was down. This generated way too much unexpected events that would
	have to be special cased in all tools. Will implement an anternate
	solution soon.
2006-09-12 08:33:30 +00:00
bc59e06fc5 removed unused includes.
2006-09-12  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcontainerpopup.c: removed unused includes.
2006-09-12 07:18:30 +00:00
7053e3daac app/tools/gimpclonetool.c app/tools/gimpconvolvetool.c
2006-09-12  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpclonetool.c
	* app/tools/gimpconvolvetool.c
	* app/tools/gimpcroptool.c
	* app/tools/gimpcurvestool.c
	* app/tools/gimpdodgeburntool.c
	* app/tools/gimperasertool.c
	* app/tools/gimppainttool.c
	* app/tools/gimpperspectiveclonetool.c
	* app/tools/gimpregionselecttool.c
	* app/tools/gimpselectiontool.c
	* app/tools/gimpsmudgetool.c
	* app/tools/gimpvectortool.c: removed trailing dot from
statusbar
	messages.

	* app/widgets/gimpwidgets-utils.c (gimp_suggest_modifiers):
don't
	use "try" if the modifier action has been specified.
2006-09-12 06:37:54 +00:00
ceb1fc5394 string changes.
2006-09-11  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpimagepropview.c: string changes.
2006-09-11 21:27:11 +00:00
290435c59c added a convenience function to retrieve the translated procedure label.
2006-09-11  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimppluginmanager.[ch]: added a convenience function
	to retrieve the translated procedure label.

	* app/widgets/gimpfiledialog.c
	* app/widgets/gimpimagepropview.c: use it.
2006-09-11 15:51:39 +00:00
b57c52b3b3 corrected comment.
2006-09-11  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimppluginmanager-locale-domain.h: corrected comment.

	* app/widgets/gimpimagepropview.[ch]: added file related info to
	the Image Properties dialog as requested in bug #86276.
2006-09-11 15:27:21 +00:00
6fb2147c9a pass the user context to gimp_container_combo_box_new().
2006-09-11  Sven Neumann  <sven@gimp.org>

	* app/dialogs/preferences-dialog.c: pass the user context to
	gimp_container_combo_box_new().
2006-09-11 14:21:03 +00:00
b22ab6693e use "Solid color" as description for GIMP_STROKE_STYLE_SOLID.
2006-09-11  Sven Neumann  <sven@gimp.org>

	* app/core/core-enums.[ch]: use "Solid color" as description for
	GIMP_STROKE_STYLE_SOLID.

	* app/widgets/gimpstrokeeditor.c: moved "style" control further up
	to make it less ambiguous (bug #309740).

	* app/dialogs/stroke-dialog.c (stroke_dialog_new): pass the context
	to gimp_container_combo_box_new().
2006-09-11 14:17:43 +00:00
7a21918c54 minor cleanup.
2006-09-11  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-selection.c: minor cleanup.
2006-09-11 10:54:17 +00:00
0c36c0ee54 don't just unconditionally use the active tool for sample point moving if
2006-09-11  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_ruler_button_press): don't just
	unconditionally use the active tool for sample point moving if it
	is a GimpColorTool, use it only if it is a GimpColorTool but *not*
	a GimpPaintTool with color picking disabled. Fixed bug #355237.
2006-09-11 07:59:12 +00:00
ba4db39c9d after appending an extension, invoke "response" on the dialog and bail
2006-09-10  Michael Natterer  <mitch@gimp.org>

	* app/dialogs/file-save-dialog.c (file_save_dialog_check_uri):
	after appending an extension, invoke "response" on the dialog and
	bail out, so the file chooser re-runs the overwrite-confirm check.
2006-09-10 11:55:43 +00:00
3ff51fb4e3 app/errors.c minor cleanup.
2006-09-10  Sven Neumann  <sven@gimp.org>

	* app/errors.c
	* app/gui/gui-vtable.c: minor cleanup.
2006-09-10 11:39:24 +00:00
9eb90fe54e changed src_pickable parameter to src_type.
2006-09-09  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpclone.c (gimp_clone_line_image): changed src_pickable
	parameter to src_type.

	(gimp_clone_motion): allow the passed srcPR to have alpha even if
	the source pickable is flat. Pass the correct GimpImageType to
	gimp_clone_line_image().
2006-09-09 18:06:24 +00:00
6b09c1f604 app/app_procs.c moved some code from app_run() to errors_init().
2006-09-09  Sven Neumann  <sven@gimp.org>

	* app/app_procs.c
	* app/errors.[ch]: moved some code from app_run() to
errors_init().
2006-09-09 17:31:28 +00:00
188bbe5d37 app/app_procs.[ch] initialize the error subsystem after the gimp object
2006-09-09  Sven Neumann  <sven@gimp.org>

	* app/app_procs.[ch]
	* app/main.c: initialize the error subsystem after the gimp
object
	has been created.

	* app/errors.[ch]: store a reference to the gimp object (eek)
and
	use it to call gimp_gui_ungrab() before g_on_error_query().

	* app/core/gimp-gui.[ch]
	* app/gui/gui-vtable.c: added gimp_gui_ungrab().
2006-09-09 16:36:15 +00:00
beb9cae497 added missing include.
2006-09-09  Sven Neumann  <sven@gimp.org>

	* app/dialogs/about-dialog.c: added missing include.

	* app/display/display-enums.[ch]
	* app/dialogs/preferences-dialog.c: changed labels for
	"space-bar-action" preference. Suggestions welcome for further
	improvements.
2006-09-09 00:36:23 +00:00
fc40c485eb use coordinates from the current device when starting to scroll. Grab the
2006-09-08  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-callbacks.c: use coordinates from
	the current device when starting to scroll. Grab the keyboard
and
	pointer when panning with the space bar.
2006-09-08 19:36:02 +00:00
26fcd6b165 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/text/gimptextlayout-render.c (gimp_text_layout_render_glyphs):
	handle tabs correctly, as instructed by behdad.  Fixes
	bug #353132.
2006-09-08 18:48:39 +00:00
6276fdfc8a added GUI for "space-bar-action".
2006-09-08  Sven Neumann  <sven@gimp.org>

	* app/dialogs/preferences-dialog.c: added GUI for "space-bar-action".
2006-09-08 16:04:09 +00:00
93a9ad8c13 must not clamp the paint area against the boundary of the src_tiles.
2006-09-08  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpperspectiveclone.c (gimp_perspective_clone_motion):
	must not clamp the paint area against the boundary of the
	src_tiles. Various small cleanups.

	* app/paint/gimpsourcecore.[ch] (GimpSourceCore::motion): removed
	src_image parameter.

	Added new virtual function GimpSourceCore::get_source() and moved
	the source PR initialization code to its default implementation.
	(GimpPerspectiveClone will override this method later).

	* app/paint/gimpclone.c (gimp_clone_motion)
	* app/paint/gimpheal.c (gimp_heal_motion): changed accordingly.
2006-09-08 15:15:59 +00:00
d01cef075b app/config/gimpdisplayconfig.[ch] app/config/gimprc-blurbs.h added new
2006-09-08  Sven Neumann  <sven@gimp.org>

	* app/config/gimpdisplayconfig.[ch]
	* app/config/gimprc-blurbs.h
	* app/display/display-enums.[ch]: added new gimprc option
	"space-bar-action" and default to "pan". Will add a GUI for this later.

	* app/display/gimpdisplayshell-callbacks.c: respect the new option
	and either pan the display or push the move tool. Fixes bug #349903.
2006-09-08 15:05:36 +00:00
2426755ba9 added function gimp_get_tool_info().
2006-09-08  Sven Neumann  <sven@gimp.org>

	* app/core/gimp.[ch]: added function gimp_get_tool_info().

	* app/actions/tools-commands.c
	* app/actions/vectors-commands.c
	* app/tools/gimppainttool.c
	* app/widgets/gimpdrawabletreeview.c
	* app/widgets/gimpselectioneditor.c
	* app/widgets/gimptoolbox.c: use the new function instead of poking
	into gimp->tool_info_list.

	* app/display/gimpdisplayshell-callbacks.c
	* app/display/gimpdisplayshell.[ch]: moved code that deals with
	the space key into separate functions. Added space_shaded_tool
	to GimpDisplayShell instead of using a static variable for it.

	* app/tools/tool_manager.c: removed unused include.
2006-09-08 13:42:00 +00:00
13a2beb532 mark "Space" and "Backslash" for translation (using the same translation
2006-09-08  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpwidgets-utils.c: mark "Space" and "Backslash"
	for translation (using the same translation context as in GTK+).
2006-09-08 12:46:53 +00:00
ccb25e3798 updated
2006-09-08  Hans Breuer  <hans@breuer.org>

	* **/makefile.msc app/gimpcore.def : updated

	* app/paint/gimpperspectiveclone.c : error C2057: expected constant
	expression. Stack allocation of dynamic sized arrays is afaik a GCC
	extension, use g_alloca() instead.
2006-09-08 11:45:06 +00:00
1c309997e7 fix the tool's menu path and accelerator.
2006-09-08  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpperspectiveclonetool.c
	(gimp_perspective_clone_tool_register): fix the tool's menu path
	and accelerator.
2006-09-08 08:39:55 +00:00
1b1497657a Merged the "soc-2006-perspective-clone" branch. That branch is now
2006-09-07  Michael Natterer  <mitch@gimp.org>

	Merged the "soc-2006-perspective-clone" branch. That branch is
	now officially closed and all further fixes and changes have to
	be applied to HEAD.

	Did some minor adjustments, mostly small indentation and spacing
	fixes. Derive the tool from GimpBrushTool and renamed the enum
	added to paint-enums.h and it values, added stock icon and menu
	entry.

	Thanks a lot to Pedro Alonso Ferrer!

	* app/paint/paint-enums.[ch]: new enum GimpPerspectiveCloneMode.

	* app/paint/Makefile.am
	* app/paint/gimpperspectiveclone.[ch]
	* app/paint/gimpperspectivecloneoptions.[ch]: the perspective
	clone core and its options.

	* app/paint/gimp-paint.c: register it.

	* app/tools/Makefile.am
	* app/tools/gimpperspectiveclonetool.[ch]: the perspective clone tool.

	* app/tools/gimp-tools.c: register it.

	* app/tools/gimppaintoptions-gui.c: show the widgets that are used
	by perspective clone.

	* app/widgets/gimphelp-ids.h: the help ID.

	* themes/Default/images/Makefile.am
	* themes/Default/images/tools/stock-tool-perspective-clone-16.png
	* themes/Default/images/tools/stock-tool-perspective-clone-22.png
	* libgimpwidgets/gimpstock.[ch]: its stock ID and icons.

	* menus/image-menu.xml.in: added it to the menu.
2006-09-07 17:10:22 +00:00
58908ecf4d removed unused variable.
2006-09-07  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpfreeselecttool.c: removed unused variable.
2006-09-07 12:57:06 +00:00