Commit Graph

8664 Commits

Author SHA1 Message Date
5c0ff0f6e2 removed dead code.
2006-11-07  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c: removed dead code.
2006-11-08 07:22:42 +00:00
a44f83c66c simplified.
2006-11-07  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c
(gimp_rectangle_tool_oper_update):
	simplified.
2006-11-07 22:07:22 +00:00
f47f58886a undef DEBUG_SPEW again.
2006-11-07  Sven Neumann  <sven@gimp.org>

	* app/dialogs/file-save-dialog.c: undef DEBUG_SPEW again.

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_draw):
	don't draw the handles while the rectangle is being moved.
2006-11-07 14:08:14 +00:00
b41bc68023 improved highlighting. (gimp_draw_tool_draw_arc_by_anchor): take width and
2006-11-07  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpdrawtool.[ch] (gimp_draw_tool_draw_corner):
	improved highlighting.
	(gimp_draw_tool_draw_arc_by_anchor): take width and height
	arguments instead of radius_x and radius_y.

	* app/tools/gimpiscissorstool.c
	* app/tools/gimpvectortool.c: slightly increased handle sizes.

	* app/tools/gimpmeasuretool.c: increased size of the end points.

	* app/tools/gimpperspectiveclonetool.c: increased handle size.

	* app/tools/gimprectangletool.c: renamed variables.

	* app/tools/gimpsourcetool.c: use a single define for the target
size.

	* app/tools/gimptransformtool.[ch]: increased handle size. Made
	the area that can be grabbed identical to the displayed handle.
	Replaced filled circle with a circle outline and a cross.

	* app/tools/gimptransformtool-undo.c: follow renaming of define
in
	gimptransformtool.h.
2006-11-07 11:09:51 +00:00
4d6715421f improved error reporting.
2006-11-07  Sven Neumann  <sven@gimp.org>

	* app/file/file-utils.c (file_utils_find_proc): improved error
	reporting.
2006-11-07 11:09:22 +00:00
6577834f1f app/tools/gimpdrawtool.[ch] (gimp_draw_tool_draw_corner) highlight the
2006-11-06  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpdrawtool.[ch] (gimp_draw_tool_draw_corner)
	* app/tools/gimprectangletool.c (gimp_rectangle_tool_draw):
	highlight the handles on mouse-over.
2006-11-06 17:09:07 +00:00
d27e9ead6c simplified.
* app/tools/gimprectangletool.c (gimp_rectangle_tool_draw): simplified.
2006-11-06 16:40:09 +00:00
e192b27f6d let gimp_draw_tool_draw_corner() also handle north, south, east and west
2006-11-06  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpdrawtool.[ch]: let gimp_draw_tool_draw_corner()
	also handle north, south, east and west corners and allow for
	filled corners.

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_draw): simplified.
2006-11-06 16:31:11 +00:00
194f268f89 app/tools/gimpdrawtool.[ch] changed the way that the handles are drawn.
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpdrawtool.[ch]
	* app/tools/gimprectangletool.c: changed the way that the
handles
	are drawn. This is still work in progress.
2006-11-06 08:16:31 +00:00
41611db1a4 formatting.
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/xcf-save.c: formatting.
2006-11-06 08:14:46 +00:00
43b20e0673 use file_utils_uri_display_basename() instead of g_path_get_basename() to
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/dialogs/file-save-dialog.c (file_save_dialog_check_uri):
use
	file_utils_uri_display_basename() instead of
g_path_get_basename()
	to get an uri's basename.
2006-11-06 08:12:57 +00:00
f544132ca5 only save a thumbnail if we are saving as XCF. Fixes bug #25272.
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/file/file-save.c (file_save): only save a thumbnail if we
	are saving as XCF.  Fixes bug #25272.

	* tools/pdbgen/pdb/fileops.pdb: create a libgimp wrapper for the
	"gimp-file-save-thumbnail" procedure.

	* libgimp/gimpfileops_pdb.[ch]: regenerated.

	* plug-ins/common/compressor.c (save_image): ask the core to
save
	a thumbnail for compressed XCF files.
2006-11-06 08:12:37 +00:00
eae43600da *** empty log message *** 2006-11-05 18:53:13 +00:00
029f94f658 made gimp_rectangle_tool_halt() private. Get rid of some more local
2006-11-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangletool.[ch]: made gimp_rectangle_tool_halt()
	private. Get rid of some more local variables (use private->foo
	instead). Fixed statusbar rectangle size display. Some indentation
	cleanup.
2006-11-05 16:36:15 +00:00
cedbebfce3 remove GIMP_CONFIG_PARAM_SERIALIZE from the x0, y0, width, height,
2006-11-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangleoptions.c
	(gimp_rectangle_options_iface_base_init): remove
	GIMP_CONFIG_PARAM_SERIALIZE from the x0, y0, width, height,
	center-x and center-y properties. Fixes bug #346683.
2006-11-05 15:10:57 +00:00
f8edfbd1a5 app/tools/gimpcroptool.c app/tools/gimprectangleselecttool.c moved stuff
2006-11-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpcroptool.c
	* app/tools/gimprectangleselecttool.c
	* app/tools/gimprectangletool.[ch]: moved stuff from
	GimpTool::initialize() to GObject::constructor() and removed all
	initialize functions entirely. initialize() only needs to be
	implemented if the tool has a dialog or if initialization() can
	fail. Also moved some type-checking casts after the
	g_return_if_fail()s
2006-11-05 14:11:34 +00:00
2a64b58c97 cache the round-corners and corner-radius properties in the
2006-11-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangleselecttool.[ch]: cache the round-corners
	and corner-radius properties in the GimpRectSelectTool struct,
	connect to "notify" of GimpRectSelectOptions and update display
	drawing when the options change.

	* app/tools/gimpcroptool.c
	* app/tools/gimprectangleoptions.c: whitespace stuff.
2006-11-05 13:45:04 +00:00
94182f1439 app/tools/gimpcroptool.[ch] app/tools/gimpellipseselecttool.c
2006-11-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpcroptool.[ch]
	* app/tools/gimpellipseselecttool.c
	* app/tools/gimprectangleselecttool.[ch]
	* app/tools/gimprectangletool.[ch]: removed dispose() and
	finalize() implementations. The finalize() ones did nothing and
	dispose() was only redundantly disconnecting from signals that
	were connected using connect_object() anyway. Some cosmetic
	cleanups all over the place.
2006-11-05 12:35:59 +00:00
e2a0604174 app/actions/file-actions.c app/actions/file-commands.[ch] renamed
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/actions/file-actions.c
	* app/actions/file-commands.[ch]
	* menus/image-menu.xml.in: renamed file-open-as-layer to
	file-open-as-layers to complete the changes done to fix bug
#358082.
2006-11-05 11:35:57 +00:00
dff4ef8f57 applied patch from gg that removes duplicated code (bug #358481).
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-region.c: applied patch from gg that
	removes duplicated code (bug #358481).
2006-11-05 09:06:47 +00:00
3499bcaca0 merged all tool options notify callbacks into a single one and added
2006-11-04  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangletool.c: merged all tool options notify
	callbacks into a single one and added utility function
	gimp_rectangle_tool_synthesize_motion() to improve
	maintainability.
2006-11-04 22:39:37 +00:00
05ce1e0179 need to subtract the snap_x and snap_y values from the coords before
2006-11-04  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_motion): need
	to subtract the snap_x and snap_y values from the coords before
	calling ourselves recursively, otherwise we run into an infinite
	recursion.
2006-11-04 20:30:52 +00:00
062cbaa09e removed gimp_rectangle_tool_get_function() and set_function().
2006-11-04  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangletool.c: removed
	gimp_rectangle_tool_get_function() and set_function().
2006-11-04 20:06:31 +00:00
abdb666fe0 pause the draw tool earlier in motion() so we don't get artifacts when the
2006-11-04  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangletool.c: pause the draw tool earlier in
	motion() so we don't get artifacts when the function changes.
	Fixed inside_x and inside_y usage in oper_update(). Get rid of
	some local variables in draw().
2006-11-04 19:50:13 +00:00
33212fe773 fixed snapping. Replaced lots of g_object_get() by simply accessing
2006-11-04  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangletool.c: fixed snapping. Replaced lots of
	g_object_get() by simply accessing private->member. Misc small
	cleanups.
2006-11-04 19:21:15 +00:00
e98c83a523 moved call to gimp_item_get_image() out of the loop.
2006-11-04  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimagemap.c (gimp_image_map_do): moved call to
	gimp_item_get_image() out of the loop.

	* app/base/pixel-region.c
	* app/core/gimpitem.c: formatting.
2006-11-04 18:18:32 +00:00
0e4f794f46 app/widgets/gimpcoloreditor.c temporarily attach the context to the
2006-11-03  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcoloreditor.c
	* app/widgets/gimpcolordialog.c: temporarily attach the context to
	the GimpColorConfig object while calling the color selector's
	set_config().

	* app/widgets/gimpcolorselectorpalette.c: moved widget creation
	and signal connecting to GimpColorSelector::set_config() and
	use the context attached to the passed GimpColorConfig object.
2006-11-03 21:29:42 +00:00
e896521924 added gimp_image_add_layers() which takes a list of layers and vierport
2006-11-03  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpimage.[ch]: added gimp_image_add_layers() which
	takes a list of layers and vierport coordinates to center the
	layers in.

	* app/dialogs/file-open-dialog.c
	* app/display/gimpdisplayshell-dnd.c
	* app/widgets/gimplayertreeview.c: use it instead of having the
	same code three times.
2006-11-03 19:59:30 +00:00
ef52e7a9fd select a matching color in the palette if possible.
2006-11-03  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcolorselectorpalette.c
	(gimp_color_selector_palette_set_color): select a matching color
	in the palette if possible.
2006-11-03 17:39:05 +00:00
cd0c301a3f app/widgets/Makefile.am new widget featuring a proof-of-concept palette
2006-11-03  Michael Natterer  <mitch@gimp.org>

	* app/widgets/Makefile.am
	* app/widgets/gimpcolorselectorpalette.[ch]: new widget featuring
	a proof-of-concept palette color selector. It always shows the
	current palette and doesn't bother to have any features yet. If I
	don't get around finishing this I will disable it for the 2.4
	release, but it's better kept in CVS than on my disk...
	Addresses bug #132146.

	* app/widgets/gimpcolordialog.c (gimp_color_dialog_new): attach
	the passed context to the dialog so the palette selector can find
	it (puke).

	* app/gui/gui.c (gui_restore_callback): register the new object
	with the GType system.
2006-11-03 17:28:52 +00:00
725a4e414f added value GIMP_UNDO_GROUP_LAYER_ADD.
2006-11-03  Michael Natterer  <mitch@gimp.org>

	* app/core/core-enums.[ch] (enum GimpUndoType): added value
	GIMP_UNDO_GROUP_LAYER_ADD.

	* app/file/file-open.[ch]: changed file_open_layer() to
	file_open_layers(), added parameter "gboolean merge_visible",
	return a GList of layers.

	* app/dialogs/file-open-dialog.c
	* app/display/gimpdisplayshell-dnd.c
	* app/widgets/gimplayertreeview.c: pass merge_visible = FALSE and
	add all returned layers to the image. Fixes bug #358082.
	(contains lots of duplicated code, will factor that out later).

	* tools/pdbgen/pdb/fileops.pdb (load_layer): pass merge_visible = TRUE
	(load_layers): new wrapper which returns all the image's layers.

	* app/pdb/fileops_cmds.c
	* app/pdb/internal_procs.c
	* libgimp/gimpfileops_pdb.[ch]: regenerated.

	* libgimp/gimp.def: changed accordingly.
2006-11-03 17:12:27 +00:00
e667ce046a use "Fade" instead of "OK" in action button, added mnemonics.
2006-11-03  Sven Neumann  <sven@gimp.org>

	* app/dialogs/fade-dialog.c (fade_dialog_new): use "Fade" instead
	of "OK" in action button, added mnemonics.
2006-11-03 14:41:27 +00:00
e7f921cb98 app/dialogs/image-properties-dialog.c (image_comment_update) use
2006-11-03  Sven Neumann  <sven@gimp.org>

	* app/dialogs/image-properties-dialog.c (image_comment_update)
	* app/text/gimptext-parasite.c (gimp_text_from_gdyntext_parasite):
	use gimp_any_to_utf8() to deal with invalid UTF-8 strings.
2006-11-03 14:37:01 +00:00
568bbb9558 made non-abstract.
2006-11-03  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpimageparasiteview.[ch]: made non-abstract.

	* app/dialogs/image-properties-dialog.c: show a "Comment" tab if
	the image contains a "gimp-comment" parasite.
2006-11-03 14:22:46 +00:00
4f4dea5645 app/widgets/Makefile.am app/widgets/widgets-types.h new abstract base
2006-11-03  Sven Neumann  <sven@gimp.org>

	* app/widgets/Makefile.am
	* app/widgets/widgets-types.h
	* app/widgets/gimpimageparasiteview.[ch]: new abstract base class.

	* app/widgets/gimpimageprofileview.[ch]: derive from
	GimpImageParasiteView.
2006-11-03 13:52:17 +00:00
96a6a007c1 Don't let each terminating plug-in procedure end its progress, because
2006-11-02  Michael Natterer  <mitch@gimp.org>

	Don't let each terminating plug-in procedure end its progress,
	because that progress may still be in use by another plug-in.

	* app/plug-in/gimpplugin-progress.[ch]
	(gimp_plug_in_progress_attach)
	(gimp_plug_in_progress_detach): new functions which maintain
	a simple attach count for a GimpProgress

	* app/plug-in/gimpplugin-progress.c
	* app/plug-in/gimppluginprocframe.c: call attach() when setting
	proc_frame->progress. Call detach() in gimp_plug_in_progress_end()
	and only call gimp_progress_end() if detaching lowered the attach
	count to 0.
2006-11-02 15:26:03 +00:00
8e22e7c764 fix rendering for n_columns == 1 (bug #369368).
2006-11-02  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpviewrendererpalette.c
	(gimp_view_renderer_palette_render): fix rendering for
	n_columns == 1 (bug #369368).
2006-11-02 12:18:20 +00:00
93caf1f8b1 fix cell_width calculation again so we don't cut off cells. Don't write
2006-11-01  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpviewrendererpalette.c
	(gimp_view_renderer_palette_render): fix cell_width calculation
	again so we don't cut off cells. Don't write beyond the buffer's
	size, fixes random crashes.
2006-11-01 19:13:59 +00:00
21d8268dd3 removed frames. Saves a few pixels and reduces visual clutter.
2006-11-01  Sven Neumann  <sven@gimp.org>

	* app/display/gimpstatusbar.c: removed frames. Saves a few pixels
	and reduces visual clutter.
2006-11-01 15:55:40 +00:00
0370337796 always deal with embedded color profiles.
2006-11-01  Sven Neumann  <sven@gimp.org>

	* app/file/file-open.c: always deal with embedded color profiles.

	* app/dialogs/preferences-dialog.c: reordered items in Color
	Management section, added some spacing.

	* app/config/gimprc-blurbs.h
	* libgimpconfig/gimpcolorconfig.c
	* plug-ins/common/lcms.c: string changes for consistency.
2006-11-01 14:09:29 +00:00
5d48aa2f62 make sure we calculate the right number of columns and don't render more
2006-11-01  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpviewrendererpalette.c
	(gimp_view_renderer_palette_render): make sure we calculate the
	right number of columns and don't render more cells than columns
	in one row.
2006-11-01 03:15:51 +00:00
159dd4f0f5 use "GIMP", not "the GIMP".
2006-11-01  Sven Neumann  <sven@gimp.org>

	* app/config/gimprc-blurbs.h: use "GIMP", not "the GIMP".
2006-11-01 02:37:10 +00:00
e76910fba4 app/widgets/gimpdataeditor.c set the editable state, not the sensitivity
2006-11-01  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpdataeditor.c
	* app/widgets/gimppaletteeditor.c: set the editable state, not
the
	sensitivity of the entries according to the data's editable
state.
2006-11-01 02:20:42 +00:00
e9a778e0e3 removed debugging output 2006-11-01 01:43:05 +00:00
2d16c08e1f string change.
2006-11-01  Sven Neumann  <sven@gimp.org>

	* app/core/core-enums.[ch]: string change.

	* app/dialogs/preferences-dialog.c: added a combo box for the
	color-profile-policy.
2006-11-01 00:54:20 +00:00
40425620f2 in interactive mode, return an extra boolean indicating the choide for the
2006-11-01  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lcms.c: in interactive mode, return an extra
	boolean indicating the choide for the "Don't ask me again"
toggle.

	* app/plug-in/plug-in-icc-profile.c: look for the extra return
	value and update the "color-profile-policy" in gimprc.
2006-11-01 00:30:46 +00:00
b443b138e8 no need to truncate the GValueArray if the plug-in returned too much
2006-11-01  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/gimppluginprocframe.c
	(gimp_plug_in_proc_frame_get_return_vals): no need to truncate the
	GValueArray if the plug-in returned too much values, simply return
	all values instead.
2006-11-01 00:13:41 +00:00
309b21384a declare all register_foo_procs() functions in internal_procs.h instead of
2006-10-31  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/app.pl: declare all register_foo_procs() functions
	in internal_procs.h instead of internal_procs.c and include
	internal_procs.h from all foo_cmds.c files.

	* app/pdb/*_cmds.c
	* app/pdb/internal_procs.[ch]: regenerated.
2006-10-31 19:02:56 +00:00
cd5dbc7767 made private functions static.
2006-10-31  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/pdb/gradient.pdb: made private functions static.

	* app/pdb/gradient_cmds.c: regenerated.
2006-10-31 14:29:08 +00:00
b577b45435 made gimp_display_shell_ruler_button_press() static.
2006-10-31  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-callbacks.c: made
	gimp_display_shell_ruler_button_press() static.
2006-10-30 23:55:53 +00:00