callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

app: fix circle dependency of data attached to an image.

Browse Source 
I had this case with the palette of an indexed image which had its own
reference to the image. So the image would never be freed until the
palette is freed, while the palette is freed in GimpImage's dispose()
code.

Make this a weak reference from GimpData instead.
This commit is contained in:
Jehan
2024-09-21 18:49:32 +02:00
parent 78ee9f56d4
commit f66c9c1996
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/core/gimpdata.c
View File

@ -243,6 +243,7 @@ gimp_data_finalize (GObject *object)
gimp_id_table_remove (data_id_table, private->ID);
g_clear_object (&private->file);
g_clear_weak_pointer (&private->image);
if (private->tags)
{
@ -987,7 +988,7 @@ gimp_data_set_image (GimpData *data,
g_return_if_fail (private->file == NULL);
g_set_object (&private->image, image);
g_set_weak_pointer (&private->image, image);
private->writable = writable ? TRUE : FALSE;
private->deletable = deletable ? TRUE : FALSE;