callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Issue #1783 - Xcf file crashing gimp-console-2.10 ...

Browse Source 
... (Invalid read reported by valgrind)

In gimp_image_parasite_validate(), don't segfault when validating
a "gimp-comment" parasite of size 0 (i.e., whose data is a 0-byte
array, not an empty string), and just consider it invalid.
This commit is contained in:
Ell
2018-07-05 20:26:55 -04:00
parent 6ebadea7c1
commit f384a0713d
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/core/gimpimage.c
View File

@ -3542,12 +3542,15 @@ gimp_image_parasite_validate (GimpImage *image,
{
const gchar *data = gimp_parasite_data (parasite);
gssize length = gimp_parasite_data_size (parasite);
gboolean valid;
gboolean valid = FALSE;
if (data[length - 1] == '\0')
valid = g_utf8_validate (data, -1, NULL);
else
valid = g_utf8_validate (data, length, NULL);
if (length > 0)
{
if (data[length - 1] == '\0')
valid = g_utf8_validate (data, -1, NULL);
else
valid = g_utf8_validate (data, length, NULL);
}
if (! valid)
{