callisto-debian/gimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

app: fix potential segfault in gimp_action_history_activate_callback()

Browse Source 
In gimp_action_history_activate_callback(), bail if history.gimp is
NULL, instead of dereferencing it.  This can happen if GIMP is shut
down during the execution of a temporary procedure, such as a
script-fu script.  See the code comment for details.

(cherry picked from commit 6544ce4301)
This commit is contained in:
Ell
2018-07-05 13:27:02 -04:00
parent 324570712e
commit 9f0f11f44e
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/widgets/gimpaction-history.c
View File

@ -355,11 +355,25 @@ void
gimp_action_history_activate_callback (GtkAction *action,
gpointer user_data)
{
GimpGuiConfig *config = GIMP_GUI_CONFIG (history.gimp->config);
GimpGuiConfig *config;
const gchar *action_name;
GList *link;
GimpActionHistoryItem *item;
/* we can get here after gimp_action_history_exit() has been called, if
* gimp_exit() was called during the execution of a temporary procedure,
* which was executed in response to a GimpProcedureAction, such as a script-
* fu script (temporary procedures run a nested mainloop, during which
* anything can happen.) the GimpProcedureAction's "selected" signal, in
* response to which the procedure is run, is emitted before any user-
* provided "activate" handlers are invoked, and so this function will be
* called *after* the procedure returns.
*/
if (! history.gimp)
return;
config = GIMP_GUI_CONFIG (history.gimp->config);
if (config->action_history_size == 0)
return;