Rename gimp.appdata.xml.in to org.gimp.GIMP.appdata.xml.in.in.

I completely forgot to rename the appstream file according to the new
ID. While doing so, I also make it a .in.in file, with initial
processing by the autotools. Indeed I need @GIMP_COMMAND@ to be replaced
by AC_CONFIG_FILES().
Finally I fix a badly closed XML tag (which reminds me I should always
test a commit, even when it's a simple non-C 1-liner change!).

build/flatpak/org.gimp.GIMP-dev.json

@@ -8,7 +8,6 @@
     "sdk": "org.gnome.Sdk",
     "command": "gimp-2.9",
     "rename-desktop-file": "gimp.desktop",
-    "rename-appdata-file": "gimp.appdata.xml",
     "rename-icon": "gimp",
     "finish-args": ["--share=ipc", "--socket=x11", "--share=network",
                     "--filesystem=host", "--filesystem=xdg-config/GIMP",

build/flatpak/org.gimp.GIMP-nightly.json

@@ -8,7 +8,6 @@
     "sdk": "org.gnome.Sdk",
     "command": "gimp-2.9",
     "rename-desktop-file": "gimp.desktop",
-    "rename-appdata-file": "gimp.appdata.xml",
     "rename-icon": "gimp",
     "finish-args": ["--share=ipc", "--socket=x11", "--share=network",
                     "--filesystem=host", "--filesystem=xdg-config/GIMP",

configure.ac

@@ -2672,6 +2672,7 @@ data/tool-presets/Selection/Makefile
 data/tool-presets/Sketch/Makefile
 desktop/Makefile
 desktop/gimp.desktop.in
+desktop/org.gimp.GIMP.appdata.xml.in
 etc/Makefile
 m4macros/Makefile
 po/Makefile.in

desktop/.gitignore

@@ -1,6 +1,7 @@
 /Makefile.in
 /Makefile
-/gimp.appdata.xml
+/org.gimp.GIMP.appdata.xml.in
+/org.gimp.GIMP.appdata.xml
 /gimp.desktop.in
 /gimp.desktop
 /.thumbnails

desktop/Makefile.am

@@ -3,7 +3,7 @@
 desktop_in_files = gimp.desktop.in.in
 desktop_files = $(desktop_in_files:.desktop.in.in=.desktop)
 
-appstream_in_files = gimp.appdata.xml.in gimp-data-extras.metainfo.xml.in
+appstream_in_files = org.gimp.GIMP.appdata.xml.in gimp-data-extras.metainfo.xml.in
 appstream_files = $(appstream_in_files:.xml.in=.xml)
 
 if DESKTOP_DATADIR

desktop/org.gimp.GIMP.appdata.xml.in.in

@@ -69,7 +69,7 @@
     <!-- Fix the ID renaming, and things like past reviews made on the
          older ID in software installers. -->
     <id>gimp.desktop</id>
-  <provides>
+  </provides>
 
   <releases>
   <!--

desktop/test-appdata.sh

@@ -1,4 +1,4 @@
 #!/bin/sh
 
-appstream-util validate-strict ${GIMP_TESTING_ABS_TOP_SRCDIR}/desktop/gimp.appdata.xml.in
+appstream-util validate-strict ${GIMP_TESTING_ABS_TOP_SRCDIR}/desktop/org.gimp.GIMP.appdata.xml.in.in
 appstream-util validate-strict ${GIMP_TESTING_ABS_TOP_SRCDIR}/desktop/gimp-data-extras.metainfo.xml.in

devel-docs/release-howto.txt

@@ -22,8 +22,8 @@
      to sort out issues with their builds.
 
  ( ) If this is a stable release, make sure we have a <release> tag
-     inside desktop/gimp.appdata.xml.in for this upcoming version. Some
-     installers may feature more prominently software with recent
+     inside desktop/org.gimp.GIMP.appdata.xml.in for this upcoming version.
+     Some installers may feature more prominently software with recent
      releases if the appropriate tag was set (e.g. GNOME Software has a
      "Recent Releases" category).
      If a description is added, it may be featured in installers and

po/POTFILES.in

@@ -3,7 +3,7 @@
 
 [encoding: UTF-8]
 
-desktop/gimp.appdata.xml.in
+desktop/org.gimp.GIMP.appdata.xml.in.in
 desktop/gimp-data-extras.metainfo.xml.in
 desktop/gimp.desktop.in.in