2001-10-11 Jeffrey Stedfast <fejj@ximian.com>
* component-factory.c (free_storage): Make sure the
service/storage are non-NULL.
* mail-callbacks.c (e_gnome_dialog_parent_destroyed): Call
gtk_main_quit.
(send_receive_mail): Don't use e_gnome stuff since this doesn't
need to be run using gnome_dialog_run_and_close().
(composer_send_cb): Same.
(edit_msg): Here too.
(resend_msg): And here.
(search_msg): Same.
(filter_edit): Here too.
(filter_edit): Don't use e_gnome_dialog_set_parent() because we
don't do gnome_dialog_run_and_close on this dialog.
(e_gnome_error_dialog_parented): Removed.
(e_gnome_ok_dialog_parented): Removed.
svn path=/trunk/; revision=13583
2001-10-11 Christopher James Lahey <clahey@ximian.com>
* gal/e-text/e-table-text-model.c (e_table_text_model_insert,
e_table_text_model_insert_length, e_table_text_model_delete),
gal/e-text/e-text-model.c (e_text_model_real_insert,
e_text_model_real_insert_length): Use e_strdup_append_strings here
instead of g_strdup_printf because printf("%.*s") is locale
dependent on some systems.
* gal/util/e-util.c (e_strdup_append_strings): New function to
append a bunch of strings with optional lengths.
svn path=/trunk/; revision=13581
2001-10-11 Jon Trowbridge <trow@ximian.com>
* gui/component/addressbook.c (new_contact_cb): Check that
view->view != NULL.
(save_contact_cb): Check that view->view != NULL.
(search_cb): Check that view->view != NULL.
(delete_contact_cb): Check that view->view != NULL.
(print_cb): Check that view->view != NULL.
(print_preview_cb): Check that view->view != NULL.
(stop_loading_cb): Check that view->view != NULL.
(cut_contacts_cb): Check that view->view != NULL.
(copy_contacts_cb): Check that view->view != NULL.
(paste_contacts_cb): Check that view->view != NULL.
(select_all_contacts_cb): Check that view->view != NULL.
(send_contact_cb): Check that view->view != NULL.
(send_contact_to_cb): Check that view->view != NULL.
(update_command_state): Check that view->view != NULL. Hold a
reference to the AddressbookView for the duration of the function,
in case we exit during bonobo-reentrancy.
(addressbook_view_ref): Added.
(addressbook_view_unref): Added. Simple ref counting for
AddressbookView objects.
(addressbook_view_clear): Zero out an AddressbookView. This is
now separated from the deallocation of the AddressbookView object,
so that we don't leave a dangling pointer if we exit during
bonobo-reentrancy in update_command_state. (Which often seems to
happen if we exit while addressbook operations are going on.)
(destroy_callback): Replace previous call to addressbook_view_free
with addressbook_view_clear/addressbook_view_unref calls.
(addressbook_factory_new_control): Initialize the reference count
in the AddressbookView object.
* gui/widgets/e-addressbook-view.c (e_addressbook_view_destroy):
Carefully zero out our destroyed object.
(command_state_change): Hold a reference to ourselves during the
signal emission.
(get_selected_cards): Ref cards as we add them to the list.
(e_addressbook_view_stop): Check for view != NULL.
(e_addressbook_view_can_create): Check for view != NULL.
(e_addressbook_view_can_print): Check for view != NULL.
(e_addressbook_view_can_save_as): Check for view != NULL.
(e_addressbook_view_can_send): Check for view != NULL.
(e_addressbook_view_can_send_to): Check for view != NULL.
(e_addressbook_view_can_delete): Check for view != NULL.
(e_addressbook_view_can_cut): Check for view != NULL.
(e_addressbook_view_can_copy): Check for view != NULL.
(e_addressbook_view_can_paste): Check for view != NULL.
(e_addressbook_view_can_select_all): Check for view != NULL.
(e_addressbook_view_can_stop): Check for view != NULL.
* gui/widgets/e-addressbook-model.c (addressbook_destroy): Be
careful about zeroing out our destroyed object.
* backend/ebook/e-book-view.c (e_book_view_stop): Added. Stops
event processing in the underlying listener.
svn path=/trunk/; revision=13578
2001-10-10 Jeffrey Stedfast <fejj@ximian.com>
* camel-tcp-stream-openssl.c (ssl_verify): Same hack as below.
* camel-tcp-stream-ssl.c (ssl_bad_cert): Hack around the fact that
adding a cert to nss's certdb seems to not work.
svn path=/trunk/; revision=13575
2001-10-10 <NotZed@Ximian.com>
* camel-vee-folder.c (vee_sync): Only re-build the folder if we're
expunging. Also only clear out the changed folders list if we're
expungung and everything worked.
svn path=/trunk/; revision=13573
2001-10-10 Jon Trowbridge <trow@ximian.com>
* e-msg-composer-hdrs.c (e_msg_composer_hdrs_set_from_account):
Check for either a matching account name, or for a matching e-mail
address embedded in the passed-in string. (Fixes half of bug
#3255)
(destroy): Call bonobo_object_release_unref on corba_select_names,
not CORBA_Object_release. Otherwise we leak stuff all over the
place. (Bug #11878)
* e-msg-composer.c (e_msg_composer_new_with_message): If our message
doesn't contain an X-Evolution-Account header, pass in the From
header as the account name. (Fixes the other half of #3255)
svn path=/trunk/; revision=13567
2001-10-10 Christopher James Lahey <clahey@ximian.com>
* e-cell-popup.c (ecp_get_bg_color), e-cell-tree.c
(ect_get_bg_color): Implement these functions as pass through to
the child cell.
* e-cell-text.c, e-cell-text.h (ect_get_bg_color): Implemented
this using a bg_color_column which can be set through the argument
of the same string.
* e-cell.c, e-cell.h (e_cell_get_bg_color): Added this function to
allow background color to change by cell.
* e-table-item.c (eti_get_cell_background_color): Call
e_cell_get_bg_color to allow background color to change by cell.
svn path=/trunk/; revision=13566
2001-10-10 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-manager.c
(e_select_names_manager_destroy): If our select names dialog is
still around, destroy it. Otherwise, the dialog will hang around
after our composer goes away.
svn path=/trunk/; revision=13565
2001-10-10 Larry Ewing <lewing@ximian.com>
* mail-callbacks.c (mail_generate_reply): use new function to copy
the attachments from the source message. This still isn't perfect
but it should avoid the problems with headers being transfered.
This makes images in replies work again.
svn path=/trunk/; revision=13564
2001-10-10 Larry Ewing <lewing@ximian.com>
* e-msg-composer.h: add prototype.
* e-msg-composer.c (e_msg_composer_add_message_attachments): new
function to copy attachments from the a message to a composer.
(e_msg_composer_set_pending_body): make simple function to
abstract this.
(e_msg_composer_apply_pending_body): apply the pending body to
the composer.
(e_msg_composer_new_with_message): use
e_msg_composer_add_message_attachments to copy attachments.
svn path=/trunk/; revision=13563
2001-10-10 <NotZed@Ximian.com>
* providers/local/camel-maildir-store.c (scan_dir): oops, we want
get_unread_message_count, not get_message_count!
2001-10-09 <NotZed@Ximian.com>
* camel-service.c (camel_service_disconnect): Duplicate connect
code that unregisters a cancel op if we created one.
svn path=/trunk/; revision=13561
2001-10-10 Federico Mena Quintero <federico@ximian.com>
* pcs/cal-factory.c (lookup_backend): Return the original key in
the hash table if requested.
(backend_last_client_gone_cb): Use lookup_backend() so that we
have the URI mangling done for us.
(impl_CalFactory_open): The type should be GtkType *, not GtkType!
svn path=/trunk/; revision=13557
* e-storage.c (e_storage_async_xfer_folder): Make this a no-op if
the source and the destination path are the same.
* e-local-storage.c (impl_async_xfer_folder): return after
returning `E_STORAGE_CANTCHANGESTOCKFOLDER' to the callback.
* e-storage-set-view.c (handle_evolution_path_drag_motion): Make
the check for dragging a folder over itself a little bit more
accurate.
svn path=/trunk/; revision=13550
2001-10-10 Christopher James Lahey <clahey@ximian.com>
Based on patches from Dan Nguyen <dnn@austin.ibm.com>.
* gal/Makefile.am (libgal_la_LDFLAGS): Added $(GTK_LIBS).
* gal/e-text/e-text.c (e_text_event): Changed this from a C++
comment to a C comment.
svn path=/trunk/; revision=13549
2001-10-10 Christopher James Lahey <clahey@ximian.com>
* e-table.c, e-table.h (e_table_get_selection_model): Added this
function.
svn path=/trunk/; revision=13548
2001-10-10 Larry Ewing <lewing@ximian.com>
* mail-display.c (save_url): copy the data. We can't ref the byte
array and we can't free it so we have to copy it.
svn path=/trunk/; revision=13546
2001-10-10 <NotZed@Ximian.com>
* mail-ops.c (transfer_messages_transfer): IF the source and
destination folders are the same, do nothing. Oh, and return an
error, otherwise the shell goes and removes it anyway. Fixes a
rather serious bug with dnd of folders onto their current
location.
2001-10-09 <NotZed@Ximian.com>
* component-factory.c (owner_unset_cb): Disconnect from all the
signals we were listening to, so we dont try and do shit twice on
exit (one on unset_cb, one on destroy).
(create_component): Setup the signal handlers using a table, so
they're easier to disconnect on finish.
svn path=/trunk/; revision=13545
2001-10-09 Larry Ewing <lewing@ximian.com>
* mail-display.c (save_part): ref the part.
(save_destroy_cb): new function to unref the part when we have
closed the dialog.
(save_url): fake a mime part so that we can save data urls without
extra effort. This is less sucky than it seems since it handles
filenames and ref counting with minimal fuss.
svn path=/trunk/; revision=13544
2001-10-09 <NotZed@Ximian.com>
* mail-folder-cache.c (folder_changed): Ref folder so it hangs
around till we're done with it.
(real_folder_changed): Unref folder when we are done with it.
Should fix#11981.
svn path=/trunk/; revision=13543
2001-10-09 Federico Mena Quintero <federico@ximian.com>
Fixes bug #884.
* gui/alarm-notify/save.[ch]: New files with functions to
save/load the last notification time.
* gui/alarm-notify/alarm-queue.c (alarm_trigger_cb): Save the last
notification time.
(alarm_queue_init): Load the last notification time when the
daemon is inited.
(alarm_queue_add_client): Load the alarms that we missed while the
alarm daemon was not running.
(cal_opened_cb): Likewise.
* gui/alarm-notify/Makefile.am (evolution_alarm_notify_SOURCES):
Added save.[ch] to the list of sources.
svn path=/trunk/; revision=13538
2001-10-09 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (add_from_file): If the
attachment fails, report the error to the user.
* e-msg-composer-attachment.c (e_msg_composer_attachment_new): Now
takes a CamelException argument.
svn path=/trunk/; revision=13537
2001-10-09 <NotZed@Ximian.com>
* camel-operation.c (camel_operation_progress): Another go at
getting the logic right again. Make transients only update after
5 seconds (CAMEL_OPERATION_TRANSIENT_DELAY)
(camel_operation_end): Likewise.
svn path=/trunk/; revision=13536
