2000-05-09 Christopher James Lahey <clahey@helixcode.com>
* backend/ebook/e-card-simple.c: Fixed some indentation.
* contact-editor/contact-editor.glade,
contact-editor/e-contact-editor-strings.h: Changed Email to
Primary Email.
* contact-editor/e-contact-editor.c: Added checkmarks to indicate
if data exists in the pull down menus for the phone, address, and
email fields.
svn path=/trunk/; revision=2933
2000-05-09 Christopher James Lahey <clahey@helixcode.com>
* backend/ebook/e-card-simple.c: Fixed the string duplication
problem. Fixed the business/home address string mix up.
* gui/component/addressbook.c: Made the minicard view the default
view.
svn path=/trunk/; revision=2932
* folder-browser.c (folder_browser_load_folder): make this a
little less kludgy. Use gnome_error_dialog rather than printf on
errors.
* mail-ops.c (fetch_mail): Fix to work with the new shell stuff...
sorta. Will need more fixing later when the new shell framework is
more done.
* mail-config.c (finish): Call gnome_config_sync so the data
actually gets written.
svn path=/trunk/; revision=2931
Mon May 8 22:12:55 EDT 2000 Jeffrey Stedfast <fejj@stampede.org>
o updated to use CamelException (as needed by new camel-stream.c)
o no longer frees memory it shouldn't touch
svn path=/trunk/; revision=2929
* mail-display.c (save_data_cb):
(on_url_requested): Update for CamelStream CamelException changes.
* mail-format.c: Pass NULL for a CamelException in a bunch of
places... the user will see that the data is not being displayed,
and there's not a lot we can do, and none of these things should
be failing anyway. Maybe fix this later.
svn path=/trunk/; revision=2925
* camel-stream.c (camel_stream_read, camel_stream_write,
camel_stream_flush, camel_stream_reset, camel_stream_printf,
camel_stream_write_to_stream): Use CamelException to signal
failure.
(camel_stream_write_strings): Remove. camel_stream_printf is more
useful in most of the places that used this.
(camel_stream_write_string): Change from macro to function to
prevent problems with double-evaluation.
* camel-seekable-stream.c (camel_seekable_stream_seek,
camel_seekable_stream_set_bounds): Use CamelException.
(reset): Update.
* camel-seekable-substream.c, camel-stream-buffer.c,
camel-stream-filter.c, camel-stream-fs.c, camel-stream-mem.c:
Update.
* camel-stream-fs.c: Remove the virtual init functions and move
the code into the creator functions. Add CamelExceptions to
creation functions that could fail.
* camel-data-wrapper.c (camel_data_wrapper_write_to_stream): Use
CamelException.
* camel-mime-message.c, camel-mime-part.c, camel-multipart.c
(write_to_stream): Update.
* camel-mime-parser.c: add an exception to the mime parser private
data and pass that to stream functions as needed.
* gmime-content-field.c, md5-utils.c: Update (badly) for stream
changes.
* camel-exception.h (camel_exception_is_set): convenience macro.
* providers/Makefile.am: disable SMTP for now
* providers/mbox/camel-mbox-folder.c (mbox_append_message): Pass
CamelException to the functions that now need it. Check the
exception after calling camel_stream_flush, and fail if it fails.
(mbox_get_message_by_uid): More updates.
* providers/pop/camel-pop3-folder.c,
providers/pop/camel-pop3-store.c,
providers/sendmail/camel-sendmail/transport.c: Update.
svn path=/trunk/; revision=2924
* gui/e-day-view.c (e_day_view_on_delete_appointment): call
e_day_view_stop_editing_event here to avoid a divide by zero
a bit further on. i'm not sure if this is the best fix for this.
svn path=/trunk/; revision=2922
2000-05-08 Federico Mena Quintero <federico@helixcode.com>
* pcs/cal-backend.h (CalBackendClass): CalBackendClass now is just
an interface for calendar backends; this is an abstract class.
Put in the vtable for the backend methods.
* pcs/cal-backend.c (cal_backend_new): Removed function, since
CalBackend is not just an abstract class.
Removed implementation-specific functions and made public
functions call the virtual methods instead.
* pcs/cal-backend-imc.[ch]: New files with the CalBackendIMC
implementation; this implements a backend for iCalendar and
vCalendar files. Moved the implementation-specific stuff from
cal-backend.[ch] to here.
* pcs/cal-backend-imc.c (CalendarFormat): Moved enumeration to
here. Added a CAL_UNKNOWN value for when the backend is not
loaded yet.
(cal_backend_imc_init): Initialize priv->format as CAL_UNKNOWN.
(save_to_vcal): Use the same VCProdIdProp value as in
cal-util/calobj.c. Use "1.0" as the VCVersionProp as per the
vCalendar spec.
(ensure_uid): Return nothing, since the result value need not be
used anymore.
(add_object): Since we mark the calendar as dirty anyways, we do
not need to check the result value of ensure_uid() anymore.
(remove_object): Asssert that we know how to handle the object's
type. We do this in add_object() anyways.
* pcs/Makefile.am (libpcs_a_SOURCES): Added cal-backend-imc.[ch].
* gui/gnome-cal.c: Replaced debugging printf()s with g_message()
so that we can see the line number where they occur.
* gui/gnome-cal.c (gnome_calendar_load_cb): Sort of handle the
LOAD_METHOD_NOT_SUPPORTED result code, and added a default for the
switch.
* cal-client/cal-listener.h (CalListenerLoadStatus): Removed
enumeration; it is stupid to translate all values for the
CalClient when it is going to translate them again.
(CalListenerClass::cal_loaded): This signal now passes the
LoadStatus directly from the CORBA side.
* cal-client/cal-listener.c (Listener_cal_loaded): Do not
translate the status value.
* cal-client/cal-client.h (CalClientLoadStatus): Added the
CAL_CLIENT_LOAD_METHOD_NOT_SUPPORTED error code.
* cal-client/cal-client.c (cal_loaded_cb): Translate the CORBA
version of the LoadStatus result code.
* pcs/cal-factory.c (CalFactoryPrivate): New methods field for the
hash table from method strings to the GtkTypes for backend class
types.
(cal_factory_init): Create the priv->methods hash table.
(cal_factory_destroy): Free the priv->methods hash table.
(cal_factory_register_method): New function to register a backend
class for a particular URI method.
(launch_backend_for_uri): New function to launch a backend for a
particular URI's method.
(load_backend): Use launch_backend_for_uri(). Move the error
notification code from load_fn() to here.
(create_backend): Use launch_backend_for_uri(). Move the error
notification code form create_fn() to here; it is #ifdefed out
since currently cal_backend_create() does not have any error
reporting capabilities.
* idl/evolution-calendar.idl (Listener::LoadStatus): Added a
PROTOCOL_NOT_SUPPORTED error code.
* pcs/cal-factory.c (cal_factory_load cal_factory_create): Removed
functions, since they were supposed to be internal only.
(CalFactory_load): Call queue_load_create_job() directly.
(CalFactory_create): Likewise.
svn path=/trunk/; revision=2921
2000-05-08 Damon Chaplin <damon@helixcode.com>
* gui/e-week-view.c (e_week_view_remove_event_cb):
* gui/e-day-view.c (e_day_view_remove_event_cb): don't set the ico->uid
to NULL or we won't find any other occurrences of the event. Set the
editing_event_day/num to -1 instead.
* gui/e-week-view-event-item.c (e_week_view_event_item_draw): fixed the
positioning of the icons for long events.
* cal-util/calobj.c (ical_object_normalize_summary): forgot to
terminate the string.
svn path=/trunk/; revision=2920
2000-05-08 Christopher James Lahey <clahey@helixcode.com>
* e-cell-text.c: Make multi-line texts display properly. Fixed
some mem leaks.
svn path=/trunk/; revision=2911
2000-05-08 Christopher James Lahey <clahey@helixcode.com>
* backend/ebook/e-card-simple.c: Fixed this up a bit. Syncing
should work better now.
svn path=/trunk/; revision=2910
2000-05-08 NotZed <NotZed@HelixCode.com>
* camel-mime-message.c (process_header): Format From and Reply-To
to at least a decoded string. Should probably store them as an
camelinternetaddress.
svn path=/trunk/; revision=2908
2000-05-08 NotZed <NotZed@HelixCode.com>
* Merged NEW_SUMMARY branch back to trunk, and resolved conflicts.
* providers/mbox/camel-mbox-summary.c (camel_mbox_summary_update):
Return status.
* camel-stream-filter.c (do_close): We NEED a stream close.
svn path=/trunk/; revision=2906
2000-05-07 NotZed <NotZed@HelixCode.com>
* message-list.c (ml_value_at): Size moved to message info, rather
than content info structure.
svn path=/trunk/; revision=2905
2000-05-08 Christopher James Lahey <clahey@helixcode.com>
* gui/minicard/e-minicard-view.c, gui/minicard/e-minicard.c,
gui/minicard/e-minicard.h, gui/minicard/e-reflow-sorted.c,
gui/minicard/e-reflow-sorted.h: Made a minimal number of things be
destroyed and recreated when updating a field.
svn path=/trunk/; revision=2904
2000-05-08 Larry Ewing <lewing@helixcode.com>
* e-shortcuts.c (load_shortcuts_into_view): xmlFree the return
value of xmlGetProp.
svn path=/trunk/; revision=2903
2000-05-07 Larry Ewing <lewing@helixcode.com>
* e-icon-bar.h (struct _EIconBarItem): remove the no longer needed
flatened_alpha member.
* e-icon-bar.c (flatten_alpha): using ~rgb can cause visual
artifacts.
(e_icon_bar_add_item): fixup refcounting of the flattend pixbuf,
the canvas item should hold the reference not us. Stop using
item.flattened_alpha since it no longer exists.
(e_icon_bar_remove_item): remove the unref since destroying the
item will take care of that for us.
* e-shortcut-bar.c (e_shortcut_bar_add_item): make sure to unref
the image we get back, the icon bar will hold any references it
needs.
(e_shortcut_bar_get_image_from_url): ref the default image each
time we return it so that references are counted correctly.
svn path=/trunk/; revision=2902
* gui/minicard/e-minicard.c (remodel): make sure to free the
return value of e_card_simple_get.
* gui/component/addressbook.c (teardown_table_view): destroy the
ECardSimple here, plug memory leak.
(create_table_view): use view->simple so we can destroy the
ECardSimple later on.
svn path=/trunk/; revision=2899
2000-05-08 Christopher James Lahey <clahey@helixcode.com>
* widget/e-text/e-text.c, widgets/e-text/e-text.h: Added an
activate signal.
svn path=/trunk/; revision=2890
* gui/component/addressbook.c (set_prop): don't create a new
ebook. instead, unload the current uri (if there is one) and load
the new one.
svn path=/trunk/; revision=2885
* e-msg-composer.c (build_message): unref content, etc. after
attaching it to message.
* e-msg-composer-attachment-bar.c (attach_to_multipart): unref
part after attaching it.
svn path=/trunk/; revision=2884
* camel-object.c: New subclass of GtkObject which is now the base
of the Camel object hierarchy. Currently the only difference
between CamelObject and GtkObject is that CamelObjects don't start
out floating.
* *.h: Move a bunch of typedefs to camel-types.h. Standardize on
using <camel/foo.h> in header files rather than <foo.h>, "foo.h",
or "camel/foo.h". Remove some unneeded includes.
* camel-address.c, camel-data-wrapper.c, camel-folder-search.c,
camel-folder-summary.c, camel-folder.c, camel-mime-filter.c,
camel-mime-parser.c, camel-service.c, camel-session.c,
camel-stream.c: These are now subclasses of CamelObject.
* camel-data-wrapper.c (set_output_stream):
* camel-medium.c (set_content_object):
* camel-seekable-substream.c
(init_with_seekable_stream_and_bounds):
* providers/mbox/camel-mbox-folder.c (mbox_get_message_by_uid):
remove gtk_object_sink calls.
* camel-stream-buffer.c (init_vbuf):
* camel-stream-filter.c (camel_stream_filter_new_with_stream):
ref the original stream.
* camel-folder-summary.c (camel_folder_summary_finalise): unref
the filters when finalizing.
* camel-mime-part-utils.c
(simple_data_wrapper_construct_from_parser,
camel_mime_part_construct_content_from_parser):
* camel-mime-part.c (camel_mime_part_set_content): Unref objects
that are created only to be handed off to other objects. If
they're going to be needed later, they will have been additionally
ref'ed by the object that needs them.
* providers/pop3/camel-pop3-folder.c (get_message_by_number):
unref the message stream after creating the data from it.
* camel-stream.c, camel-stream-buffer.c, camel-stream-filter.c,
camel-stream-fs.c, camel-stream-mem.c: Remove camel_stream_close,
since its semantics are dubious (what happens when you close a
stream other people still have references on?).
* providers/nntp/camel-nntp-store.c:
* providers/smtp/camel-smtp-transport.c:
* providers/pop3/camel-pop3-store.c:
replace camel_stream_close calls with gtk_object_unref.
* providers/mbox/camel-mbox-folder.c:
* providers/nntp/camel-nntp-folder.c:
* providers/sendmail/camel-sendmail-transport.c:
replace camel_stream_close with camel_stream_flush +
gtk_object_unref
svn path=/trunk/; revision=2882
2000-05-07 Christopher James Lahey <clahey@helixcode.com>
* gui/component/e-addressbook-model.c: Replaced some model_changed
calls with row_inserted calls.
svn path=/trunk/; revision=2881
* folder-browser-factory.c: Changed a toolbar button from saying
"New mail" (which suggests you might be composing new mail) to
"Get mail".
svn path=/trunk/; revision=2880
