There could happen that at the end of the inner call to send_receive()
had been used the 'data' local structure pointer after it had been
freed, which could happen when all configured accounts failed to get
the store. It could strike sometimes when going from offline to online.
Restore the selection position on the end of the spell-check refresh
before unblocking the SelectionChanged callbacks as otherwise the last
selection from doing the refresh will be used as well.
It would be nice to have a way in gtest to mark a test for skipping, but
as there is no way to do it, we will at least print the SKIPPED status
on the console to distinguish tests that are skipped.
Similar to NEWS-file test, add also SKIP_COMMIT_TEST=1 to be able to skip
any such issue. This helps to notice uncommitted changes before the tarball
is created.
Introduce e_mail_display_get_selection_content_multipart_sync() that
will return a current selection with the right mime type (that's
reflecting whether the plain text part of the HTML one is currently
displayed).
Fix couple of issues with e_mail_display_get_selection_plain_text_sync()
* Call the right Web extension method
* Fix a FIXME WK2 comment
* Change the return type to gchar * instead of const gchar * and adapt
the code. Previously we were return a string that belonged to the
GVariant, that contained the result of a DBus call to Web extension.
The problem was that string was freed even before we return it from
the function as it was freed with g_variant_unref().
Previously only Calendars could be selected for Reminder notifications
on a per-source bases in the UI and all Memo/Task Lists were used.
Currently the Edit->Preferences->Calendars and Tasks->Reminders tab
had been extended to allow setting the inclusion for Reminder
notifications for all three types.
When there's set the 'keep-above' flag on the GtkWindow, then the window
itself cannot be moved below other (regular) windows, which may not always
make sense. This option lets the user to decide what he/she prefers.
The former part is good to not reuse D-Bus service name between different processes.
The later part fixes a crash of `test-html-editor-units -p /font/size` where
the test could crashed right after the first finished. The reason was that
the dispose call on the window caused style change signal, which called
ElementSetAttributeBySelector D-Bus method, which may not always finish before
the the WebKitWebProcess stopped, which resulted in a D-Bus error and following
test abort due to a critical warning with that particular error message.