2001-08-02 Jeffrey Stedfast <fejj@ximian.com>
* filter-rule.c: Wrap some debug printf's with d().
* rule-context.h: Removed prototype for rule_context_delete_rule()
since the function doesn't exist.
svn path=/trunk/; revision=11600
2001-08-02 Larry Ewing <lewing@ximian.com>
* mail-send-recv.c (format_url): handle null paths in the dialog
so that we avoid printing NULL strings
svn path=/trunk/; revision=11599
* e-shell-view.c (switch_on_folder_tree_click): Set the
`set_folder_uri' to NULL when freeing it.
* e-task-bar.c (e_task_bar_remove_task): Just destroy the widget.
No need to `gtk_container_remove()' it.
svn path=/trunk/; revision=11597
2001-08-02 Jason Leach <jleach@ximian.com>
* mail-config.glade: Set history_id's for the sig and html sig
gnome file entry boxes so it can persist history, also add titles
to the dialogs that popup when you click the "Browse..." button.
Bug #5595.
svn path=/trunk/; revision=11594
2001-08-02 Jeffrey Stedfast <fejj@ximian.com>
* mail-vfolder.c (vfolder_create_storage): Connect to the
folder_remove signal on the storage.
(vfolder_remove): New function to remove a vfolder.
(vfolder_edit): Raise the window if it already exists.
svn path=/trunk/; revision=11593
2001-08-02 Christopher James Lahey <clahey@ximian.com>
* e-table-item.c (eti_event): Make the right and left key presses
be marked as handled here (i.e., return 1 always.) Fixes Ximian
bug #2090.
svn path=/trunk/; revision=11592
2001-08-02 Jeffrey Stedfast <fejj@ximian.com>
* mail-vfolder.c (vfolder_create_storage): Connect to the
folder_remove signal on the storage.
(vfolder_remove): New function to remove a vfolder.
svn path=/trunk/; revision=11591
2001-08-02 Christopher James Lahey <clahey@ximian.com>
* e-table-item.c: Changed all e_table_model_is_cell_editable calls
in this file to be on the model column instead of the view column.
svn path=/trunk/; revision=11589
2001-08-02 Christopher James Lahey <clahey@ximian.com>
* e-tree.c (et_destroy): Set et->priv to NULL here just to be
sure.
svn path=/trunk/; revision=11588
2001-08-02 Christopher James Lahey <clahey@ximian.com>
* e-table-header-item.c (ethi_drag_data_received): Don't do most
of the work in this function if data->data is NULL. Fixes Ximian
bug #6041.
svn path=/trunk/; revision=11587
2001-08-02 Jason Leach <jleach@ximian.com>
* gui/component/addressbook.c (addressbook_factory_new_control):
Removed some extra padding and pack the addressbook view into a
frame with inward shadowing, just because it looks prettier.
svn path=/trunk/; revision=11585
2001-08-02 Jason Leach <jleach@ximian.com>
* evolution-contact-editor.xml: Update the updated Save, Save As,
and Print icons for menus and the toolbar. Also added a Close
button to the toolbar and some other fixes suggested in #5518.
svn path=/trunk/; revision=11584
2001-08-02 Christopher James Lahey <clahey@ximian.com>
* gui/component/addressbook.c: Added ContactsSaveAsVCard,
ContactsSendContactToOther, and ContactsSendMessageToContact verbs
here.
* gui/widgets/e-addressbook-view.c,
gui/widgets/e-addressbook-view.h (e_addressbook_view_save_as,
e_addressbook_view_send, e_addressbook_view_send_to): New
functions to allow outside users to cause the addressbook to save,
send, or send a message to its selection.
svn path=/trunk/; revision=11568
2001-08-02 Christopher James Lahey <clahey@ximian.com>
* gui/component/addressbook.c: Added ContactsSaveAsVCard,
ContactsSendContactToOther, and ContactsSendMessageToContact verbs
here.
* gui/widgets/e-addressbook-view.c (e_addressbook_view_save_as,
e_addressbook_view_send, e_addressbook_view_send_to): New
functions to allow outside users to cause the addressbook to save,
send, or send a message to its selection.
svn path=/trunk/; revision=11567
2001-08-02 Not Zed <NotZed@Ximian.com>
* Makefile.am (INCLUDES): Add EVOLUTION_BUTTONSDIR to get to some
different icons.
* mail-ops.c (mail_sync_folder): Queue the folder sync operation,
rather than running it in parallel.
* mail-send-recv.c: applies anna's patch for prettier send-recv
dialogue.
(parse_url): Renamed to format_url, fixed callers.
(format_url): Use camel_url_free instead of g_free, also handle
case where we have no host (use path instead).
(build_dialogue): Cleaned up some whitespace.
(build_dialogue): Create the label directly with the right text,
dont set any text in the progress bar, and save the label into the
info struct for later updating.
(struct _send_info): Added 'status' the label with the status
string.
(operation_status_timeout):
(receive_done):
(receive_cancel): Set the status label, not the progress format
text.
(hide_send_info): NULL out status too.
(mail_receive_uri): Init status.
(free_folder_info): Initiate a folder sync here, so we can ...
(free_send_data): ... Remove the awful hack of iterating through
bonobo controls to sync all open folders.
(free_send_data): Initiate a sync of the inbox too.
(build_dialogue): Remove set_alignment on the icon, its not a
gtkmisc object.
svn path=/trunk/; revision=11566
2001-08-01 Federico Mena Quintero <federico@ximian.com>
* gui/calendar-model.c (calendar_model_value_is_empty): If the
default category is the same as the value passed in to this
function, return TRUE. This could be a hack or not, but it
prevents two items from being added to the table if a category is
selected.
* gui/e-tasks.c (setup_widgets): Allow the search bar to shrink
horizontally.
* gui/dialogs/task-page.c (clear_widgets): Pass valid values to
e_dialog_option_menu_set(); these need to come from the status map.
svn path=/trunk/; revision=11565
2001-08-01 Federico Mena Quintero <federico@ximian.com>
* e-table.c (group_cursor_change): Set the et->cursor_loc *before*
committing the click-to-add to avoid reentrancy issues if the
table model changes while the click-to-add is being committed.
svn path=/trunk/; revision=11564
2001-08-01 Christopher James Lahey <clahey@ximian.com>
* e-categories-master-list-wombat.c (ecmlw_load): Fixed the load
statement here by just using array_from_string.
(ecmlw_save): Removed the part where we save the icons and colors
since that's handled in the array_to_string function. Fixes
Ximian bug #4451.
svn path=/trunk/; revision=11561
2001-08-01 Christopher James Lahey <clahey@ximian.com>
* e-table-header-item.c (ethi_change_sort_state): Make this
function not crash if x somehow doesn't land on some column.
Fixes Ximian bug #5957.
* e-table-header-item.c: Removed a bunch of menu items whose
functionality won't be ready for 1.0. Fixes Ximian bug #154.
svn path=/trunk/; revision=11560
2001-08-01 Federico Mena Quintero <federico@ximian.com>
The calendar search bar widget now includes a drop-down menu of
available categories.
* pcs/query.c (func_has_categories): Handle one and only one #f
value as meaning "unfiled", for components that have no categories
at all.
* pcs/cal-backend-file.c (open_cal): Duh, do not notify here about
changed categories since at this point we don't have any clients
bound to us yet.
(create_cal): Likewise.
(cal_backend_file_add_cal): Notify here.
* gui/cal-search-bar.h (CalSearchBarClass): New signal
"category_changed".
* gui/cal-search-bar.c (cal_search_bar_construct): Add a drop-down
menu for the list of categories.
(search_option_items): Removed the "Has category" option, since we
now have the drop-down menu instad and it would be confusing to
have both options.
(regen_query): Likewise. Also, this function is now the old
cal_search_bar_query_changed() and is shared by that very function
and by the callback from the drop-down menu.
(notify_query_contains): Include the sub-sexp for the categories.
(cal_search_bar_set_categories): New function.
(cal_search_bar_get_category): New function.
(categories_selection_done_cb): Emit the "category_changed" signal.
* gui/e-tasks.c (obj_updated_cb): Removed function since it did
not do anything; all updates are handled by the CalendarModel.
(obj_removed_cb): Likewise.
(ETasksPrivate): Removed the fields for the categories option
menu, since now it is in the ESearchBar.
(search_bar_sexp_changed_cb): Use calendar_model_set_query()
directly here, as we do not need to frob the sexp anymore.
(update_query): Removed.
(client_categories_changed_cb): New callback.
(search_bar_category_changed_cb): New callback.
(e_tasks_new_task): Set the default category on the component to
the one that is selected in the search bar.
(e_tasks_on_filter_selected): Removed.
(e_tasks_on_categories_changed): Removed.
(e_tasks_rebuild_categories_menu): Removed.
(e_tasks_add_menu_item): Removed.
(e_tasks_setup_view_menus): Sanitized not to sink objects wildly.
(e_tasks_discard_view_menus): New function.
* gui/calendar-model.h (CalendarModelClass): Removed the
"categories_changed" signal since this is handled in the Wombat
now.
* gui/calendar-model.c (calendar_model_get_categories): Removed.
(calendar_model_set_value_at): Do not collect the categories.
(query_obj_updated_cb): Likewise.
(calendar_model_collect_categories): Removed.
(calendar_model_set_default_category): Constify.
* gui/tasks-control.c (tasks_control_deactivate): Call
e_tasks_discard_view_menus().
* gui/gnome-cal.c (search_bar_category_changed_cb): Set the
default category for the task pad's model.
svn path=/trunk/; revision=11559
2001-08-01 Jeffrey Stedfast <fejj@ximian.com>
* folder-browser.c (folder_browser_copy): Do the Right Thing (tm)
if the message list is not the widget in focus (which is to copy
the text selected in the html viewer instead). Fixes bug #5868.
svn path=/trunk/; revision=11558
2001-08-01 Jeffrey Stedfast <fejj@ximian.com>
* e-shell-view-menu.c (command_new_folder): Do a NULL-check on
current_uri - socket is being closed? (as per the comments for the
NULL-check in e-shell-view.c:socket_destroy_cb).
svn path=/trunk/; revision=11557
which means that every change you're doing here immediately affects
a very large number of modules.
Please, do *ALWAYS ASK FIRST* on gnome-hackers@gnome.org before you
commit anything to this directory. If unsure, feel free to send me
a patch <martin@gnome.org> and I'll commit it for you it it's ok.
Thanks for your understanding,
August 1st, 2001
Martin Baulig <martin@gnome.org>
svn path=/trunk/; revision=11548
2001-08-01 Christopher James Lahey <clahey@ximian.com>
* e-cell-toggle.c (etog_max_width): Made this not query the 0th
row if there are 0 rows in the table. Fixes Ximian bug #5640.
svn path=/trunk/; revision=11542
2001-08-01 Christopher James Lahey <clahey@ximian.com>
* contact-editor/.cvsignore: Removed this file from this unused
directory.
svn path=/trunk/; revision=11541
2001-08-01 Christopher James Lahey <clahey@ximian.com>
* gui/contact-editor/Makefile.am: Added file-exists.glade.
* gui/contact-editor/e-contact-save-as.c (file_exists),
gui/contact-editor/file-exists.glade: Added a dialog to ask the
user whether to replace an already existing file. Mostly from a
patch by Jos Dehaes. Fixes Ximian bug #2231.
svn path=/trunk/; revision=11540
2001-08-01 Christopher James Lahey <clahey@ximian.com>
* backend/ebook/e-book-view-listener.c
(e_book_view_listener_check_queue): Removed thrash checking code
here since thrashing shouldn't happen now that we've cleaned this
up some.
* backend/ebook/e-book.c (e_book_do_response_get_view): Properly
handle cases where construction fails.
svn path=/trunk/; revision=11539
2001-08-01 Not Zed <NotZed@Ximian.com>
* providers/local/camel-mbox-folder.c (mbox_lock): If we fail to
get the lock, make sure we close our locking fd, and reset it.
Fixes the crash part of 5095.
svn path=/trunk/; revision=11538
2001-08-01 Not Zed <NotZed@Ximian.com>
* providers/imap/camel-imap-folder.c (camel_imap_folder_changed):
Slightly re-arranged filter/change notification logic. If we;re
filtering, freeze the folder till we're finished to smooth the ui
for new mail.
2001-07-31 Not Zed <NotZed@Ximian.com>
* camel-folder.c (camel_folder_init): Chagned mutexes to
e_mutexes, folder lock recursive. This fixes the imap filtering
bug, or at least some cases of it.
(camel_folder_finalize): Free mutexes.
* camel-private.h (CamelFolderPrivate): Changed mutexes to
e_mutexes.
2001-07-25 Not Zed <NotZed@Ximian.com>
* camel-folder.c (camel_folder_change_info_*): Change the
return if fail's into asserts.
(camel_folder_change_info_free): Don't let it accept a NULL
argument. This isn't g_lib so we dont have to.
svn path=/trunk/; revision=11537
2001-07-31 Federico Mena Quintero <federico@ximian.com>
The Wombat now keeps track of which categories are present in the
objects of a calendar. It will notify the clients of changes in
this set. This is to make the category drop-down menus in the
calendar/tasks views be always up to date.
* idl/evolution-calendar.idl (Listener): Added a
notifyCategoriesChanged() method. The Wombat now keeps track of
the categories within a calendar.
* cal-client/cal-listener.[ch]: Switched it to use BonoboXObject.
Also added the notifyCategoriesChanged implementation.
* cal-client/cal-client.[ch]: Added a "categories_changed" signal.
* pcs/cal-backend-file.c: Maintain a list of the live categories.
(update_categories_from_comp): New function to maintain the set of
live categories.
(add_component): Update the set of categories.
(remove_component): Likewise.
(open_cal): Notify about changes in the set of categories.
(create_cal): Likewise.
(cal_backend_file_update_objects): Likewise.
(cal_backend_file_remove_object): Likewise.
(notify_categories_changed): New function to notify the clients
about the current set of categories.
* pcs/cal.c (cal_notify_categories_changed): New function.
svn path=/trunk/; revision=11536
Christian Rose