2003-03-13 Jeffrey Stedfast <fejj@ximian.com>
* camel-folder.c (get_uids): Don't add bogus uids to the uid
array. Might fix bug #38868 (it's the only way I can figure that
camel_folder_get_message_info() could possibly return NULL for the
Outbox folder).
svn path=/trunk/; revision=20280
2003-03-13 Jeffrey Stedfast <fejj@ximian.com>
* gal/util/e-xml-utils.c (e_xml_save_file): Updated to use
xmlDocDumpFormatMemory() so that we get structured xml rather than
just a clump of xml mess.
svn path=/trunk/; revision=20275
* Makefile.am (GNOME_Evolution_Wombat.server.in.in): Make this
depend on Makefile so it gets regenerated if you switch from
--without-openldap to --with-openldap
svn path=/trunk/; revision=20274
2003-03-13 Rodrigo Moya <rodrigo@ximian.com>
* pcs/query-backend.c (query_backend_new): use a weak ref instead
of connecting to backend's "destroy" signal.
(backend_destroyed_cb, query_destroyed_cb): changed to be weak
reference callbacks.
svn path=/trunk/; revision=20271
2003-03-12 Chris Toshok <toshok@ximian.com>
[ fixes bug #20210 ]
* gui/component/select-names/e-select-names-popup.c
(popup_menu_card): change "Edit Contact Info" to "View Contact
Info", as you can't always edit the contact (if the book is read
only).
(popup_menu_list): same, but for a contact list.
svn path=/trunk/; revision=20270
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
Security vulnerability fixes.
* mail-display.c (do_external_viewer): Make sure that we don't
launch a bonobo control to view a mime-type that we handle
internally, otherwise maliciously formed HTML mail using <object>
tags could potentially launch a bonobo vontrol to view the mime
part bypassing any checks that Evolution might do on the data
normally.
svn path=/trunk/; revision=20269
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
Security vulnerability fixes.
* mail-format.c (handle_text_html, attachment_header)
(handle_image, handle_via_bonobo): Encode the result from
get_cid() so that malicious Content-Id strings cannot bypass the
user's preference to not load http images, force a bonobo control
to load passing it arbitrary data, etc.
svn path=/trunk/; revision=20268
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
* mail-signature-editor.c (menu_file_save_cb): Rewritten to do the
same as the composer's build_message() code.
svn path=/trunk/; revision=20266
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
* mail-signature-editor.c: Various small fixes leading up to a real fix.
svn path=/trunk/; revision=20265
* e-summary-shown.c (e_summary_shown_freeze,
e_summary_shown_thaw): New, to free/thaw the ETree models.
(e_summary_shown_add_node): Don't freeze/thaw around the single
add here. That doesn't really help much.
* e-summary-preferences.c (fill_rdf_etable): Freeze/thaw the
ESummaryShown while filling it in.
* e-summary-weather.c (e_summary_weather_fill_etable): Likewise.
svn path=/trunk/; revision=20263
2003-03-12 Rodrigo Moya <rodrigo@ximian.com>
* gui/dialogs/save-comp.[ch] (save_component_dialog): corrected
button ordering and changed the return type to be a GtkResponseType.
* gui/dialogs/comp-editor.c (prompt_to_save_changes): adapted to
changes in save_component_dialog.
svn path=/trunk/; revision=20261
2003-03-11 Chris Toshok <toshok@ximian.com>
[ fixes bug #39507 ]
* gui/component/select-names/e-select-names.c (search_result): new
function, sync the models after we do a search.
(addressbook_model_set_uri): connect to search_result.
svn path=/trunk/; revision=20260
2003-03-11 Chris Toshok <toshok@ximian.com>
* gui/component/select-names/e-select-names.c
(e_select_names_init): fix compiler warnings about deprecated
functions.
(e_select_names_child_free): unref the table model.
(remove_address): re-enable.
(section_right_click_cb): this is an ETable callback now.
(e_select_names_add_section): remove a gross gross awful hack, and
make the recipient tables ETables instead EEntry's. We lose the
nice underlining, but we can add that back in as another ETable
style (like strikeout and bold), and we also fix the longstanding
scrolling problems (like bug #25148) and can finally remove
addresses by double clicking on them (which is also a bug
someplace I think.. dunno the # offhand.)
* gui/component/select-names/e-select-names-table-model.c
(clear_info): always set the count to -1, regardless of what
model->data is.
* gui/component/select-names/e-select-names-model.c: remove some
unused enums.
* gui/component/select-names/Makefile.am (etspec_DATA): add
e-select-names-section.etspec
* gui/component/select-names/e-select-names-section.etspec: new
file, spec for the To:/Cc:/Bcc: etable's in the select-names
dialog.
svn path=/trunk/; revision=20259
2003-03-12 Not Zed <NotZed@Ximian.com>
* camel-object.c (remove_bag): removed, it was double-freeing the
key.
(save_object): Just save the object in an array.
(camel_object_bag_destroy): first save the object bag's objects in
a list, then remove them one at a time from the bag since we can't
remove hash table entries while we're in a foreach (PITA glib
shit). For #39486.
(camel_object_bag_*): killed some warnings.
svn path=/trunk/; revision=20258
* e-shell-startup-wizard.c (start_wizard): If the wizard factory
returns NULL, we'll get a NIL wizard but no exception. Deal with
that case. (ie, try the next wizard).
(finish_func): Simplify for e-timezone-dialog changes.
(prepare_timezone_page): If there is already a timezone set in
gconf, set the map to point to it. (For connector autoconfig.)
svn path=/trunk/; revision=20257
* e-timezone-dialog/e-timezone-dialog.c: Various cleanups.
(e_timezone_dialog_get_timezone): Return an icaltimezone.
(e_timezone_dialog_set_timezone): Take an icaltimezone
(e_timezone_dialog_construct): Set a minimum size on the scrolled
window
svn path=/trunk/; revision=20255
2003-03-10 Rodney Dawes <dobey@ximian.com>
* e-calendar.c: Use GtkArrow instead of pixmaps
* e-combo-button.c: Use GtkArrow instead of pixmaps
* e-filter-bar.c: gtk_window_set_policy () is deprecated
* e-url-entry.c: Load the icon in a pixbuf instead of GdkPixmap
svn path=/trunk/; revision=20254
2003-03-11 Jeffrey Stedfast <fejj@ximian.com>
* mail-accounts.c (account_add_clicked): Use
gtk_window_set_transient_for() on the druid with the settings
dialog as the parent window.
svn path=/trunk/; revision=20253
2003-03-11 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c: Use GnomeIconList instead of
EIconList so we don't have to maintain an exact copy/paste of
GnomeIconList ourselves. I don't udnerstand why we ever did.
* e-icon-list.[c,h]: Removed.
svn path=/trunk/; revision=20251
2003-03-10 Jeffrey Stedfast <fejj@ximian.com>
* mail-accounts.c (account_able_toggled): New callback function to
handle the checkbox getting toggled.
(mail_accounts_treeview_new): Save the toggle renderer so we can
later connect to it's toggled signal.
(mail_accounts_tab_construct): Connect to the toggle-cell's
toggled signal. Fixes bug #39325.
svn path=/trunk/; revision=20245
2003-03-09 Rodrigo Moya <rodrigo@ximian.com>
* gui/alarm-notify/alarm-notify.c (alarm_notify_add_calendar): if we
already have the client loaded, don't remove it, just increment its
reference count.
* gui/alarm-notify/alarm-queue.c (remove_queued_alarm): added new
argument to specify whether we want the component's structure removed
if no more alarms exist, and only free the structure if TRUE.
(remove_alarms): added same new argument and pass it over to
remove_queued_alarm.
(remove_comp, obj_updated_cb): passed new argument to remove_alarms.
(procedure_notification): passed new argument to remove_queued_alarm.
(obj_removed_cb): set all freed pointers to NULL.
(notify_dialog_cb): only remove the alarm if the pointers are not NULL.
svn path=/trunk/; revision=20232
2003-03-11 Not Zed <NotZed@Ximian.com>
* mail-vfolder.c (vfolder_editor_response): Fix the response code,
because some bastard changed the filter/* code and didn't fix the
callers. Partial fix for #39165.
svn path=/trunk/; revision=20231
2003-03-11 Not Zed <NotZed@Ximian.com>
* rule-context.c (revert): go to the proper level of child node
before looking for rule sets, fix for #39165 to make 'cancel' work.
svn path=/trunk/; revision=20230
2003-03-11 Not Zed <NotZed@Ximian.com>
* gui/widgets/e-addressbook-util.c (e_addressbook_send_card_list):
re-enable in build, include e-destination.h. For #39256.
svn path=/trunk/; revision=20229
2003-03-10 Not Zed <NotZed@Ximian.com>
* component-factory.c
(factory): Removed the debug printf. Added a case for the
composer. Part of fixing #39256.
svn path=/trunk/; revision=20228
2003-03-10 Not Zed <NotZed@Ximian.com>
* Makefile.am (libevolution_mail_la_SOURCES): removed main.c from
the build.
* component-factory.c (component_factory_init): Remove, not used
anymore, causes linking problems some places.
(factory): Removed the debug printf.
svn path=/trunk/; revision=20226
2003-03-09 Jeffrey Stedfast <fejj@ximian.com>
* camel-url-scanner.c (camel_url_addrspec_end): Doh! If inptr ==
pos + 1, then return FALSE (before it was checking for inptr ==
pos, but it will never be pos).
svn path=/trunk/; revision=20225
2003-03-07 Chris Toshok <toshok@ximian.com>
* gal/e-text/e-text.c (e_text_draw): fix drawing bugs, and disable
the stupid looking focus rect, since I can't find a theme that
uses them.
(e_text_event): force redraw in the focus-out case if the cursor
is shown (so we can erase it), and also trick ourselves into
drawing it immediately (by setting it to FALSE) in the focus-in
case.
svn path=/trunk/; revision=20223
2003-03-07 Jeffrey Stedfast <fejj@ximian.com>
All this snot just to fix bug #38925 and an attempt to fix bug
#38926 (but it seems no matter what I do, I can't work around the
bonoboness/modality/whatever of the shell's preferences dialog).
* mail-account-gui.c (sig_add_new_signature): Get the toplevel
parent GtkWindow and pass that along to
mail_composer_prefs_new_signature() so that window layering can be
done correctly.
* mail-composer-prefs.c (mail_composer_prefs_new_signature):
Simplify. We don't want to add the signature to the list until
after they have saved.
(sig_edit_cb): Pass FALSE as the is_new argument to
mail_signature_editor().
(sig_event_client): Listen for signatures being added.
(mail_composer_prefs_new_signature): Now takes a GtkWindow arg as
the first arg rather than a MailComposerPrefs arg since we don't
really need it to be a MailComposerPrefs object. We'd rather use
the first arg as the parent GtkWindow so that we can set
transience for the editor window.
* mail-signature-editor.c (mail_signature_editor): Now takes a
'parent' argument (so we can set transient_for()) and a 'is_new'
argument specifying whether the editor is editing a new signature
or not. If it is, when the user saves, it will be added to the
signature list. otherwise it won't.
(sig_name_changed): Only use the mail_config_signature_set_name()
interface if it is *not* a new signature.
(menu_file_save_cb): If is_new, then save the signature to the
config - otherwise do what we did before and set the modifications
to it and emit the CHANGED event.
* mail-config.c (mail_config_signature_new): Renamed from
mail_config_signature_add(). We no longer immediately add the
signature to the list of saved signatures.
(mail_config_signature_add): New function which adds the signature
and emits the SIG_ADDED event.
svn path=/trunk/; revision=20221
* Locations (name): Add some escapes to the newly added locations
so they get split properly.
* e-summary-weather.c (e_summary_weather_init_locations): Fetch
the Locations file from the right path. If you find an invalid
entry in the Locations file, complain with an informative
g_warning() instead of just returning FALSE.
(e_summary_weather_fill_etable): Do the same thing here.
svn path=/trunk/; revision=20220
2003-03-07 Jeffrey Stedfast <fejj@ximian.com>
* mail-display.c (on_url_requested): If the part url is a text
part, use mail_format_data_wrapper_write_to_stream(). This should
fix bug #39204.
* mail-format.c (mail_format_data_wrapper_write_to_stream): Make public.
svn path=/trunk/; revision=20219
