2003-03-17 Jeffrey Stedfast <fejj@ximian.com>
* rule-editor.c (rule_editor_construct): Always add a Cancel
button here, but if !enable_undo - make the response id
GTK_RESPONSE_CANCEL rather than GTK_RESPONSE_REJECT (which does
undo). This mimics the behaviour that was done in the mail/ code
previously. Fixes bug #39809.
svn path=/trunk/; revision=20315
2003-03-17 Pablo Gonzalo del Campo <pablodc@bigfoot.com>
* es.po: Updated Spanish translation by
Francisco Javier Fernandez <serrador@arrakis.es>
svn path=/trunk/; revision=20314
2003-03-17 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-part.c (process_header): Removed unused variable left
over from my previous fix.
* providers/smtp/camel-smtp-transport.c (smtp_send_to): Don't pass
'has_8bit_parts' to smtp_data() anymore.
(smtp_data): No longer takes 'has_8bit_parts' argument. Ignore
whether or not the message has 8bit parts when deciding what the
required encoding type we need to enforce. Fixes bug #39744.
svn path=/trunk/; revision=20312
2003-03-17 Jeffrey Stedfast <fejj@ximian.com>
* mail-display.c (do_external_viewer): Lookup the handler for the
type. If we don't have a registered handler or if the registered
handler is not meant to be handled via a bonobo component, don't
use a bonobo component.
* mail-format.c (mail_lookup_handler): If we register a new
handler that is to be handled by a bonobo component, set
handler->is_bonobo to TRUE.
svn path=/trunk/; revision=20311
* ename/e-address-western.c (e_address_western_parse): When
declaring a line to be part of "extended" because we don't know
what else to call it, keep the preceding "\n" so that the address
still looks the same when we reassemble the pieces later. Fixes
handling of non-US addresses
svn path=/trunk/; revision=20306
2003-03-14 Chris Toshok <toshok@ximian.com>
* tools/evolution-addressbook-export.c (save_cards): use
bonobo_main_quit, and clean this up a bit.
svn path=/trunk/; revision=20305
2003-03-14 Chris Toshok <toshok@ximian.com>
* gal/util/e-util.c (e_write_file): ugh, we need to make sure the
file is opened for writing. or the flags with O_WRONLY.
svn path=/trunk/; revision=20304
2003-03-14 Mike Kestner <mkestner@ximian.com>
* e-tree-table-adapter.c (update_node): save and restore expanded
state so parents don't collapse when children are added to them.
(e_tree_table_adapter_node_is_expanded): guard against null nodes.
svn path=/trunk/; revision=20303
* e-storage.c (e_storage_get_has_subfolders): Add
(e_storage_declare_has_subfolders): Rename from
e_storage_has_subfolders to make it clearer that this is a setter,
not a getter. (Can't call it e_storage_set_has_subfolders because
that sounds like it belongs in e-storage-set.)
* e-corba-storage.c (impl_StorageListener_notifyHasSubfolders):
update for e_storage_declare_has_subfolders name change
(get_folder): Override the default EStorage implementation: if
asked for a folder under a not-yet-expanded folder, attempt to
force the parent(s) to expand so that the child is available.
Fixes part of #30415
svn path=/trunk/; revision=20302
2003-03-14 Rodrigo Moya <rodrigo@ximian.com>
Fixes#39740
* gui/e-meeting-model.c (is_cell_editable): check row number is valid
before using it as index for the GPtrArray.
2003-03-14 Rodrigo Moya <rodrigo@ximian.com>
Fixes#39356
* gui/Makefile.am:
* gui/tasks-migrate.[ch]: removed tasks migration obsolete stuff.
* gui/calendar-component.c (owner_set_cb): don't call tasks_migrate.
svn path=/trunk/; revision=20301
* Evolution-Storage.idl (asyncOpenFolder): add a Bonobo::Listener
to this like the other async interfaces, rather than having a
hacky way to signal failure.
* evolution-storage.c (impl_Storage_asyncOpenFolder): Update to
take a listener and emit it as part of the signal
(evolution_storage_class_init): update OPEN_FOLDER signal
prototype.
* e-shell-marshal.list (NONE:POINTER,STRING): add, for changed
EvolutionStorage open_folder signal
* e-storage.c (e_storage_async_open_folder): add a callback arg
(impl_async_open_folder): call the callback with NOTIMPLEMENTED.
(class_init): remove the CLOSE_FOLDER signal
(e_storage_has_subfolders): Don't emit CLOSE_FOLDER since it
doesn't exist any more, and this function is used for that side
effect any more anyway.
* e-corba-storage.c (async_open_folder): add the callback arg and
create a proper closure.
(async_open_folder_idle): Call the callback in case of error.
Create a listener and pass that to the CORBA call.
(async_open_cb): Listener callback.
* e-storage-set.c (storage_set_view_folder_opened): Pass a
callback to e_storage_async_open_folder.
(async_open_cb): emit CLOSE_FOLDER if the open failed
(storage_close_folder_cb): Remove this since the signal no longer
exists.
svn path=/trunk/; revision=20297
2003-03-13 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-part.c (process_header): Use
header_contentid_decode() as this new function should be safer
than the hack that we had before.
* camel-mime-utils.c (header_contentid_decode): New function to
try and parse a content-id string in such a way as to work around
some of the known bugs in other MIME implementations. Try to be as
"safe" as we can - ie. don't allow for more than 1 @ (since the
mailer uses "@@@%d" as a fake content-id value for parts without
content-ids) and don't allow for invalid content-type chars.
svn path=/trunk/; revision=20295
2003-03-14 Mike Kestner <mkestner@ximian.com>
* gal/util/e-util.c (e_mkdir_hier): use access() like camel
2003-03-14 Mike Kestner <mkestner@ximian.com>
* gal-view-collection.c (gal_view_collection_load): check failure
on e_create_directory call and warn.
* gal-view-instance.c (save_current_view): check for failure and
warn.
svn path=/trunk/; revision=20291
2003-03-14 Pablo Gonzalo del Campo <pablodc@bigfoot.com>
* es.po: Updated Spanish translation by
Francisco Javier Fernandez <serrador@arrakis.es>.
svn path=/trunk/; revision=20286
2003-03-13 Mike Kestner <mkestner@ximian.com>
* e-summary-preferences.c (fill_rdf_etable): pass FALSE for
expand to e_summary_shown_add_node.
* e-summary-shown.c (make_table): ditto, set_expanded_default to FALSE.
(add_node): only call e_tree_node_set_expanded is expanded != default.
* e-summary-weather.c (*_fill_etable): pass FALSE for expand to
e_summary_shown_add_node.
svn path=/trunk/; revision=20284
2003-03-13 Chris Toshok <toshok@ximian.com>
* gui/contact-editor/e-contact-editor.c
(set_entry_changed_signals): use set_entry_changed_signal_email
for the email entry so the email gets saved out.
(set_entry_changed_signal_email): new function, analogous to
set_entry_changed_signal_phone, but for email.
svn path=/trunk/; revision=20282
2003-03-13 Jeffrey Stedfast <fejj@ximian.com>
* camel-folder.c (get_uids): Don't add bogus uids to the uid
array. Might fix bug #38868 (it's the only way I can figure that
camel_folder_get_message_info() could possibly return NULL for the
Outbox folder).
svn path=/trunk/; revision=20280
2003-03-13 Jeffrey Stedfast <fejj@ximian.com>
* gal/util/e-xml-utils.c (e_xml_save_file): Updated to use
xmlDocDumpFormatMemory() so that we get structured xml rather than
just a clump of xml mess.
svn path=/trunk/; revision=20275
* Makefile.am (GNOME_Evolution_Wombat.server.in.in): Make this
depend on Makefile so it gets regenerated if you switch from
--without-openldap to --with-openldap
svn path=/trunk/; revision=20274
2003-03-13 Rodrigo Moya <rodrigo@ximian.com>
* pcs/query-backend.c (query_backend_new): use a weak ref instead
of connecting to backend's "destroy" signal.
(backend_destroyed_cb, query_destroyed_cb): changed to be weak
reference callbacks.
svn path=/trunk/; revision=20271
2003-03-12 Chris Toshok <toshok@ximian.com>
[ fixes bug #20210 ]
* gui/component/select-names/e-select-names-popup.c
(popup_menu_card): change "Edit Contact Info" to "View Contact
Info", as you can't always edit the contact (if the book is read
only).
(popup_menu_list): same, but for a contact list.
svn path=/trunk/; revision=20270
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
Security vulnerability fixes.
* mail-display.c (do_external_viewer): Make sure that we don't
launch a bonobo control to view a mime-type that we handle
internally, otherwise maliciously formed HTML mail using <object>
tags could potentially launch a bonobo vontrol to view the mime
part bypassing any checks that Evolution might do on the data
normally.
svn path=/trunk/; revision=20269
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
Security vulnerability fixes.
* mail-format.c (handle_text_html, attachment_header)
(handle_image, handle_via_bonobo): Encode the result from
get_cid() so that malicious Content-Id strings cannot bypass the
user's preference to not load http images, force a bonobo control
to load passing it arbitrary data, etc.
svn path=/trunk/; revision=20268
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
* mail-signature-editor.c (menu_file_save_cb): Rewritten to do the
same as the composer's build_message() code.
svn path=/trunk/; revision=20266
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
* mail-signature-editor.c: Various small fixes leading up to a real fix.
svn path=/trunk/; revision=20265
* e-summary-shown.c (e_summary_shown_freeze,
e_summary_shown_thaw): New, to free/thaw the ETree models.
(e_summary_shown_add_node): Don't freeze/thaw around the single
add here. That doesn't really help much.
* e-summary-preferences.c (fill_rdf_etable): Freeze/thaw the
ESummaryShown while filling it in.
* e-summary-weather.c (e_summary_weather_fill_etable): Likewise.
svn path=/trunk/; revision=20263
2003-03-12 Rodrigo Moya <rodrigo@ximian.com>
* gui/dialogs/save-comp.[ch] (save_component_dialog): corrected
button ordering and changed the return type to be a GtkResponseType.
* gui/dialogs/comp-editor.c (prompt_to_save_changes): adapted to
changes in save_component_dialog.
svn path=/trunk/; revision=20261
2003-03-11 Chris Toshok <toshok@ximian.com>
[ fixes bug #39507 ]
* gui/component/select-names/e-select-names.c (search_result): new
function, sync the models after we do a search.
(addressbook_model_set_uri): connect to search_result.
svn path=/trunk/; revision=20260
2003-03-11 Chris Toshok <toshok@ximian.com>
* gui/component/select-names/e-select-names.c
(e_select_names_init): fix compiler warnings about deprecated
functions.
(e_select_names_child_free): unref the table model.
(remove_address): re-enable.
(section_right_click_cb): this is an ETable callback now.
(e_select_names_add_section): remove a gross gross awful hack, and
make the recipient tables ETables instead EEntry's. We lose the
nice underlining, but we can add that back in as another ETable
style (like strikeout and bold), and we also fix the longstanding
scrolling problems (like bug #25148) and can finally remove
addresses by double clicking on them (which is also a bug
someplace I think.. dunno the # offhand.)
* gui/component/select-names/e-select-names-table-model.c
(clear_info): always set the count to -1, regardless of what
model->data is.
* gui/component/select-names/e-select-names-model.c: remove some
unused enums.
* gui/component/select-names/Makefile.am (etspec_DATA): add
e-select-names-section.etspec
* gui/component/select-names/e-select-names-section.etspec: new
file, spec for the To:/Cc:/Bcc: etable's in the select-names
dialog.
svn path=/trunk/; revision=20259
2003-03-12 Not Zed <NotZed@Ximian.com>
* camel-object.c (remove_bag): removed, it was double-freeing the
key.
(save_object): Just save the object in an array.
(camel_object_bag_destroy): first save the object bag's objects in
a list, then remove them one at a time from the bag since we can't
remove hash table entries while we're in a foreach (PITA glib
shit). For #39486.
(camel_object_bag_*): killed some warnings.
svn path=/trunk/; revision=20258
* e-shell-startup-wizard.c (start_wizard): If the wizard factory
returns NULL, we'll get a NIL wizard but no exception. Deal with
that case. (ie, try the next wizard).
(finish_func): Simplify for e-timezone-dialog changes.
(prepare_timezone_page): If there is already a timezone set in
gconf, set the map to point to it. (For connector autoconfig.)
svn path=/trunk/; revision=20257