2001-09-28 <NotZed@Ximian.com>
* e-msgport.c (e_msgport_put): Write the pipe notification outside
the lock. This way if the pipe fills up because of too many
outstanding request, the queue isn't deadlocked. This only
happens wiht 4096 outstanding messages, so something is getting
VERY busy! Fixes#11121.
svn path=/trunk/; revision=13218
2001-09-28 Jeffrey Stedfast <fejj@ximian.com>
* camel-vtrash-folder.c (vtrash_move_messages_to): Oops, a
CamelFolder is not a CamelFolderClass.
svn path=/trunk/; revision=13217
2001-09-28 JP Rosevear <jpr@ximian.com>
* cal-client/cal-client.c (cal_client_open_calendar): init the
execption rather than freeing it
svn path=/trunk/; revision=13215
* mail-format.c (get_data_wrapper_text): Deal with
camel_mime_filter_charset_new_convert returning NULL. (Every other
call to it does, and something's wrong with iconv on the Sun right
now so it keeps failing.)
svn path=/trunk/; revision=13214
* camel-tcp-stream-openssl.c (ssl_error_to_errno): Make this take
an SSL * instead of a CamelTcpStreamSSL *, since it can get called
from open_ssl_connection, when the CamelTcpStreamSSL isn't set up
right yet. Fixes a crash on connection failure.
svn path=/trunk/; revision=13213
* de.po: Fix a printf-format bug in the translation of the "On
DATE, PERSON wrote" string, noted on the evolution list.
svn path=/trunk/; revision=13212
* providers/imap/camel-imap-folder.c
(camel_imap_folder_fetch_data): Grab the store's command_lock
before grabbing the folder's cache_lock to prevent deadlock if
another thread is processing an EXPUNGE response.
* providers/imap/camel-imap-folder.c
(imap_expunge_uids_resyncing): Fix a compiler warning that might
point out a real bug...
* providers/imap/camel-imap-folder.c (get_content): and one that
doesn't
svn path=/trunk/; revision=13209
2001-09-27 <NotZed@Ximian.com>
* vfolder-rule.c (xml_decode): Use g_strdup for the uri, not the
xml memory.
* filter-driver.c, filter-message-search.c: Removed, again, how
did they come back???
svn path=/trunk/; revision=13208
2001-09-27 <NotZed@Ximian.com>
* camel-service.c (camel_service_connect): Dont re-register the
connect_op if we got it by calling 'operation_registered', which
returns an already-registered one.
(camel_service_disconnect): Likewise here.
This removes all the re-registered warnings.
svn path=/trunk/; revision=13205
2001-09-27 <NotZed@Ximian.com>
* camel-object.c (camel_object_unref): Fill the finalised data
with nonsense, rather than 0's - more easily detect bad data.
(camel_object_new): Clear instance data when we retrieve it off
the list.
* camel-object.h (_CamelObject): Added an event lock pointer for
uh, locking event stuff. Also change the hooklist hashtable into
a list. Changed all the code to handle it. Result: thread-safe
events, event-hooks, and save memory too, and SHOULD FINALLY FIX
THAT UNREAD COUNT PROBLEM.
svn path=/trunk/; revision=13201
2001-09-27 <NotZed@Ximian.com>
* mail-folder-cache.c (real_note_folder): No such event finalized!
Its finalize.
(mail_note_store): "
Fixed dan's comment a bit, info != NULL for folder_created, info==
NULL for changed.
2001-09-26 <NotZed@Ximian.com>
* mail-local.c (mlf_set_message_flags): Proxy the
set_message_flags call too. Doesn't fix the 'local folder counts
dont update' problem, but its more correct.
svn path=/trunk/; revision=13200
2001-09-27 Jeffrey Stedfast <fejj@ximian.com>
* camel-pgp-mime.c (camel_pgp_mime_part_decrypt): CRLF decode the
stream before parsing it into a MIME part. This fixes bug #10521.
* camel-store.c: Remove the old folder from the vTrash folder.
svn path=/trunk/; revision=13199
2001-09-27 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment.c (e_msg_composer_attachment_new):
Don't set Content-Ids on these parts since they are not contained
within a multipart/related - this fixes bug #10032.
svn path=/trunk/; revision=13195
* configure.in: Remove references to the "compose" program, since
that functionality went into the shell.
(AC_OUTPUT): Sort and remove duplicates.
* cmdline/*: gone
svn path=/trunk/; revision=13193
* mail-offline-handler.c (service_is_relevant): A service needs to
be disconnected if it's remote, not already offline, and either
connected OR connecting.
(storage_go_offline): Don't put non-relevant stores offline. (Eg,
don't force an IMAP store which you hadn't already connected to to
connect and sync.)
(storage_go_online): Likewise, don't "reconnect" stores that
weren't connected before.
* mail-ops.c (set_offline_desc): Fix the message to say
"reconnecting" instead of "disconnecting" when appropriate.
(mail_store_set_offline): If offline is TRUE, call
camel_service_cancel_connect on the store. (We do this here
because we don't want the cancel_connect request to get queued up
behind a hanging connection attempt.)
svn path=/trunk/; revision=13192
* camel-service.c: Change "gboolean connected" to
"CamelServiceConnectionStatus status", which can be disconnected,
connecting, connected, or disconnecting.
(camel_service_init, camel_service_finalize): create/destroy the
connect_op_lock. Refer to service->status rather than
service->connected.
(camel_service_connect): When connecting, note the current
operation (and create a new one if there's none registered) and
mark the connection "connecting" until we succeed or fail.
(camel_service_disconnect): Likewise in reverse.
(camel_service_cancel_connect): New function to cancel a
connection attempt.
(cancel_connect): Default implementation: Call
camel_operation_cancel on the connect_op.
* camel-disco-store.c (disco_connect): Only call
CamelRemoteStore's connect func if we're online.
(disco_cancel_connect): Fall back to offline if a connection gets
cancelled.
(disco_get_folder_info): Kludge: call connect explicitly before
deciding whether to do the online or offline version, so if the
connect fails, we fall back correctly.
* camel-session.c (camel_session_get_service_connected):
s/svc->connected/svc->status/
* camel-remote-store.c (camel_remote_store_finalise):
Change service->connected check to service->status check.
(remote_connect): Don't set service->connected here:
camel_service_connect() itself does that.
* camel-operation.c (camel_operation_registered): Deal with the
possibility that there's no registered op.
svn path=/trunk/; revision=13191
2001-09-27 Rodrigo Moya <rodrigo@ximian.com>
* idl/evolution-calendar.idl: added InvalidURI and UnsupportedMethod
exceptions to the CalFactory interface
* pcs/cal-factory.c (impl_CalFactory_open): raise InvalidURI exception on
URI errors and UnsupportedMethod when we don't support the method for
a given URI
2001-09-26 Rodrigo Moya <rodrigo@ximian.com>
* cal-client/cal-client.c: added support for using multiple calendar
factories
(cal_client_uri_list): use the list of factories loaded for this
CalClient
svn path=/trunk/; revision=13189
2001-09-27 JP Rosevear <jpr@ximian.com>
* conduit/address-conduit.c (local_record_from_ecard): use the old
record (if there was one) so as not to overwrite fields we don't
sync
(pre_sync): store the dbi in the context and don't make it object
data
svn path=/trunk/; revision=13187
2001-09-26 Damon Chaplin <damon@ximian.com>
* gui/e-calendar-table.c (date_compare_cb):
(percent_compare_cb):
(priority_compare_cb): added comparison functions for these special
cell types. But the date and percent ones don't work yet due to the
use of static text buffers for return cell values.
(e_calendar_table_init): added the comparison functions to the
ETableExtras. NOTE: task_compare_cb() never seems to be called.
I'm not sure why it is there.
* gui/e-calendar-table.etspec: set the comparison function names for
the date/percent/priority fields.
* cal-util/cal-util.c (cal_util_priority_to_string):
(cal_util_priority_from_string): new utility functions.
* gui/calendar-model.c (get_priority):
(set_priority): used above utility functions, and removed the warning
dialog which isn't useful now that the field isn't editable.
* gui/dialogs/event-page.c (times_updated): handle timezones and for
all-day events make sure it stays an all-day event after adjusting.
Fixes bugs #5945 and #10222.
* gui/calendar-commands.c (pixmaps): fixed the E_PIXMAP paths - the
edit items were moved beneath 'EditPlaceholder'. This gets rid of
those long Bonobo warnings! (and we get the icons back)
* gui/dialogs/comp-editor.c (pixmaps): removed the PrintPreview toolbar
icon, since it doesn't appear in the xml file. Gets rid of warning.
* gui/dialogs/event-page.c (notify_dates_changed): new function to
emit the notification signal when the dates are changed. It also
handles timezones now.
* gui/dialogs/comp-editor-page.h (CompEditorPageDates): used
CalComponentDateTime for start/end/due so we have the timezone as well
as the time.
* gui/dialogs/comp-editor-util.c (comp_editor_dates): updated to get
the timezones as well as the times.
(comp_editor_free_dates): new function needed to free all the structs.
* gui/dialogs/recurrence-page.c (recurrence_page_set_dates): added call
to preview_recur() to make sure the preview gets updated.
* gui/dialogs/alarm-page.c (alarm_page_fill_widgets): free the
CompEditorPageDates struct after use.
* gui/tag-calendar.c (tag_calendar_by_comp): added 'comp_is_on_server'
argument. If FALSE, we try to use builtin timezones first. This is
needed for the recurrence page of the event editor, because the
timezones may not have been added to the server yet. This and the
changes to the notification stuff should fix bug #5034.
* gui/gnome-cal.c (dn_query_obj_updated_cb): call above
tag_calendar_by_comp() with TRUE since the events will be on the
server in this case.
* gui/e-day-view-layout.c:
* gui/e-day-view.c: made sure an event always takes up at least one
row, even when the start & end times are the same. Fixes bug #5944.
I don't know if we should try to also handle events with the end time
before the start time.
* gui/e-week-view.c (e_week_view_style_set): check that the small font
is actually smaller than the normal font. If it isn't, don't use it.
Hopefully fixes bug #6876.
(e_week_view_on_new_appointment): if only one day is selected, then
we set the initial time of the event to 1/2-hour from the start of the
working day, to differentiate 'New Appointment' from 'New All Day
Event'. Fixes bug #8892.
* gui/e-day-view.c (e_day_view_on_new_appointment): do the same as the
above.
svn path=/trunk/; revision=13186
2001-09-18 Damon Chaplin <damon@ximian.com>
* e-dateedit.c (e_date_edit_grab_focus): grab focus to the date entry
or the time entry, depending on which is visible. Fixes bug #7237.
svn path=/trunk/; revision=13185
2001-09-26 Federico Mena Quintero <federico@ximian.com>
Fixes the GUI part of bug #7892.
* gui/dialogs/alarm-page.c (get_alarm_duration_string): Return
NULL if the duration is zero.
(get_alarm_string): Handle duration of zero. Also, hopefully
make the strings be more l10n-friendly.
* gui/alarm-notify/alarm.c (alarm_ready_cb): I am a moron. Fix
reversed test.
svn path=/trunk/; revision=13182
2001-09-26 Chris Toshok <toshok@ximian.com>
* wombat.c (setup_pas): add OAFIID parameter to the call to the
pas_book_factory_activate function, as with the calendar stuff.
svn path=/trunk/; revision=13181
2001-09-26 Chris Toshok <toshok@ximian.com>
* backend/pas/pas-book-factory.c (pas_book_factory_destroy): use
priv->iid instead of the hardcoded string here.
(pas_book_factory_activate): parameterize the factory's iid, as in
the calendar server, and provide a default if iid == NULL.
* backend/pas/pas-book-factory.h: add iid parameter for
pas_book_factory_activate.
svn path=/trunk/; revision=13180
2001-09-26 Anna Marie Dirks <anna@ximian.com>
* mail-config.glade: Added a "Description:" label and moved
the source_description and transport_description labels to
a more appropriate place.
svn path=/trunk/; revision=13178
2001-09-26 Christopher James Lahey <clahey@ximian.com>
* message-list.c (mlfe_callback): Check for the root node here.
svn path=/trunk/; revision=13177
2001-09-26 Jeffrey Stedfast <fejj@ximian.com>
* mail-mt.c (do_get_pass): Change the wording of the password
dialog if we are getting a pgp passphrase so that users don't
misinterpret it to mean saving the passphrase forever.
svn path=/trunk/; revision=13176
2001-09-26 Jon Trowbridge <trow@ximian.com>
* mail-format.c (write_address): Use camel_address_format,
not camel_address_encode.
svn path=/trunk/; revision=13174
2001-09-26 Jon Trowbridge <trow@ximian.com>
* backend/ebook/e-destination.c (e_destination_get_textrep): Use
camel_address_format, not camel_address_encode.
svn path=/trunk/; revision=13173
2001-09-26 Federico Mena Quintero <federico@ximian.com>
Fix the libical-related part of Ximian bug #7892.
* src/libical/icalduration.c (icaldurationtype_as_ical_string):
The correct string for zero seconds is "PT0S", not "PTS0". Also
handle "negative zero" durations.
* src/libical/icalvalue.c (icalvalue_new_from_string_with_error):
Use icalerrno to see if the duration string is invalid. We cannot
use icaldurationtype_is_null_duration() because a duration of zero
*is* valid, not an error (icalduration_type_from_string() returns
a zero duration on parse error, too).
svn path=/trunk/; revision=13172
