2001-10-24 Christopher James Lahey <clahey@ximian.com>
* gui/widgets/e-addressbook-view.c
(e_addressbook_view_class_init): Removed key_press handler here
since delete and backspace are now handled by keybindings.
svn path=/trunk/; revision=13981
2001-10-23 Jon Trowbridge <trow@ximian.com>
* gui/component/addressbook.c: Fix command paths when we specify
our pixmaps, so we don't get a lot of totally useless & very ugly
bonobo-ui spew.
* backend/ebook/e-book-util.c (e_book_nickname_query): The empty
string as an arg shouldn't generate a warning.
svn path=/trunk/; revision=13973
2001-10-23 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-completion.c: Removed
our cancelled flag and e_select_names_completion_cancel function,
since we were just duplicating stuff that had ended up in
ECompletion.
(match_name): Form our menu_text properly on an additional-name
match.
(e_select_names_completion_got_book_view_cb): Store handles for
our signals, disconnect them properly when we switch book views.
(e_select_names_completion_stop_query): Disconnect signals when we
stop our query.
(check_capabilities): Spew if we are using LDAP for completion.
(e_select_names_completion_destroy): Disconnect our signals when
we destroy.
This all should fix bug #10241.
svn path=/trunk/; revision=13961
2001-10-23 Christopher James Lahey <clahey@ximian.com>
* configure.in: Bumped required GAL to 0.15.99.3 so EEntry's
"draw_button" argument can be used in
addressbook/gui/component/select-names/e-select-names.c.
From addressbook/ChangeLog:
2001-10-23 Christopher James Lahey <clahey@ximian.com>
* gui/component/select-names/e-select-names.c
(e_select_names_add_section): Set "draw_button" argument to TRUE
on this EEntry.
svn path=/trunk/; revision=13935
2001-10-22 Christopher James Lahey <clahey@ximian.com>
* gui/contact-editor/e-contact-save-as.c (save_it): Put up an
error dialog if there's an error while saving. If the person hits
cancel on the "file exists" dialog, don't close the file selection
dialog. Fixes Ximian bug #7055.
svn path=/trunk/; revision=13865
2001-10-21 Christopher James Lahey <clahey@ximian.com>
* gui/widgets/e-addressbook-reflow-adapter.c
(model_and_selection_free): right_click_up here when we let go of
the popup.
* gui/widgets/e-minicard-view.c (e_minicard_view_selection_event):
right_click_up here.
svn path=/trunk/; revision=13843
2001-10-21 Christopher James Lahey <clahey@ximian.com>
* gui/component/select-names/e-select-names.c
(e_select_names_add_section, e_select_names_set_default): Use an
EEntry here instead of a GtkLabel. Fixes Ximian bug #7067.
svn path=/trunk/; revision=13841
2001-10-21 Jon Trowbridge <trow@ximian.com>
* gui/component/addressbook.c (control_activate_cb): Call
e_addressbook_model_force_folder_bar_message when we activate the
component. (Fixes bug #11749)
* gui/widgets/e-addressbook-model.c
(e_addressbook_model_force_folder_bar_message): Added. Forces
emission of a folder_bar_message.
svn path=/trunk/; revision=13840
2001-10-20 Larry Ewing <lewing@ximian.com>
* gui/component/select-names/e-select-names.c
(e_select_names_set_default): stick with the style font if the
efont bold font does not exist.
svn path=/trunk/; revision=13838
2001-10-20 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-completion.c
(name_style_query): Fix memory leak.
* gui/widgets/e-addressbook-view.c (jump_to_letter): Free our
string vector letter_v when we are done with it.
* gui/contact-editor/e-contact-quick-add.c (edit_card): Unref our
QuickAdd structure.
* gui/component/e-address-popup.c (e_address_popup_construct):
Unref our style after we are done with it.
svn path=/trunk/; revision=13835
2001-10-20 Jon Trowbridge <trow@ximian.com>
* backend/ebook/e-book.c (activate_factories_for_uri): We
shouldn't leak the info returned by oaf_query.
* gui/contact-editor/e-contact-quick-add.c (card_added_cb): Remove
superfluous call to quick_add_unref.
(editor_closed_cb): Remove superfluous call to quick_add_unref.
* gui/component/select-names/e-select-names.c (esn_get_key_fn): We
need to unref the card returned by e_addressbook_model_get_card.
svn path=/trunk/; revision=13834
2001-10-20 Jon Trowbridge <trow@ximian.com>
* backend/ebook/e-destination.c (e_destination_importv): Filter
out empty destinations. (also Bug #13036)
* printing/e-contact-print.c (e_contact_build_style): Use
gnome_font_new_closest; if gnome_font_new fails and returns NULL,
our spacing gets all messed up. (Bug #10785)
* gui/widgets/e-addressbook-view.c (e_addressbook_view_can_print):
Allow printing if there are any cards in our view. The selection
has nothing to do with it.
* backend/ebook/e-destination.c (e_destination_is_empty): Check
for strings that contain non-whitespace, rather than just looking
for a non-zero first character. (Bug #13036)
svn path=/trunk/; revision=13826
2001-10-20 Christopher James Lahey <clahey@ximian.com>
* gui/widgets/e-minicard-view.c (e_minicard_view_selection_event):
Handle focus_change in event by selecting that contact. Fixes
Ximian bug #3024.
svn path=/trunk/; revision=13825
2001-10-20 Christopher James Lahey <clahey@ximian.com>
* gui/component/addressbook-component.c (owner_unset_cb):
Repeatedly call gtk_main_quit here as long as there is a main loop
around. This is an ugly hack around Ximian bug #11760.
svn path=/trunk/; revision=13821
2001-10-20 Christopher James Lahey <clahey@ximian.com>
* gui/component/select-names/e-select-names.c: Added #include
<gal/widgets/e-unicode.h>.
* gui/widgets/e-minicard-control.c: Made this display the number
of extra cards in the attachment as well as made it save them all
to the local addressbook if the person selects the button. Fixes
Ximian bug #9507.
svn path=/trunk/; revision=13820
2001-10-20 Christopher James Lahey <clahey@ximian.com>
* gui/widgets/e-minicard.c (e_minicard_event): Changed this to not
grab on a right click. Fixes Ximian bug #12660.
svn path=/trunk/; revision=13818
* e-storage-set-view.c (tree_drag_data_received): Pass the
@folder_type to ::handleDrop.
* evolution-shell-component-dnd.c
(impl_GNOME_Evolution_ShellComponentDnd_DestinationFolder_handleMotion):
New arg @folder_type.
(impl_GNOME_Evolution_ShellComponentDnd_DestinationFolder_handleDrop):
Likewise.
* evolution-shell-component-dnd.h: Add @folder_type to
`DndDestinationFolderHandleDropFn' and
`DndDestinationFolderHandleMotionFn'.
* e-storage-set-view.c (tree_drag_motion): Pass the folder type to
`::handleMotion'.
* Evolution-ShellComponentDnd.idl: Pass @folder_type in
::handleDrop and ::handleMotion.
* component-factory.c (destination_folder_handle_motion): Get
@folder_type here too [to match the changes in the
EvolutionShellComponentDnd interface]. Also, remove a debugging
message.
(destination_folder_handle_drop): Likewise.
* gui/component/addressbook-component.c
(destination_folder_handle_motion): Get @folder_type here too [to
match the changes in the EvolutionShellComponentDnd interface].
Also, remove a debugging message.
(destination_folder_handle_drop): Likewise.
svn path=/trunk/; revision=13807
2001-10-18 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-completion.c
(check_capabilities): Added. Check if our book is local or
networked.
(e_select_names_completion_book_ready): Call check_capabilities.
(e_select_names_completion_new): Call check_capabilities.
(e_select_names_completion_do_query): If we have a networked book,
keep trying if we haven't been able to cache any cards --- our
earlier attempts could have failed due to too many matches. (Bug
#12932)
svn path=/trunk/; revision=13762
2001-10-18 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-manager.c
(focus_out_cb): Lag our cardification on focus-out. This seems to
help with the unintended cardifications that can result from the
weird focus-out/focus-in events that get generated when the popup
disappears.
* backend/ebook/e-card-compare.c: Removed some debug spew.
svn path=/trunk/; revision=13757
2001-10-17 Chris Toshok <toshok@ximian.com>
* gui/component/addressbook-config.c (addressbook_source_dialog):
grab focus in the Account entry when preparing the dialog, fixes
#10406.
svn path=/trunk/; revision=13734
2001-10-17 Chris Toshok <toshok@ximian.com>
* gui/component/select-names/e-select-names.c (new_folder): make
sure to also add "ldap-contacts" folders to the option menu.
svn path=/trunk/; revision=13733
2001-10-17 Christopher James Lahey <clahey@ximian.com>
* backend/ebook/e-card.c (e_card_get_vobject): Did a bit of clean
up here. Might fix some crashes, specifically Ximian bug #10164.
* gui/widgets/e-addressbook-view.c (SPEC): Updated the model
column numbers here. Fixes Ximian bug #12308.
svn path=/trunk/; revision=13721
2001-10-15 Christopher James Lahey <clahey@ximian.com>
* gui/contact-editor/e-contact-save-as.c (e_contact_save_as,
e_contact_list_save_as): Set the default file name here. Fixes
Ximian bug #7053.
svn path=/trunk/; revision=13674
2001-10-12 Jon Trowbridge <trow@ximian.com>
* gui/component/addressbook-factory.c (main): Add a component name
to the e_passwords_init() call.
svn path=/trunk/; revision=13644
2001-10-12 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names.c
(addressbook_model_set_uri): Check to see if the uri we are
setting is the same as the current uri. If so, do nothing.
(Bug #11324)
svn path=/trunk/; revision=13620
2001-10-11 Christopher James Lahey <clahey@ximian.com>
* backend/ebook/e-card-simple.c (e_card_simple_destroy,
fill_in_info, e_card_simple_sync_card, e_card_simple_set_phone,
e_card_simple_set_address, e_card_simple_set_delivery_address,
file_as_get_style, file_as_set_style, e_card_simple_set,
e_card_simple_set_arbitrary),
gui/contact-editor/e-contact-editor-address.c
(e_contact_editor_address_destroy,
e_contact_editor_address_set_arg,
e_contact_editor_address_get_arg),
gui/contact-editor/e-contact-editor-fullname.c
(e_contact_editor_fullname_destroy,
e_contact_editor_fullname_set_arg,
e_contact_editor_fullname_get_arg),
gui/contact-editor/e-contact-editor.c (phone_entry_changed,
address_text_changed, name_entry_changed, full_name_clicked,
full_addr_clicked, fill_in_info): Changed these to use the new ref
and unref functions for ECard auxillary types.
* backend/ebook/e-card-simple.h: Added a comment.
* backend/ebook/e-card-types.h: Added ref_count field to all the
types.
* backend/ebook/e-card.c, backend/ebook/e-card.h: Added ref and
unref functions here for all the ECard auxillary types. Removed
the corresponding free functions. Switched to using these
functions where appropriate.
* gui/component/addressbook-factory.c: #include
<e-util/e-passwords.h>
* gui/component/addressbook.c (load_uri_cb): const correctify.
* gui/component/select-names/e-select-names-manager.c,
gui/component/select-names/e-select-names.c: #include
<addressbook/gui/component/addressbook.h>
* gui/widgets/e-addressbook-model.c (modify_card): Removed an
unnecessary ref here.
svn path=/trunk/; revision=13604
2001-10-11 Jon Trowbridge <trow@ximian.com>
* gui/component/addressbook.c (new_contact_cb): Check that
view->view != NULL.
(save_contact_cb): Check that view->view != NULL.
(search_cb): Check that view->view != NULL.
(delete_contact_cb): Check that view->view != NULL.
(print_cb): Check that view->view != NULL.
(print_preview_cb): Check that view->view != NULL.
(stop_loading_cb): Check that view->view != NULL.
(cut_contacts_cb): Check that view->view != NULL.
(copy_contacts_cb): Check that view->view != NULL.
(paste_contacts_cb): Check that view->view != NULL.
(select_all_contacts_cb): Check that view->view != NULL.
(send_contact_cb): Check that view->view != NULL.
(send_contact_to_cb): Check that view->view != NULL.
(update_command_state): Check that view->view != NULL. Hold a
reference to the AddressbookView for the duration of the function,
in case we exit during bonobo-reentrancy.
(addressbook_view_ref): Added.
(addressbook_view_unref): Added. Simple ref counting for
AddressbookView objects.
(addressbook_view_clear): Zero out an AddressbookView. This is
now separated from the deallocation of the AddressbookView object,
so that we don't leave a dangling pointer if we exit during
bonobo-reentrancy in update_command_state. (Which often seems to
happen if we exit while addressbook operations are going on.)
(destroy_callback): Replace previous call to addressbook_view_free
with addressbook_view_clear/addressbook_view_unref calls.
(addressbook_factory_new_control): Initialize the reference count
in the AddressbookView object.
* gui/widgets/e-addressbook-view.c (e_addressbook_view_destroy):
Carefully zero out our destroyed object.
(command_state_change): Hold a reference to ourselves during the
signal emission.
(get_selected_cards): Ref cards as we add them to the list.
(e_addressbook_view_stop): Check for view != NULL.
(e_addressbook_view_can_create): Check for view != NULL.
(e_addressbook_view_can_print): Check for view != NULL.
(e_addressbook_view_can_save_as): Check for view != NULL.
(e_addressbook_view_can_send): Check for view != NULL.
(e_addressbook_view_can_send_to): Check for view != NULL.
(e_addressbook_view_can_delete): Check for view != NULL.
(e_addressbook_view_can_cut): Check for view != NULL.
(e_addressbook_view_can_copy): Check for view != NULL.
(e_addressbook_view_can_paste): Check for view != NULL.
(e_addressbook_view_can_select_all): Check for view != NULL.
(e_addressbook_view_can_stop): Check for view != NULL.
* gui/widgets/e-addressbook-model.c (addressbook_destroy): Be
careful about zeroing out our destroyed object.
* backend/ebook/e-book-view.c (e_book_view_stop): Added. Stops
event processing in the underlying listener.
svn path=/trunk/; revision=13578
2001-10-10 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-manager.c
(e_select_names_manager_destroy): If our select names dialog is
still around, destroy it. Otherwise, the dialog will hang around
after our composer goes away.
svn path=/trunk/; revision=13565
2001-10-06 Chris Toshok <toshok@ximian.com>
* gui/component/addressbook-config.glade: add an Email Address
field/label/help text.
* gui/component/addressbook-config.c
(addressbook_source_dialog_set_source): fill in the email entry
from the source. also, set the initial state of the email
label/entry.
(auth_checkbutton_changed): set the email label/entry
sensitive/editable if auth is turned on, and
insensitive/uneditable if it's off.
(addressbook_source_dialog_get_source): get the email address from
the email entry.
(addressbook_source_dialog): hook up the email entry to the
changed signal foo, as well as the focus handler for displaying
help text.
svn path=/trunk/; revision=13486
2001-10-06 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-manager.c
(e_select_names_manager_new): db isn't a BonoboObject, so don't
bonobo_object_unref it!
svn path=/trunk/; revision=13477
2001-10-05 Chris Toshok <toshok@ximian.com>
* gui/component/select-names/e-select-names.c
(addressbook_model_set_uri): e_book_load_uri ->
addressbook_load_uri.
* gui/component/select-names/e-select-names-manager.c
(e_select_names_manager_new): e_book_load_uri ->
addressbook_load_uri.
* gui/component/addressbook.c (forget_passwords_cb): new function,
call e_passwords_forget_passwords.
(verbs): Add ContactsForgetPasswords.
(load_uri_auth_cb): new function, call the callback and free up
our closure stuff.
(load_uri_cb): once the uri is loaded, check if we're configured
to authenticate for it, and do so, using the e_passwords stuff.
(addressbook_load_uri): wrapper around e_book_load_uri. save off
the parameters and start the load-with-auth machinery.
(book_open_cb): remove all the auth stuff from here, as it's
handled elsewhere now.
* gui/component/addressbook-factory.c (main): call
e_passwords_init.
* gui/component/addressbook-component.c (user_create_new_item_cb):
e_book_load_uri -> addressbook_load_uri.
(destination_folder_handle_drop): same.
* gui/component/addressbook.h: add prototype for
addressbook_load_uri (a wrapper around e_book_load_uri that also
handles authentication if the user selects it.)
svn path=/trunk/; revision=13475
2001-10-05 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names.c
(real_add_address_cb): Check to make sure our call to
e_addressbook_model_get_card doesn't return NULL.
* gui/widgets/e-addressbook-model.c
(e_addressbook_model_get_card): Chek that we aren't requesting a
negative row.
* gui/contact-list-editor/e-contact-list-editor.c (add_email_cb):
Move to the bottom of the scrolled window, so we can see the
address we just added.
(table_drag_data_received_cb): Move to the bottom of the scrolled
window, so we can see the contact we just dropped.
* gui/component/addressbook.c (addressbook_factory_new_control):
We don't own the string returned by e_categories_master_list_nth,
so terrible things will happen if we free it. (Bug 10916)
svn path=/trunk/; revision=13469
2001-10-05 Chris Toshok <toshok@ximian.com>
* gui/widgets/e-addressbook-view.c (e_addressbook_view_set_arg):
don't set the editable field on the model - let the book do that.
(book_writable_cb): call writable_status to propagate a ui-change
event up (and sensitize the write-only toolbar buttons after you
authenticate with ldap.)
svn path=/trunk/; revision=13454
2001-10-03 Christopher James Lahey <clahey@ximian.com>
* gui/widgets/e-addressbook-reflow-adapter.c (addressbook_height),
gui/widgets/e-minicard.c (remodel): Fixed these to determine the
fields to use properly.
svn path=/trunk/; revision=13386
2001-10-02 Jon Trowbridge <trow@gnu.org>
* gui/component/select-names/e-select-names-completion.c
(name_style_query): Strip out commas before forming our query.
(match_name): Use e_card_compare_name_to_string_full, rather
than our crufty old matching code. Not only is this cleaner,
but that crufty old code was very broken when it came to
handling strings with whitespace. (Bug 8988)
(match_nickname): utf8 and bug fixes.
* backend/ebook/e-card-compare.c
(e_card_compare_name_to_string_full): Added. This is basically
e_card_compare_name_to_string with a bunch of extra options, so
that it can more readily be reused in other contexts.
(e_card_compare_name_to_string): This is now just a call to
e_card_compare_name_to_string_full with the extra args filled in
to defaults that simulate the old behavior.
svn path=/trunk/; revision=13384
2001-10-02 Christopher James Lahey <clahey@ximian.com>
* gui/component/select-names/e-select-names-model.c
(e_select_names_model_get_textification): Made the max length of
the textification be 2047 characters. Fixes Ximian bug #3021.
svn path=/trunk/; revision=13299
2001-09-26 Anna Marie Dirks <anna@ximian.com>
* gui/contact-editor/contact-editor.glade: Added help text (thanks
to Aaron) and re-worded the labels, and fixed the shortcuts on the
brand-spanking-new Collaboration tab.
svn path=/trunk/; revision=13170
2001-09-26 Chris Toshok <toshok@ximian.com>
* gui/component/select-names/e-select-names-manager.h: add
completion_book.
* gui/component/select-names/e-select-names-manager.c
(e_select_names_manager_new): get /Addressbook/Completion/uri, and
if it's present, use the corresponding EBook for completing
addresses.
(focus_out_cb): use manager->completion_book here instead of NULL,
which corresponds to the local addressbook.
(completion_popup_cb): same.
(e_select_names_manager_create_entry): same.
svn path=/trunk/; revision=13161
2001-09-26 Jon Trowbridge <trow@ximian.com>
* backend/ebook/e-card-compare.c (e_card_compare_name_to_string):
Properly handle names when the individual elements (given,
addition, family) contain whitespace. (Bug #10502)
* backend/ebook/e-destination.c (e_destination_set_name): Reset
textrep when we change the name.
(e_destination_set_email): Reset textrep when we change the email.
(e_destination_get_textrep): Make sure that the textrep version of
the address is properly quoted if it contains unsafe characters.
(All related to bug #10796)
* gui/component/select-names/e-select-names-completion.c
(match_nickname): Fix nickname matching. (bug #9698)
(make_match): Use e_completion_match_new when building our match,
rather than ad hoc manipulation of the struct.
svn path=/trunk/; revision=13158
