callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

We shouldn't leak the info returned by oaf_query.

Browse Source 
2001-10-20  Jon Trowbridge  <trow@ximian.com>

	* backend/ebook/e-book.c (activate_factories_for_uri): We
	shouldn't leak the info returned by oaf_query.

	* gui/contact-editor/e-contact-quick-add.c (card_added_cb): Remove
	superfluous call to quick_add_unref.
	(editor_closed_cb): Remove superfluous call to quick_add_unref.

	* gui/component/select-names/e-select-names.c (esn_get_key_fn): We
	need to unref the card returned by e_addressbook_model_get_card.

svn path=/trunk/; revision=13834
This commit is contained in:
Jon Trowbridge
2001-10-21 00:19:25 +00:00
committed by Jon Trowbridge
parent 259a514b63
commit 17a415bd21
4 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
addressbook/ChangeLog
View File

@ -1,3 +1,15 @@
2001-10-20 Jon Trowbridge <trow@ximian.com>
* backend/ebook/e-book.c (activate_factories_for_uri): We
shouldn't leak the info returned by oaf_query.
* gui/contact-editor/e-contact-quick-add.c (card_added_cb): Remove
superfluous call to quick_add_unref.
(editor_closed_cb): Remove superfluous call to quick_add_unref.
* gui/component/select-names/e-select-names.c (esn_get_key_fn): We
need to unref the card returned by e_addressbook_model_get_card.
2001-10-20 Ettore Perazzoli <ettore@ximian.com>
* gui/component/addressbook-component.c: Make LDAP servers

2
addressbook/backend/ebook/e-book.c
View File

@ -662,6 +662,8 @@ activate_factories_for_uri (EBook *book, const char *uri)
factory);
}
CORBA_free (info_list);
if (!book->priv->book_factories) {
g_warning ("Couldn't activate any book factories.");
return FALSE;

1
addressbook/gui/component/select-names/e-select-names.c
View File

@ -247,6 +247,7 @@ esn_get_key_fn (ETableModel *source, int row, void *closure)
EAddressbookModel *model = E_ADDRESSBOOK_MODEL (closure);
ECard *card = e_addressbook_model_get_card (model, row);
void *key = card_key (card);
gtk_object_unref (GTK_OBJECT (card));
return key;
}

4
addressbook/gui/contact-editor/e-contact-quick-add.c
View File

@ -165,7 +165,7 @@ card_added_cb (EContactEditor *ce, EBookStatus status, ECard *card, gpointer clo
if (qa->cb)
qa->cb (qa->card, qa->closure);
quick_add_unref (qa);
/* We don't need to unref qa because we set_data_full below */
gtk_object_set_data (GTK_OBJECT (ce), "quick_add", NULL);
}
}
@ -176,7 +176,7 @@ editor_closed_cb (GtkWidget *w, gpointer closure)
QuickAdd *qa = (QuickAdd *) gtk_object_get_data (GTK_OBJECT (w), "quick_add");
if (qa) {
quick_add_unref (qa);
/* We don't need to unref qa because we set_data_full below */
gtk_object_set_data (GTK_OBJECT (w), "quick_add", NULL);
gtk_object_unref (GTK_OBJECT (w));
}