2001-10-24 Christopher James Lahey <clahey@ximian.com>
* gui/widgets/e-addressbook-view.c
(e_addressbook_view_class_init): Removed key_press handler here
since delete and backspace are now handled by keybindings.
svn path=/trunk/; revision=13981
2001-10-23 Jon Trowbridge <trow@ximian.com>
* gui/component/addressbook.c: Fix command paths when we specify
our pixmaps, so we don't get a lot of totally useless & very ugly
bonobo-ui spew.
* backend/ebook/e-book-util.c (e_book_nickname_query): The empty
string as an arg shouldn't generate a warning.
svn path=/trunk/; revision=13973
2001-10-23 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-completion.c: Removed
our cancelled flag and e_select_names_completion_cancel function,
since we were just duplicating stuff that had ended up in
ECompletion.
(match_name): Form our menu_text properly on an additional-name
match.
(e_select_names_completion_got_book_view_cb): Store handles for
our signals, disconnect them properly when we switch book views.
(e_select_names_completion_stop_query): Disconnect signals when we
stop our query.
(check_capabilities): Spew if we are using LDAP for completion.
(e_select_names_completion_destroy): Disconnect our signals when
we destroy.
This all should fix bug #10241.
svn path=/trunk/; revision=13961
2001-10-23 Christopher James Lahey <clahey@ximian.com>
* configure.in: Bumped required GAL to 0.15.99.3 so EEntry's
"draw_button" argument can be used in
addressbook/gui/component/select-names/e-select-names.c.
From addressbook/ChangeLog:
2001-10-23 Christopher James Lahey <clahey@ximian.com>
* gui/component/select-names/e-select-names.c
(e_select_names_add_section): Set "draw_button" argument to TRUE
on this EEntry.
svn path=/trunk/; revision=13935
2001-10-22 Christopher James Lahey <clahey@ximian.com>
* gui/contact-editor/e-contact-save-as.c (save_it): Put up an
error dialog if there's an error while saving. If the person hits
cancel on the "file exists" dialog, don't close the file selection
dialog. Fixes Ximian bug #7055.
svn path=/trunk/; revision=13865
2001-10-21 Christopher James Lahey <clahey@ximian.com>
* gui/widgets/e-addressbook-reflow-adapter.c
(model_and_selection_free): right_click_up here when we let go of
the popup.
* gui/widgets/e-minicard-view.c (e_minicard_view_selection_event):
right_click_up here.
svn path=/trunk/; revision=13843
2001-10-21 Christopher James Lahey <clahey@ximian.com>
* gui/component/select-names/e-select-names.c
(e_select_names_add_section, e_select_names_set_default): Use an
EEntry here instead of a GtkLabel. Fixes Ximian bug #7067.
svn path=/trunk/; revision=13841
2001-10-21 Jon Trowbridge <trow@ximian.com>
* gui/component/addressbook.c (control_activate_cb): Call
e_addressbook_model_force_folder_bar_message when we activate the
component. (Fixes bug #11749)
* gui/widgets/e-addressbook-model.c
(e_addressbook_model_force_folder_bar_message): Added. Forces
emission of a folder_bar_message.
svn path=/trunk/; revision=13840
2001-10-20 Larry Ewing <lewing@ximian.com>
* gui/component/select-names/e-select-names.c
(e_select_names_set_default): stick with the style font if the
efont bold font does not exist.
svn path=/trunk/; revision=13838
2001-10-20 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-completion.c
(name_style_query): Fix memory leak.
* gui/widgets/e-addressbook-view.c (jump_to_letter): Free our
string vector letter_v when we are done with it.
* gui/contact-editor/e-contact-quick-add.c (edit_card): Unref our
QuickAdd structure.
* gui/component/e-address-popup.c (e_address_popup_construct):
Unref our style after we are done with it.
svn path=/trunk/; revision=13835
2001-10-20 Jon Trowbridge <trow@ximian.com>
* backend/ebook/e-book.c (activate_factories_for_uri): We
shouldn't leak the info returned by oaf_query.
* gui/contact-editor/e-contact-quick-add.c (card_added_cb): Remove
superfluous call to quick_add_unref.
(editor_closed_cb): Remove superfluous call to quick_add_unref.
* gui/component/select-names/e-select-names.c (esn_get_key_fn): We
need to unref the card returned by e_addressbook_model_get_card.
svn path=/trunk/; revision=13834
2001-10-20 Jon Trowbridge <trow@ximian.com>
* printing/e-contact-print.c (e_contact_print_card): Check that the
string we are checking for xml-ness is non-NULL.
svn path=/trunk/; revision=13830
2001-10-20 Jon Trowbridge <trow@ximian.com>
* backend/ebook/e-destination.c (e_destination_importv): Filter
out empty destinations. (also Bug #13036)
* printing/e-contact-print.c (e_contact_build_style): Use
gnome_font_new_closest; if gnome_font_new fails and returns NULL,
our spacing gets all messed up. (Bug #10785)
* gui/widgets/e-addressbook-view.c (e_addressbook_view_can_print):
Allow printing if there are any cards in our view. The selection
has nothing to do with it.
* backend/ebook/e-destination.c (e_destination_is_empty): Check
for strings that contain non-whitespace, rather than just looking
for a non-zero first character. (Bug #13036)
svn path=/trunk/; revision=13826
2001-10-20 Christopher James Lahey <clahey@ximian.com>
* gui/widgets/e-minicard-view.c (e_minicard_view_selection_event):
Handle focus_change in event by selecting that contact. Fixes
Ximian bug #3024.
svn path=/trunk/; revision=13825
2001-10-20 Christopher James Lahey <clahey@ximian.com>
* gui/component/addressbook-component.c (owner_unset_cb):
Repeatedly call gtk_main_quit here as long as there is a main loop
around. This is an ugly hack around Ximian bug #11760.
svn path=/trunk/; revision=13821
2001-10-20 Christopher James Lahey <clahey@ximian.com>
* gui/component/select-names/e-select-names.c: Added #include
<gal/widgets/e-unicode.h>.
* gui/widgets/e-minicard-control.c: Made this display the number
of extra cards in the attachment as well as made it save them all
to the local addressbook if the person selects the button. Fixes
Ximian bug #9507.
svn path=/trunk/; revision=13820
2001-10-20 Christopher James Lahey <clahey@ximian.com>
* gui/widgets/e-minicard.c (e_minicard_event): Changed this to not
grab on a right click. Fixes Ximian bug #12660.
svn path=/trunk/; revision=13818
* e-storage-set-view.c (tree_drag_data_received): Pass the
@folder_type to ::handleDrop.
* evolution-shell-component-dnd.c
(impl_GNOME_Evolution_ShellComponentDnd_DestinationFolder_handleMotion):
New arg @folder_type.
(impl_GNOME_Evolution_ShellComponentDnd_DestinationFolder_handleDrop):
Likewise.
* evolution-shell-component-dnd.h: Add @folder_type to
`DndDestinationFolderHandleDropFn' and
`DndDestinationFolderHandleMotionFn'.
* e-storage-set-view.c (tree_drag_motion): Pass the folder type to
`::handleMotion'.
* Evolution-ShellComponentDnd.idl: Pass @folder_type in
::handleDrop and ::handleMotion.
* component-factory.c (destination_folder_handle_motion): Get
@folder_type here too [to match the changes in the
EvolutionShellComponentDnd interface]. Also, remove a debugging
message.
(destination_folder_handle_drop): Likewise.
* gui/component/addressbook-component.c
(destination_folder_handle_motion): Get @folder_type here too [to
match the changes in the EvolutionShellComponentDnd interface].
Also, remove a debugging message.
(destination_folder_handle_drop): Likewise.
svn path=/trunk/; revision=13807
2001-10-18 Christopher James Lahey <clahey@ximian.com>
* backend/ebook/e-card.c, backend/ebook/e-card.h
(e_card_list_get_vcard): Made this take a const GList.
svn path=/trunk/; revision=13773
2001-10-18 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-completion.c
(check_capabilities): Added. Check if our book is local or
networked.
(e_select_names_completion_book_ready): Call check_capabilities.
(e_select_names_completion_new): Call check_capabilities.
(e_select_names_completion_do_query): If we have a networked book,
keep trying if we haven't been able to cache any cards --- our
earlier attempts could have failed due to too many matches. (Bug
#12932)
svn path=/trunk/; revision=13762
2001-10-18 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-manager.c
(focus_out_cb): Lag our cardification on focus-out. This seems to
help with the unintended cardifications that can result from the
weird focus-out/focus-in events that get generated when the popup
disappears.
* backend/ebook/e-card-compare.c: Removed some debug spew.
svn path=/trunk/; revision=13757
2001-10-17 Chris Toshok <toshok@ximian.com>
* gui/component/addressbook-config.c (addressbook_source_dialog):
grab focus in the Account entry when preparing the dialog, fixes
#10406.
svn path=/trunk/; revision=13734
2001-10-17 Chris Toshok <toshok@ximian.com>
* gui/component/select-names/e-select-names.c (new_folder): make
sure to also add "ldap-contacts" folders to the option menu.
svn path=/trunk/; revision=13733
2001-10-17 JP Rosevear <jpr@ximian.com>
* conduit/address-conduit.c (ecard_from_remote_record): sync all
the fields we can, with out overwriting
(local_record_from_ecard): write the fields to the pilot in
priority order unless there are fields on the pilot we can't
store, then fill in the fields as they are on the pilot
svn path=/trunk/; revision=13728
2001-10-17 Christopher James Lahey <clahey@ximian.com>
* backend/ebook/e-card.c (e_card_get_vobject): Did a bit of clean
up here. Might fix some crashes, specifically Ximian bug #10164.
* gui/widgets/e-addressbook-view.c (SPEC): Updated the model
column numbers here. Fixes Ximian bug #12308.
svn path=/trunk/; revision=13721
2001-10-17 Chris Toshok <toshok@ximian.com>
* backend/pas/pas-backend-file.c (pas_backend_file_upgrade_db):
add upgrade from 0.1 to 0.2, where we make sure id dbt's match
vcard id's, fixes longstanding bug (#7406) where cards were not
modifiable or removable after having been created during a 1-2
week long window in early betas.
(PAS_BACKEND_FILE_VERSION): change to 0.2
(PAS_ID_PREFIX): #define this here.
(pas_backend_file_create_unique_id): use PAS_ID_PREFIX instead of
the string.
svn path=/trunk/; revision=13720
2001-10-16 Jon Trowbridge <trow@ximian.com>
* backend/ebook/e-card.c (e_card_get_id): If card->id is NULL,
return an empty string.
(e_card_set_id): Don't allow the card id to be set to NULL; use
the empty string instead.
(e_card_get_vobject): When building our vcard, pass in the empty
string as the id if card->id is NULL. (Bug #10164)
svn path=/trunk/; revision=13705
2001-10-16 JP Rosevear <jpr@ximian.com>
* conduit/address-conduit.c (local_record_from_ecard): don't set
the phone info if it is blank
(ecard_from_remote_record): save up to 3 fax numbers
svn path=/trunk/; revision=13694
2001-10-15 Chris Toshok <toshok@ximian.com>
* backend/pas/pas-backend-ldap.c (pas_backend_ldap_add_client):
unref the book after we pass it off to evolution-addressbook.
svn path=/trunk/; revision=13691
2001-10-15 Chris Toshok <toshok@ximian.com>
* backend/pas/pas-backend-ldap.c
(pas_backend_ldap_process_get_book_view): make sure to unref the
book_view here so we don't leak them.
svn path=/trunk/; revision=13680
2001-10-15 Christopher James Lahey <clahey@ximian.com>
* backend/ebook/e-card.c (addPropValueQP, addPropValueSets,
e_card_get_vobject): Properly decide whether a property needs to
be marked as QP by searching for '\n'. Fixes Ximian bug #3021.
svn path=/trunk/; revision=13675
2001-10-15 Christopher James Lahey <clahey@ximian.com>
* gui/contact-editor/e-contact-save-as.c (e_contact_save_as,
e_contact_list_save_as): Set the default file name here. Fixes
Ximian bug #7053.
svn path=/trunk/; revision=13674
2001-10-12 Jon Trowbridge <trow@ximian.com>
* gui/component/addressbook-factory.c (main): Add a component name
to the e_passwords_init() call.
svn path=/trunk/; revision=13644
2001-10-12 Christopher James Lahey <clahey@ximian.com>
* backend/ebook/e-card-simple.c, backend/ebook/e-card-simple.h:
Added a boolean type here.
svn path=/trunk/; revision=13624
2001-10-12 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names.c
(addressbook_model_set_uri): Check to see if the uri we are
setting is the same as the current uri. If so, do nothing.
(Bug #11324)
svn path=/trunk/; revision=13620
2001-10-11 Jon Trowbridge <trow@ximian.com>
* backend/ebook/e-destination.c
(e_destination_reverting_is_a_good_idea): Added. Heuristic for
whether or not we want to revert to an earlier cardified state.
(e_destination_cardify): Don't be quite as aggressive about
reverting to previous cardified states. (Bug #11890)
svn path=/trunk/; revision=13610
2001-10-11 Christopher James Lahey <clahey@ximian.com>
* backend/ebook/e-card-simple.c (e_card_simple_destroy,
fill_in_info, e_card_simple_sync_card, e_card_simple_set_phone,
e_card_simple_set_address, e_card_simple_set_delivery_address,
file_as_get_style, file_as_set_style, e_card_simple_set,
e_card_simple_set_arbitrary),
gui/contact-editor/e-contact-editor-address.c
(e_contact_editor_address_destroy,
e_contact_editor_address_set_arg,
e_contact_editor_address_get_arg),
gui/contact-editor/e-contact-editor-fullname.c
(e_contact_editor_fullname_destroy,
e_contact_editor_fullname_set_arg,
e_contact_editor_fullname_get_arg),
gui/contact-editor/e-contact-editor.c (phone_entry_changed,
address_text_changed, name_entry_changed, full_name_clicked,
full_addr_clicked, fill_in_info): Changed these to use the new ref
and unref functions for ECard auxillary types.
* backend/ebook/e-card-simple.h: Added a comment.
* backend/ebook/e-card-types.h: Added ref_count field to all the
types.
* backend/ebook/e-card.c, backend/ebook/e-card.h: Added ref and
unref functions here for all the ECard auxillary types. Removed
the corresponding free functions. Switched to using these
functions where appropriate.
* gui/component/addressbook-factory.c: #include
<e-util/e-passwords.h>
* gui/component/addressbook.c (load_uri_cb): const correctify.
* gui/component/select-names/e-select-names-manager.c,
gui/component/select-names/e-select-names.c: #include
<addressbook/gui/component/addressbook.h>
* gui/widgets/e-addressbook-model.c (modify_card): Removed an
unnecessary ref here.
svn path=/trunk/; revision=13604
2001-10-11 Jon Trowbridge <trow@ximian.com>
* gui/component/addressbook.c (new_contact_cb): Check that
view->view != NULL.
(save_contact_cb): Check that view->view != NULL.
(search_cb): Check that view->view != NULL.
(delete_contact_cb): Check that view->view != NULL.
(print_cb): Check that view->view != NULL.
(print_preview_cb): Check that view->view != NULL.
(stop_loading_cb): Check that view->view != NULL.
(cut_contacts_cb): Check that view->view != NULL.
(copy_contacts_cb): Check that view->view != NULL.
(paste_contacts_cb): Check that view->view != NULL.
(select_all_contacts_cb): Check that view->view != NULL.
(send_contact_cb): Check that view->view != NULL.
(send_contact_to_cb): Check that view->view != NULL.
(update_command_state): Check that view->view != NULL. Hold a
reference to the AddressbookView for the duration of the function,
in case we exit during bonobo-reentrancy.
(addressbook_view_ref): Added.
(addressbook_view_unref): Added. Simple ref counting for
AddressbookView objects.
(addressbook_view_clear): Zero out an AddressbookView. This is
now separated from the deallocation of the AddressbookView object,
so that we don't leave a dangling pointer if we exit during
bonobo-reentrancy in update_command_state. (Which often seems to
happen if we exit while addressbook operations are going on.)
(destroy_callback): Replace previous call to addressbook_view_free
with addressbook_view_clear/addressbook_view_unref calls.
(addressbook_factory_new_control): Initialize the reference count
in the AddressbookView object.
* gui/widgets/e-addressbook-view.c (e_addressbook_view_destroy):
Carefully zero out our destroyed object.
(command_state_change): Hold a reference to ourselves during the
signal emission.
(get_selected_cards): Ref cards as we add them to the list.
(e_addressbook_view_stop): Check for view != NULL.
(e_addressbook_view_can_create): Check for view != NULL.
(e_addressbook_view_can_print): Check for view != NULL.
(e_addressbook_view_can_save_as): Check for view != NULL.
(e_addressbook_view_can_send): Check for view != NULL.
(e_addressbook_view_can_send_to): Check for view != NULL.
(e_addressbook_view_can_delete): Check for view != NULL.
(e_addressbook_view_can_cut): Check for view != NULL.
(e_addressbook_view_can_copy): Check for view != NULL.
(e_addressbook_view_can_paste): Check for view != NULL.
(e_addressbook_view_can_select_all): Check for view != NULL.
(e_addressbook_view_can_stop): Check for view != NULL.
* gui/widgets/e-addressbook-model.c (addressbook_destroy): Be
careful about zeroing out our destroyed object.
* backend/ebook/e-book-view.c (e_book_view_stop): Added. Stops
event processing in the underlying listener.
svn path=/trunk/; revision=13578
2001-10-10 Jon Trowbridge <trow@ximian.com>
* gui/component/select-names/e-select-names-manager.c
(e_select_names_manager_destroy): If our select names dialog is
still around, destroy it. Otherwise, the dialog will hang around
after our composer goes away.
svn path=/trunk/; revision=13565
