2002-04-11 Christopher James Lahey <clahey@ximian.com>
* gui/component/addressbook-component.c: Include
addressbook-config.h here as this file uses it.
* gui/component/select-names/e-select-names.c (SPEC, SPEC2): Made
this dialog searchable by typing in the ETable.
* gui/widgets/e-addressbook-model.c: Include e-addressbook-util.h
here.
* gui/widgets/e-addressbook-reflow-adapter.c
(e_addressbook_reflow_adapter_right_click),
gui/widgets/e-addressbook-view.c (table_right_click): Fixed a
memory leak here by using "selection-done" signal.
* gui/widgets/e-addressbook-reflow-adapter.c,
gui/widgets/e-addressbook-reflow-adapter.h,
gui/widgets/e-addressbook-view.c, gui/widgets/e-minicard-view.c:
Added a right click menu for areas that aren't cards.
svn path=/trunk/; revision=16440
2002-04-11 Christopher James Lahey <clahey@ximian.com>
* e-table-header-item.c (ethi_header_context_menu): Fixed a memory
leak here by using the "selection-done" signal.
* e-table.c, e-table.h (white_item_event): Added the
"white_space_event" signal.
svn path=/trunk/; revision=16439
2002-04-11 Not Zed <NotZed@Ximian.com>
* providers/local/camel-spool-summary.c (spool_summary_sync_full):
If the last message(s) were deleted, and we had any messages
output, account for the lost \n of the following From line by
adding an extra \n. fix for #8214.
2002-04-10 Not Zed <NotZed@Ximian.com>
* camel-mime-part-utils.c (convert_buffer): If we get a 0 length
input, return a 0 lenght output as valid - fixes bugs with some
iconv impl and its simpler anyway.
svn path=/trunk/; revision=16438
2002-04-11 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-folder.c: Set the UID_SET_LIMIT value
to 4096. I ran into an issue tonight where apparently the IMAP
server changed the UIDVALIDITY and so Evo needed to re-fetch all
headers and it was trying to send a uid set of some 25k (yes, I
have a very large INBOX). Anyways, it was set to unlimited
before. Courier IMAPd can safely handle up to ~16k per token, but
UW IMAPd can only handle 8k per command-line, so I set it to 4k
just to be safe.
svn path=/trunk/; revision=16436
2002-04-10 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (confirm_expunge): Set the 'No' button as the
default.
svn path=/trunk/; revision=16435
* mail-config.c (config_read, mail_config_write,
mail_config_get_x_mailer_display_style,
mail_config_set_x_mailer_display_style): Handle the X-Mailer
display style. (There is currently no GUI for configuring this.)
* mail-format.c (write_headers, write_xmailer_header): Show
X-Mailer/User-Agent (and Rupert's stamp of approval) as
appropriate.
svn path=/trunk/; revision=16430
2002-04-10 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-part-utils.c (convert_buffer): Fixed a bug that would
miscalculate how much data to copy into the GByteArray (negative
value) thus causing a segfault. Also optimized it while I was at
it.
svn path=/trunk/; revision=16428
2002-04-10 Rodrigo Moya <rodrigo@ximian.com>
* gui/gnome-cal.c (gnome_calendar_open): use the default uri for
tasks (as stored in the configuration) when the calendar URI is not
a local one (connector, etc).
svn path=/trunk/; revision=16427
2002-04-08 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer.c (set_editor_text): No need to query for the
persist-stream interface here, just re-use
composer->persist_stream_interface - this might improve the speed
at which a reply action brings up the composer.
svn path=/trunk/; revision=16425
* gal/util/e-xml-utils.c: #include <parser.h> and <xmlmemory.h>
instead of <gnome-xml/parser.h> and <gnome-xml/xmlmemory.h>. In
fact, the latter is incompatible with what `gnome-config --cflags
xml' is assuming, and breaks in the case where gnome-xml is not
installed in /usr/local.
svn path=/trunk/; revision=16424
* e-shell-config.c: Shell config page routines. Right now
handles the default folders page.
* glade/e-shell-config-default-folders.glade: New.
* GNOME_Evolution_Shell.oaf.in: Add info for the default folders
config page.
* main.c (idle_cb): If we successfully registered the shell,
register the config factory.
* evolution-shell-client.c (evolution_shell_client_new): Note the
fact that it frees the corba_shell when it is destroyed.
* evolution-folder-selector-button.c
(evolution_folder_selector_button_construct, destroy): Use
bonobo_object_ref/unref on the shell client, not gtk.
* e-shell.c (e_shell_construct): Pass local_directory to
e_setup_check_db.
(handle_default_uri): Fix the config db paths here to match the
other routines.
* e-setup.c (e_setup_check_db): Make this take the evolution
directory path as well so we can properly set up file: URIs for
the default folders.
svn path=/trunk/; revision=16423
* Makefile.am (images_DATA), folder-settings.png: Add. (Copied
from Unscalable Gorilla because it was handy. Will probably get
changed to something else...)
svn path=/trunk/; revision=16422
* cal-client/cal-client.c (get_default_uri): Use new-and-improved
default folder URI config paths.
* gui/calendar-config.c (calendar_config_{get,set}_default_uri,
calendar_config_{get,set}_default_tasks_uri): Remove these. The
shell owns this information now. (Weren't being used anyway.)
* gui/component-factory.c (get_data_uri): Fix another place that
hardcoded tacking foo.ics on to the end of URLs.
svn path=/trunk/; revision=16421
2002-04-10 Not Zed <NotZed@Ximian.com>
* filter-input.c (validate): Check that there is a value to
setup. Fixes#15470.
svn path=/trunk/; revision=16420
2002-04-09 Jeffrey Stedfast <fejj@ximian.com>
* camel-store.c (camel_store_init): Make the folder_lock
recursive. See bug #22363 for details. Basically,
get_folder_info() is requesting a diary folder which in turn
connects which requests then calls get_folder() but deadlocks
because get_folder_info already holds the lock.
svn path=/trunk/; revision=16419
2002-04-09 Jeffrey Stedfast <fejj@ximian.com>
* mail-account-gui.c (setup_service): Kludge around the brokeness
that is GtkOptionMenu just like we kludge around it for the
authtype option menu.
svn path=/trunk/; revision=16417
* main.c (idle_cb): Change the logic for displaying a default
window, so we don't end up with two windows all the time.
svn path=/trunk/; revision=16416
2002-04-09 Jeffrey Stedfast <fejj@ximian.com>
* rule-editor.c (double_click): This needs to return a gboolean
(TRUE).
(rule_edit): Using gnome_dialog_set_parent instead of
gtk_widget_set_parent_window seems to fix bug #23226.
svn path=/trunk/; revision=16415
2002-04-09 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-message.c (camel_mime_message_set_date): Don't adjust
the timezone offset if we used tm.tm_gmtoff because it is already
adjusted.
svn path=/trunk/; revision=16412
* e-search-bar.c (e_search_bar_construct, add_button): Oops. The
previous change made the search bar widgets get packed in the
wrong order. So use gtk_box_pack_end instead in add_button and add
the two buttons in reverse order. It's all good now. Noticed by
Ettore, who I then promptly blamed for it. Sorry Ettore!
svn path=/trunk/; revision=16411
* backend/ebook/e-book-util.c (e_book_load_default_book): Update
for new-and-improved consistent default folder uri.
* gui/component/addressbook.c (addressbook_load_default_book): Use
e_book_load_default_book rather than duplicating most of its logic
here.
(load_uri_cb): Modify to work as a callback for
addressbook_load_default_book as well as addressbook_load_uri.
svn path=/trunk/; revision=16409
2002-04-10 Not Zed <NotZed@Ximian.com>
* filtertypes.xml: Added closing ) for "not starts with" subject
rule.
Added closing ) for all the other broken rules too ...
svn path=/trunk/; revision=16408
* e-setup.c (e_setup_check_db): New. Check that things that need
to be in the config db are. Right now it sets up the default
folders.
* e-shell.c (e_shell_construct): Call e_setup_check_db after
getting the config db.
* e-shell-constants.h: Add E_SUMMARY_URI, E_LOCAL_INBOX_URI, etc.
* e-shortcuts.c (e_shortcuts_add_default_group): Use
E_LOCAL_INBOX_URI, etc.
* e-shell-view.c: #define FALLBACK_URI to E_SUMMARY_URI
svn path=/trunk/; revision=16405
into my last commit.
* main.c (idle_cb): Check for "default:" URIs and treat them the
same way as "evolution:" URIs.
* e-shell.c (impl_Shell_handleURI): Handle "default:" URIs by
looking up the default folders in the config db.
svn path=/trunk/; revision=16403
* gui/component-factory.c (create_view): Add view_info arg. If the
view_info is non-empty and this is a calendar folder, set the
"view" property on the control's propertybag.
* gui/control-factory.c (calendar_properties_init): Set up the
"view" property.
(get_prop, set_prop): handle the "view" property by
getting/setting the GnomeCalendar's view. Unfortunately, this
doesn't actually work. See #23208.
* gui/calendar-commands.c (calendar_control_activate): Set the UI
component's container before calling
gnome_calendar_set_ui_component so that the search bar
initialization will work.
svn path=/trunk/; revision=16400
* Evolution-ShellComponent.idl (createView): Add a "view_info"
argument.
* e-shell-view.c (get_view_for_uri): if the URI contains a '#',
split it into a URI and a "view_info" at that point. (Otherwise,
pass "" for the view_info to ShellComponent_createView.) This can
be used for things like specifying day/month/week view to the
calendar.
* e-shell.c (create_view): Ignore e_shell_view_display_uri's
return code: it's possible/likely that the requested URL is remote
and hasn't been filled in yet.
(impl_Shell_handleURI): Don't use Shell_createNewView directly,
call e_shell_create_view_from_uri_and_settings. (For the above fix
and some others.)
* evolution-shell-component.c (impl_createView): Add view_info.
* evolution-shell-component-client.c
(evolution_shell_component_client_create_view): Add view_info.
* evolution-test-component.c (create_view_fn): add view_data.
* e-corba-storage-registry.c
(impl_StorageRegistry_getFolderByUri): kill a warning
svn path=/trunk/; revision=16397
2002-04-09 Not Zed <NotZed@Ximian.com>
* e-msg-composer-hdrs.c (set_recipients_from_destv): Use decode
rather than unformat - the e_destination was changed (long time
ago) to rfc2047 encode the addresses, so we should decode
likewise. Should fix#16158.
* e-msg-composer.c (next_word): g_utf8_next_char never returns
NULL, it just skips to the next character. So like normal string
code, we just check for a nul explicitly. Fixes a bug found while
checking #16158.
svn path=/trunk/; revision=16396
2002-04-08 Not Zed <NotZed@Ximian.com>
* mail-send-recv.c (receive_update_got_folderinfo): Argh!
get_folder_info owns and frees its *OWN* folder info, it shouldn't
be free'd here! See mail-ops.c:get_folderinfo_free.
This should fix#17259 and friends.
svn path=/trunk/; revision=16395
2002-04-09 Not Zed <NotZed@Ximian.com>
* camel-mime-part.c (construct_from_parser): If we get multiple
Content-Type header values, change subsequent headers to
X-Invalid-Content-Type so it doesn't wreck processing. This fixes
the reported case in #18929, but i dont know if it fixes the
original posters problems.
2002-04-08 Not Zed <NotZed@Ximian.com>
* camel-vtrash-folder.c (vtrash_move_messages_to): If we find
we're moving from the vtrash to another folder, we need to convert
the uid from a vfolder uid to the source uid (+8). Fix for
#20886. Also changed to batch multiple moves to different folders
so they are done as efficiently as possible rather than one at a
time.
* camel-mime-utils.c (base64_decode_step): If we only get passed
'=', we back track only if we actually output any data. Fix for
#21716.
(quoted_decode): Pass out size_t instead of int, and use 0 instead
of -1 for error since its not signed. This will fix similar bug
to above in different circumstances since the result is taken as
unsigned. This is only an internal func.
(quoted_encode): Return size_t just for consistency.
* camel-block-file.c (block_file_validate_root): Comment out the
debug and move it into a warning when the validation fails.
svn path=/trunk/; revision=16394
2002-04-08 Jeffrey Stedfast <fejj@ximian.com>
* mail-signature-editor.c (menu_file_save_cb): Since bonobo
doesn't seem to O_TRUNC the file stream before writing to it,
write to a temp file first and then rename() it to the real
filename. This also protects against losing data if the drive is
full too. Also use a real mode, not 0, so that we can actually
save/read the content ;-)
svn path=/trunk/; revision=16392
2002-04-08 Jeffrey Stedfast <fejj@ximian.com>
* GNOME_Evolution_Mail.oaf.in: Re-added the config wizard
interfaces. Ettore accidently removed them thinking they were
duplicates of the new mail-config interfaces.
* mail-config.glade: Remove the OK, Apply, Cancel buttons from the
keyboard shortcut tab in the composer_prefs dialog.
* mail-account-gui.c: No need to check gui->source before using
gui->source->url, since gui->source *has* to exist.
svn path=/trunk/; revision=16391
