callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove now unused 'recents' array/freeing func.

Browse Source 
2001-10-03    <NotZed@Ximian.com>

        * providers/imap/camel-imap-folder.c (camel_imap_folder_changed):
        Remove now unused 'recents' array/freeing func.

        * camel-object.c (camel_object_trigger_event): Oops, always run
        the prep function, even if we have no hooks listening.  Causes
        incoming imap recents to get ignored bythe camel-folder filter
        inbox code.

svn path=/trunk/; revision=13398
This commit is contained in:
3
2001-10-03 23:57:41 +00:00
committed by Michael Zucci
parent a39364e258
commit fc2062d77e
3 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
camel/ChangeLog
View File

@ -1,5 +1,13 @@
2001-10-03 <NotZed@Ximian.com>
* providers/imap/camel-imap-folder.c (camel_imap_folder_changed):
Remove now unused 'recents' array/freeing func.
* camel-object.c (camel_object_trigger_event): Oops, always run
the prep function, even if we have no hooks listening. Causes
incoming imap recents to get ignored bythe camel-folder filter
inbox code.
* providers/local/camel-local-folder.c (local_sync): Dont
explicitly save metadata, its saved in summary_sync.

15
camel/camel-object.c
View File

@ -882,10 +882,6 @@ camel_object_trigger_event (CamelObject * obj, const char * name, void *event_da
g_return_if_fail (CAMEL_IS_OBJECT (obj));
g_return_if_fail (name);
/* no hooks, dont bother going anywhere */
if (obj->hooks == NULL)
return;
/* get event name static pointer/prep func */
if (obj->classfuncs->event_to_preplist == NULL
|| !g_hash_table_lookup_extended(obj->classfuncs->event_to_preplist, name,
@ -895,12 +891,19 @@ camel_object_trigger_event (CamelObject * obj, const char * name, void *event_da
return;
}
/* try prep function, if false, then quit */
if (prep != NULL_PREP_VALUE && !prep(obj, event_data))
return;
/* also, no hooks, dont bother going further */
if (obj->hooks == NULL)
return;
/* lock the object for hook emission */
camel_object_ref(obj);
hooks = camel_object_get_hooks(obj);
if ((prep == NULL_PREP_VALUE || prep(obj, event_data))
&& hooks->list) {
if (hooks->list) {
/* first, copy the items in the list, and say we're in an event */
hooks->depth++;
pair = hooks->list;

5
camel/providers/imap/camel-imap-folder.c
View File

@ -1804,7 +1804,6 @@ camel_imap_folder_changed (CamelFolder *folder, int exists,
CamelImapFolder *imap_folder = CAMEL_IMAP_FOLDER (folder);
CamelFolderChangeInfo *changes;
CamelMessageInfo *info;
GPtrArray *recents = NULL;
int len;
CAMEL_IMAP_STORE_ASSERT_LOCKED (folder->parent_store, command_lock);
@ -1839,10 +1838,6 @@ camel_imap_folder_changed (CamelFolder *folder, int exists,
camel_object_trigger_event (CAMEL_OBJECT (folder), "folder_changed", changes);
camel_folder_change_info_free (changes);
if (recents)
g_ptr_array_free (recents, TRUE);
camel_folder_summary_save (folder->summary);
}