callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't leak the base64 encoded password buffer.

Browse Source 
2002-04-19  Jeffrey Stedfast  <fejj@ximian.com>

	* e-passwords.c (e_passwords_get_password): Don't leak the base64
	encoded password buffer.

svn path=/trunk/; revision=16551
This commit is contained in:
Jeffrey Stedfast
2002-04-20 02:25:01 +00:00
committed by Jeffrey Stedfast
parent 31c8721515
commit c2dbcb18f2
2 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
e-util/ChangeLog
View File

@ -1,3 +1,8 @@
2002-04-19 Jeffrey Stedfast <fejj@ximian.com>
* e-passwords.c (e_passwords_get_password): Don't leak the base64
encoded password buffer.
2002-04-16 Jeffrey Stedfast <fejj@ximian.com>
* e-host-utils.c (e_gethostbyaddr_r): New wrapper around

25
e-util/e-passwords.c
View File

@ -246,29 +246,32 @@ e_passwords_forget_password (const char *key)
char *
e_passwords_get_password (const char *key)
{
char *passwd = g_hash_table_lookup (passwords, key);
char *path;
char *path, *passwd = g_hash_table_lookup (passwords, key);
CORBA_Environment ev;
char *encoded;
if (passwd)
return g_strdup (passwd);
/* not part of the session hash, look it up in the on disk db */
path = password_path (key);
/* We need to pass an ev to bonobo-conf, or it will emit a
* g_warning if the data isn't found.
*/
CORBA_exception_init (&ev);
passwd = bonobo_config_get_string (db, path, &ev);
encoded = bonobo_config_get_string (db, path, &ev);
CORBA_exception_free (&ev);
g_free (path);
if (passwd)
return decode_base64 (passwd);
else
if (!encoded)
return NULL;
passwd = decode_base64 (encoded);
g_free (encoded);
return passwd;
}
/**