Add format checker (in compile time) to e_notice()

This commit is contained in:
Milan Crha
2012-10-17 14:40:59 +02:00
parent f12ec068f9
commit bac4efc7ce
3 changed files with 7 additions and 13 deletions

View File

@ -1123,11 +1123,8 @@ comp_server_send (ECalComponentItipMethod method,
_("Unable to book a resource, the "
"new event collides with some other."));
} else {
gchar *msg = g_strconcat (
_("Unable to book a resource, error: "),
error->message, NULL);
e_notice (NULL, GTK_MESSAGE_ERROR, msg);
g_free (msg);
e_notice (NULL, GTK_MESSAGE_ERROR,
_("Unable to book a resource, error: %s"), error->message);
}
retval = FALSE;

View File

@ -28,6 +28,6 @@
void e_notice (gpointer parent,
GtkMessageType type,
const gchar *format,
...);
...) G_GNUC_PRINTF (3, 4);
#endif /* E_DIALOG_UTILS_H */

View File

@ -1222,13 +1222,10 @@ action_submit_bug_cb (GtkAction *action,
g_spawn_command_line_async (command_line, &error);
if (error != NULL) {
const gchar *message;
if (error->code == G_SPAWN_ERROR_NOENT)
message = _("Bug Buddy is not installed.");
else
message = _("Bug Buddy could not be run.");
e_notice (shell_window, GTK_MESSAGE_ERROR, message);
e_notice (shell_window, GTK_MESSAGE_ERROR,
error->code == G_SPAWN_ERROR_NOENT ?
_("Bug Buddy is not installed.") :
_("Bug Buddy could not be run."));
g_error_free (error);
}
}