callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use g_hash_table_foreach_remove() instead so the keys don't point to

Browse Source 
2005-02-03  Jeffrey Stedfast  <fejj@novell.com>

	* message-list.c (message_list_set_folder): Use
	g_hash_table_foreach_remove() instead so the keys don't point to
	free'd values.
	(normalised_free): Return TRUE.

svn path=/trunk/; revision=28696
This commit is contained in:
Jeffrey Stedfast
2005-02-03 18:38:28 +00:00
committed by Jeffrey Stedfast
parent 7d53380f5c
commit b306386ca0
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
mail/ChangeLog
View File

@ -1,3 +1,10 @@
2005-02-03 Jeffrey Stedfast <fejj@novell.com>
* message-list.c (message_list_set_folder): Use
g_hash_table_foreach_remove() instead so the keys don't point to
free'd values.
(normalised_free): Return TRUE.
2005-02-02 Rodney Dawes <dobey@novell.com>
* em-subscribe-editor.c (em_subscribe_editor_new): Use the

8
mail/message-list.c
View File

@ -1846,10 +1846,12 @@ message_list_init (MessageList *message_list)
g_signal_connect (((GtkScrolledWindow *) message_list)->vscrollbar, "value-changed", G_CALLBACK (ml_scrolled), message_list);
}
static void
static gboolean
normalised_free (gpointer key, gpointer value, gpointer user_data)
{
e_poolv_destroy (value);
return TRUE;
}
static void
@ -1917,7 +1919,7 @@ message_list_finalise (GObject *object)
MessageList *message_list = MESSAGE_LIST (object);
struct _MessageListPrivate *p = message_list->priv;
g_hash_table_foreach (message_list->normalised_hash, normalised_free, NULL);
g_hash_table_foreach (message_list->normalised_hash, (GHFunc) normalised_free, NULL);
g_hash_table_destroy (message_list->normalised_hash);
if (message_list->thread_tree)
@ -2805,7 +2807,7 @@ message_list_set_folder (MessageList *message_list, CamelFolder *folder, const c
}
/* reset the normalised sort performance hack */
g_hash_table_foreach (message_list->normalised_hash, normalised_free, NULL);
g_hash_table_foreach_remove (message_list->normalised_hash, normalised_free, NULL);
mail_regen_cancel(message_list);