callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make sure we unref the mimeparse when we're done (successfully). This was

Browse Source 
2001-10-30    <NotZed@Ximian.com>

        * camel-filter-driver.c (camel_filter_driver_filter_mbox): Make
        sure we unref the mimeparse when we're done (successfully).  This
        was leaking an fd every get-mail! :(

        * camel-lock-client.c (camel_lock_helper_init): Close all fd's
        above 2.

svn path=/trunk/; revision=14468
This commit is contained in:
0
2001-10-30 18:22:14 +00:00
committed by Michael Zucci
parent cccb17b090
commit aa4d57d3e4
3 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
camel/ChangeLog
View File

@ -1,5 +1,12 @@
2001-10-30 <NotZed@Ximian.com>
* camel-filter-driver.c (camel_filter_driver_filter_mbox): Make
sure we unref the mimeparse when we're done (successfully). This
was leaking an fd every get-mail! :(
* camel-lock-client.c (camel_lock_helper_init): Close all fd's
above 2.
* providers/local/camel-mbox-folder.c (mbox_get_message): Remove
the X-Evolution header before anyone else gets to see this private
thing. Shoudl fix 11676 since we were inheriting flags from

7
camel/camel-filter-driver.c
View File

@ -655,6 +655,7 @@ camel_filter_driver_filter_mbox (CamelFilterDriver *driver, const char *mbox, co
struct stat st;
int status;
off_t last = 0;
int ret = -1;
fd = open (mbox, O_RDONLY);
if (fd == -1) {
@ -718,10 +719,8 @@ camel_filter_driver_filter_mbox (CamelFilterDriver *driver, const char *mbox, co
}
report_status (driver, CAMEL_FILTER_STATUS_END, 100, _("Complete"));
g_free (source_url);
return 0;
ret = 0;
fail:
g_free (source_url);
if (fd != -1)

4
camel/camel-lock-client.c
View File

@ -103,6 +103,8 @@ static int write_n(int fd, void *buffer, int inlen)
static int camel_lock_helper_init(CamelException *ex)
{
int i;
if (pipe(lock_stdin_pipe) == -1
|| pipe(lock_stdout_pipe) == -1) {
camel_exception_setv(ex, CAMEL_EXCEPTION_SYSTEM,
@ -131,6 +133,8 @@ static int camel_lock_helper_init(CamelException *ex)
close(lock_stdin_pipe[1]);
close(lock_stdout_pipe[0]);
close(lock_stdout_pipe[1]);
for (i=3;i<255;i++)
close(i);
execl(CAMEL_SBINDIR "/camel-lock-helper", "camel-lock-helper", NULL);
d(fprintf(stderr, "shit, couldn't exec lock helper!\n"));
/* it'll pick this up when it tries to use us */