callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added some warnings for bad cases.

Browse Source 
2001-07-24  Not Zed  <NotZed@Ximian.com>

	* camel-operation.c (camel_operation_register, unregister): Added
	some warnings for bad cases.

2001-07-23  Not Zed  <NotZed@Ximian.com>

	* camel-operation.c (camel_operation_register): Only insert a hash
	entry if we haven't already.
	(camel_operation_unregister): Only remove the has entry if the id
	is a real thread.

svn path=/trunk/; revision=11329
This commit is contained in:
Not Zed
2001-07-24 00:56:11 +00:00
committed by Michael Zucci
parent 2807ad0103
commit 5ef14553c1
2 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
camel/ChangeLog
View File

@ -1,3 +1,15 @@
2001-07-24 Not Zed <NotZed@Ximian.com>
* camel-operation.c (camel_operation_register, unregister): Added
some warnings for bad cases.
2001-07-23 Not Zed <NotZed@Ximian.com>
* camel-operation.c (camel_operation_register): Only insert a hash
entry if we haven't already.
(camel_operation_unregister): Only remove the has entry if the id
is a real thread.
2001-07-23 Jeffrey Stedfast <fejj@ximian.com>
* camel-filter-driver.c (do_move): Slight fix for when source ==

18
camel/camel-operation.c
View File

@ -291,8 +291,12 @@ void camel_operation_register(CamelOperation *cc)
}
}
cc->id = id;
g_hash_table_insert(operation_active, (void *)id, cc);
if (cc->id == (~0)) {
cc->id = id;
g_hash_table_insert(operation_active, (void *)id, cc);
} else {
g_warning("Re-registering thread %d for cancellation as thread %d", cc->id, id);
}
d(printf("registering thread %ld for cancellation\n", id));
@ -322,8 +326,14 @@ void camel_operation_unregister(CamelOperation *cc)
}
}
if (cc)
g_hash_table_remove(operation_active, (void *)cc->id);
if (cc) {
if (cc->id != (~0)) {
g_hash_table_remove(operation_active, (void *)cc->id);
cc->id == ~0;
} else {
g_warning("Unregistering an operation that was already unregistered");
}
}
CAMEL_ACTIVE_UNLOCK();