callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Multiple open dialogs is an usability issue and a potential HIG violation.

Browse Source 
2008-06-20  Sankar P  <psankar@novell.com>

	* mail-retract.c (retract_mail_settings):
	Multiple open dialogs is an usability issue
	and a potential HIG violation. 
	Thanks to Akhil for pointing out.



svn path=/trunk/; revision=35657
This commit is contained in:
Sankar P
2008-06-20 10:45:46 +00:00
committed by Sankarasivasubramanian Pasupathilingam
parent fff94b888b
commit 3f7fbeb14a
2 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/groupwise-features/ChangeLog
View File

@ -1,3 +1,10 @@
2008-06-20 Sankar P <psankar@novell.com>
* mail-retract.c (retract_mail_settings):
Multiple open dialogs is an usability issue
and a potential HIG violation.
Thanks to Akhil for pointing out.
2008-06-20 Sankar P <psankar@novell.com>
* mail-retract.c (retract_mail_settings):

13
plugins/groupwise-features/mail-retract.c
View File

@ -43,6 +43,7 @@ static void retract_mail_settings (EPopup *ep, EPopupItem *item, void *data)
CamelStore *store = folder->parent_store;
char *id;
GtkWidget *confirm_dialog, *confirm_warning;
int n;
cnc = get_cnc (store);
@ -62,7 +63,12 @@ static void retract_mail_settings (EPopup *ep, EPopupItem *item, void *data)
gtk_widget_set_size_request (confirm_dialog, 400, 100);
gtk_widget_show_all (confirm_dialog);
if (gtk_dialog_run (GTK_DIALOG (confirm_dialog)) == GTK_RESPONSE_YES) {
n =gtk_dialog_run (GTK_DIALOG (confirm_dialog));
gtk_widget_destroy (confirm_warning);
gtk_widget_destroy (confirm_dialog);
if (n == GTK_RESPONSE_YES) {
if (e_gw_connection_retract_request (cnc, id, NULL, FALSE, FALSE) != E_GW_CONNECTION_STATUS_OK )
e_error_run (NULL, "org.gnome.evolution.message.retract:retract-failure", NULL);
@ -72,10 +78,7 @@ static void retract_mail_settings (EPopup *ep, EPopupItem *item, void *data)
gtk_dialog_run (GTK_DIALOG(dialog));
gtk_widget_destroy (dialog);
}
}
gtk_widget_destroy (confirm_warning);
gtk_widget_destroy (confirm_dialog);
}
}
}