callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

handle_http_request: Skip invalid URIs

Browse Source 
It wasn't checked whether the passed-in URI was correct, but the message
object returned from soup_message_new() was dereferenced anyway, which
could cause a crash.
This commit is contained in:
Milan Crha
2015-02-20 14:29:36 +01:00
parent 8ae0b622cd
commit 2f7e0badb4
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
mail/e-http-request.c
View File

@ -361,6 +361,12 @@ handle_http_request (GSimpleAsyncResult *res,
GError *error;
GMainContext *context;
message = soup_message_new (SOUP_METHOD_GET, uri);
if (!message) {
g_debug ("%s: Skipping invalid URI '%s'", G_STRFUNC, uri);
goto cleanup;
}
context = g_main_context_new ();
g_main_context_push_thread_default (context);
@ -372,7 +378,6 @@ handle_http_request (GSimpleAsyncResult *res,
temp_session, "proxy-resolver",
G_BINDING_SYNC_CREATE);
message = soup_message_new (SOUP_METHOD_GET, uri);
soup_message_headers_append (
message->request_headers,
"User-Agent", "Evolution/" VERSION);