callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug #673525 - Crash under efh_write_message()

Browse Source 
Make sure the EMFormat* lives until EMailRequest is finished.
This commit is contained in:
Dan Vrátil
2012-04-13 11:53:21 +02:00
parent 1ae02fa69c
commit 2f530637b1
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
mail/e-mail-request.c
View File

@ -581,6 +581,11 @@ mail_request_finalize (GObject *object)
request->priv->ret_mime_type = NULL;
}
if (request->priv->efh) {
g_object_unref (request->priv->efh);
request->priv->efh = NULL;
}
G_OBJECT_CLASS (e_mail_request_parent_class)->finalize (object);
}
@ -647,6 +652,9 @@ mail_request_send_async (SoupRequest *request,
g_return_if_fail (emr->priv->efh);
/* Make sure the formatter lives until we are finished here */
g_object_ref (emr->priv->efh);
result = g_simple_async_result_new (G_OBJECT (request), callback,
user_data, mail_request_send_async);
g_simple_async_result_run_in_thread (result, handle_mail_request,
@ -674,6 +682,9 @@ mail_request_send_async (SoupRequest *request,
g_return_if_fail (emr->priv->efh);
/* Make sure the formatter lives until we are finished here */
g_object_ref (emr->priv->efh);
result = g_simple_async_result_new (G_OBJECT (request), callback,
user_data, mail_request_send_async);
g_simple_async_result_run_in_thread (result, handle_http_request,