callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove debug content_info_dump, could cause a crash, and not really needed

Browse Source 
2002-09-30  Not Zed  <NotZed@Ximian.com>

	* providers/imap/camel-imap-folder.c (imap_get_message): Remove
	debug content_info_dump, could cause a crash, and not really
	needed anymore.

	* camel-folder-summary.c (camel_content_info_dump): Check ci->type
	!= NULL before dereferencing it.  Should fix crash #31331.

svn path=/trunk/; revision=18259
This commit is contained in:
Not Zed
2002-09-30 05:06:51 +00:00
committed by Michael Zucci
parent de6d723803
commit 1dcff68ce6
3 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
camel/ChangeLog
View File

@ -1,3 +1,12 @@
2002-09-30 Not Zed <NotZed@Ximian.com>
* providers/imap/camel-imap-folder.c (imap_get_message): Remove
debug content_info_dump, could cause a crash, and not really
needed anymore.
* camel-folder-summary.c (camel_content_info_dump): Check ci->type
!= NULL before dereferencing it. Should fix crash #31331.
2002-09-27 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-folder.c (decode_internaldate): New

7
camel/camel-folder-summary.c
View File

@ -2758,8 +2758,11 @@ camel_content_info_dump (CamelMessageContentInfo *ci, int depth)
return;
}
printf ("%scontent-type: %s/%s\n", p, ci->type->type ? ci->type->type : "(null)",
ci->type->subtype ? ci->type->subtype : "(null)");
if (ci->type)
printf ("%scontent-type: %s/%s\n", p, ci->type->type ? ci->type->type : "(null)",
ci->type->subtype ? ci->type->subtype : "(null)");
else
printf ("%scontent-type: <unset>\n", p);
printf ("%scontent-transfer-encoding: %s\n", p, ci->encoding ? ci->encoding : "(null)");
printf ("%scontent-description: %s\n", p, ci->description ? ci->description : "(null)");
printf ("%ssize: %lu\n", p, (unsigned long) ci->size);

2
camel/providers/imap/camel-imap-folder.c
View File

@ -1957,8 +1957,6 @@ imap_get_message (CamelFolder *folder, const char *uid, CamelException *ex)
camel_imap_response_free (store, response);
d(camel_content_info_dump (mi->content, 0));
if (!mi->content->type) {
/* FETCH returned OK, but we didn't parse a BODY
* response. Courier will return invalid BODY