callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mail_parser_run(): Eliminate a dead code branch.

Browse Source 
There's no need to check whether the 'parsers' GQueue is NULL since we
assert that it's non-NULL just a few lines above.
This commit is contained in:
Matthew Barnes
2012-12-04 12:01:43 -05:00
parent dff6f5d85d
commit 0862979d13
1 changed files with 16 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
em-format/e-mail-parser.c
View File

@ -82,37 +82,29 @@ mail_parser_run (EMailParser *parser,
part_id = g_string_new (".message");
parts = NULL;
if (!parsers) {
parts = e_mail_parser_wrap_as_attachment (
parser, CAMEL_MIME_PART (message),
NULL, part_id, cancellable);
} else {
for (iter = parsers->head; iter; iter = iter->next) {
for (iter = parsers->head; iter; iter = iter->next) {
EMailParserExtension *extension;
EMailParserExtension *extension;
if (g_cancellable_is_cancelled (cancellable))
break;
if (g_cancellable_is_cancelled (cancellable))
break;
extension = iter->data;
if (!extension)
continue;
extension = iter->data;
if (!extension)
continue;
parts = e_mail_parser_extension_parse (
extension, parser, CAMEL_MIME_PART (message),
part_id, cancellable);
parts = e_mail_parser_extension_parse (
extension, parser, CAMEL_MIME_PART (message),
part_id, cancellable);
if (parts != NULL)
break;
}
parts = g_slist_prepend (
parts,
e_mail_part_new (
CAMEL_MIME_PART (message),
".message"));
if (parts != NULL)
break;
}
parts = g_slist_prepend (
parts,
e_mail_part_new (CAMEL_MIME_PART (message), ".message"));
g_string_free (part_id, TRUE);
return parts;