Use GtkType (I only changed this one because I turned on debugging for a

2002-07-25  Jeffrey Stedfast  <fejj@ximian.com>

	* filter-int.[c,h]: Use GtkType (I only changed this one because I
	turned on debugging for a bit).

	* filter-file.c (validate): Fix the strcmp logic a bit, I had it
	the exact opposite of what I really wanted. Oops :-)

svn path=/trunk/; revision=17586
This commit is contained in:
Jeffrey Stedfast
2002-07-25 08:49:56 +00:00
committed by Jeffrey Stedfast
parent 6ea2a4da8b
commit 00a8f5e2ec
5 changed files with 24 additions and 7 deletions

View File

@ -1,3 +1,11 @@
2002-07-25 Jeffrey Stedfast <fejj@ximian.com>
* filter-int.[c,h]: Use GtkType (I only changed this one because I
turned on debugging for a bit).
* filter-file.c (validate): Fix the strcmp logic a bit, I had it
the exact opposite of what I really wanted. Oops :-)
2002-07-25 Jeffrey Stedfast <fejj@ximian.com>
* filter-file.c (validate): Do some minimalistic validation of

View File

@ -41,7 +41,7 @@
#include "filter-file.h"
#include "e-util/e-sexp.h"
#define d(x)
#define d(x)
static gboolean validate (FilterElement *fe);
static int file_eq(FilterElement *fe, FilterElement *cm);
@ -183,7 +183,7 @@ validate (FilterElement *fe)
/* FIXME: do more to validate command-lines? */
if (strcmp (file->type, "file") != 0) {
if (strcmp (file->type, "file") == 0) {
if (stat (file->path, &st) == -1 || !S_ISREG (st.st_mode)) {
char *errmsg;
@ -195,7 +195,7 @@ validate (FilterElement *fe)
gnome_dialog_run_and_close (GNOME_DIALOG (dialog));
return FALSE;
}
} else if (strcmp (file->type, "command") != 0) {
} else if (strcmp (file->type, "command") == 0) {
/* only requirements so far is that the command can't
be an empty string */
return file->path[0] != '\0';
@ -270,6 +270,7 @@ xml_decode (FilterElement *fe, xmlNodePtr node)
str = xmlNodeGetContent (n);
if (str) {
decstr = e_utf8_xml1_decode (str);
xmlFree (str);
} else

View File

@ -57,10 +57,10 @@ enum {
static guint signals[LAST_SIGNAL] = { 0 };
guint
GtkType
filter_int_get_type (void)
{
static guint type = 0;
static GtkType type = 0;
if (!type) {
GtkTypeInfo type_info = {
@ -203,16 +203,20 @@ xml_decode (FilterElement *fe, xmlNodePtr node)
fe->name = name;
type = xmlGetProp(node, "type");
d(printf ("Type = %s\n", type));
g_free(fs->type);
fs->type = g_strdup(type);
xmlFree(type);
intval = xmlGetProp (node, type?type:"integer");
if (intval) {
d(printf ("Value = %s\n", intval));
fs->val = atoi (intval);
xmlFree (intval);
} else
} else {
d(printf ("Value = ?unknown?\n"));
fs->val = 0;
}
return 0;
}

View File

@ -52,7 +52,7 @@ struct _FilterIntClass {
/* signals */
};
guint filter_int_get_type (void);
GtkType filter_int_get_type (void);
FilterInt *filter_int_new (void);
FilterInt *filter_int_new_type(const char *type, int min, int max);
void filter_int_set_value(FilterInt *fi, int val);

View File

@ -19,7 +19,11 @@
* Boston, MA 02111-1307, USA.
*/
#ifdef HAVE_CONFIG_H
#include <config.h>
#endif
#include <string.h>
#include <glib.h>
#include <gtk/gtkframe.h>