59298d9e82
fontchooser: Reorganize code a bit
...
The main reason is so that we have a new function that we can use from
the cursor_changed_cb.
2011-09-22 21:44:05 +02:00
132ccf021f
fontchooser: Don't store the current face and family anymore
...
They can be queried on-demand from the font list.
2011-09-22 21:44:05 +02:00
7cf53a9f60
fontchooser: Take font description from model
...
... instead of taking face and constructing it from there.
2011-09-22 21:44:05 +02:00
2b83d03604
fontchooser: Sanitize variable declarations
...
- no empty lines between variables
- no unnecessary casts
- use glib-style casts
- no spaces
2011-09-22 21:44:05 +02:00
5a5737e3b6
fontchooser: Fix leak
...
the path variable is set, not filled in.
2011-09-22 21:44:05 +02:00
a124d17825
fontchooser: Store an iter to the current font
...
Note that we cannot use GtkTreeSelection for this, because when the font
list is filtered the current font may not be visible.
2011-09-22 21:44:05 +02:00
9d96830571
cssprovider: Remove outdated docs
2011-09-22 21:44:05 +02:00
6499088f7f
fontchooser: Store tree model member variables as GtkTreeModel
...
... and remove the now unnecessary treemodel casts everywhere.
Just code cleanup.
2011-09-22 21:44:05 +02:00
3d87ee7716
fontchooser: Rename populate_list() function
...
Name it gtk_font_chooser_widget_load_fonts(). Also, don't take any
arguments, they were the same everywhere and they're member variables of
the font chooser anyway.
2011-09-22 21:44:04 +02:00
6cbbc789d5
fontchooser: Make changing the preview text fast
...
Instead of reloading the font list, we now just queue a redraw. This
works, because the preview text is added using a cell data func instead
of a custom column.
2011-09-22 21:44:04 +02:00
5834691e69
fontchooser: Use a cell_data_func for the font list
...
This way, we don't have to store the preview text in the list.
2011-09-22 21:44:04 +02:00
3a77b7e005
fontchooser: Don't scroll in the populate_list() function
2011-09-22 21:44:04 +02:00
ded10365a1
fontchooser: Remove needless scroll calls
...
Previous functions take care of scrolling already.
2011-09-22 21:44:04 +02:00
3af04c1dce
fontchooser: Introduce gtk_font_chooser_find_font()
...
... which looks up the font in the list of fonts. This then can be used
to select an actual font upon changes.
Also fixes cases where the get_family() and get_face() functions would
return outdated data when set_font() had been called.
2011-09-22 21:44:04 +02:00
fe8ed0a3f6
fontchooser: Rewrite size changes
...
They now go through gtk_font_chooser_widget_take_font_desc(). The end
goal is to make all changes go through this function, so that all
updates that are happening are easy to track.
Another change is that the code now merges the font description instead
of just using the new one. This avoids weird situations when people set
the font "Bold" for example, which has neither a size nor a font family.
2011-09-22 21:44:04 +02:00
af5f593b6d
fontchooser: Fix size computation
2011-09-22 21:44:04 +02:00
8f33324750
fontchooser: Fix gcc warnings
2011-09-22 21:44:04 +02:00
3d165c1a90
gtkmountoperation-x11: unbreak compilation on OpenBSD.
...
Add missing header to prevent undeclared definitions.
Bug #659565
2011-09-21 16:02:33 +02:00
0561c7a68d
GtkTreeModelFilter: Fix build warnings
...
https://bugzilla.gnome.org/show_bug.cgi?id=659441
2011-09-20 09:06:54 +02:00
34f9e6a0f3
fontchooser: Remove special case for a single signal handler
2011-09-19 22:11:06 +02:00
a4c3271854
fontchooser: Remove useless code
...
gtk_adjustment_set_value() clamps itself, no need to do the clamping.
But I was impressed at the amount of comments.
2011-09-19 22:11:06 +02:00
e465023051
fontchooser: Don't store the size separately
...
Instead, use the font description's size.
2011-09-19 22:11:06 +02:00
6552a8245b
fontchooser: Don't reload the fonts on style changes
...
It's not necessary, because nothing changes.
2011-09-19 22:11:06 +02:00
64d3350264
fontchooser: Assume NULL screen means the default screen
...
... and update the font list only when the screen actually changes.
2011-09-19 22:11:06 +02:00
ae5f82e455
fontchooser: Store the font description in the model
...
It's actually expensive to create (>5ms per font with >1000 fonts
installed), so better cache it.
2011-09-19 22:11:06 +02:00
6d8010d3d4
fontchooser: Move the filter func to the visibility func
...
... instead of rereading all the fonts every time.
With this change, the liststore now contains every font face known to
GTK, so we can actually walk it for matching fonts.
2011-09-19 22:11:06 +02:00
d88b7a6d6b
fontchooser: Fix code to make it not look like GTK 0.9
2011-09-19 22:11:06 +02:00
b95bbb5e39
fontchooser: List font description as font description
...
Otherwise there will be two properties listed as "Font" in property
selectors (in Glade or testfontchooser).
2011-09-19 22:11:05 +02:00
a5f516c818
fontchooser: Family or face can never be NULL
...
... so there's no need to special-case those situations.
2011-09-19 22:11:05 +02:00
fb2bc139bb
fontchooser: Use gtk_list_store_insert_with_values()
...
... instead of append() + set_values()
2011-09-19 22:11:05 +02:00
824aeb77c6
fontchooserwidget: Simplify function
...
- Don't do unnecessary casts
- Fix weird variable declaration indenting
- Fix loop indentation
- Use a for loop for iterating over a list, instead of a while loop
- Casefold font name only once, instead of every iteration
- Remove needless true_var = true_var && TRUE assignment
2011-09-19 22:11:05 +02:00
22cd009ef7
GtkPaned: Create the child window at the correct position
...
When there is only a single child, create its window at the correct position
https://bugzilla.gnome.org/show_bug.cgi?id=659241
2011-09-19 12:28:59 +01:00
e1ede022f8
treemodelfilter: add additional asserts to MODEL_FILTER_DEBUG mode
2011-09-17 06:09:35 +02:00
25a514da8a
Remove left-over calls to dump function
2011-09-17 06:09:35 +02:00
3c2eb053d6
link-button: Reset the mouse cursor when destroyed
...
If clicking on a link destroys the link button, and keeps the
same GdkWindow then the cursor stays as a hand in the rest of
the interface.
https://bugzilla.gnome.org/show_bug.cgi?id=659247
2011-09-16 15:06:28 +01:00
e9de907f9e
iconview: add support for prelight cells
...
Render GtkIconView cell items with the prelight state flag when they're
being mouse hovered.
This works basically in the same way it's done for GtkTreeView cells,
and e.g. GtkCellRendererPixbuf will need to have its follow-state
property to opt in to prelight rendering.
https://bugzilla.gnome.org/show_bug.cgi?id=615501
2011-09-15 09:34:04 -04:00
f86351c05f
GtkApplication: chain up ::startup
2011-09-14 14:04:10 -04:00
9ddc11fbb5
iconview: Don't rturn TRUE from draw handler
2011-09-14 16:10:14 +02:00
9e8b2f2521
treeview: Return FALSE from draw handler
...
... like every widget should.
https://bugzilla.gnome.org/show_bug.cgi?id=658981
2011-09-14 16:10:14 +02:00
07cecfc601
Fix a parameter name mismatch
2011-09-13 17:36:24 -04:00
432b7ee2bc
Merge branch 'bgo593793-filechooser-recent-folders-master'
2011-09-13 15:24:37 -05:00
c132b6cfc7
bgo#658600 - Don't try to focus the location entry in Recent-files mode
...
We don't ever start up in Search mode, so we don't need an extra check for that mode, yet.
Signed-off-by: Federico Mena Quintero <federico@gnome.org >
2011-09-13 15:24:29 -05:00
71c16bad33
Take font size also from the font description
2011-09-13 12:55:34 +02:00
d82895127e
Remove some unnecessary casts
2011-09-13 12:55:34 +02:00
8219a413ff
Clarify conditions when get_font_{family,face} return NULL
2011-09-13 12:55:34 +02:00
b1ff243c57
Fix implementation of GtkFontButton:get_font_{family,face}
...
Returns a PangoFont{Family,Face} even when the font dialogue
has never been popped up.
2011-09-13 12:55:34 +02:00
6902813a11
Rename gtk_font_chooser_get_{family,face,size}
...
... to gtk_font_chooser_get_font_{family,face,size}, in order to
avoid naming conflicts in bindings.
2011-09-13 12:55:33 +02:00
abd9242f33
Add GtkFontChooser:font-desc property
...
Add a way to set/get the font as a PangoFontDescription.
2011-09-13 12:55:33 +02:00
1b818f2e46
Remove GtkFontChooser:[sg]et_font
...
Now that the setter doesn't return a value anymore, we can just use
g_object_[sg]et instead of having these vfuncs.
2011-09-13 12:55:22 +02:00
0b7db6888a
Setters should not return a boolean
...
The setter for the "font" property returned a boolean that indicated
whether the given font has been found. Instead, fall back to the default
font name when the given font doesn't exist.
2011-09-13 12:55:22 +02:00
