21114071ec
Change the default for "show-desktop" back to TRUE
...
Change the GtkSettings default for "shell-shows-desktop" back to TRUE
and also change the default value of the "show-desktop" property on
GtkPlacesSidebar so that the defaultvalue test passes.
https://bugzilla.gnome.org/show_bug.cgi?id=712302
2013-11-26 14:21:01 -05:00
f4f82e736c
GtkPlacesSidebar: don't unref an object we don't own
...
gtk_settings_get_default() doesn't return a reference, so don't unref it
during dispose.
2013-11-14 18:30:47 -08:00
c4141a2115
GtkPlacesSidebar: use shell-shows-desktop setting
...
Use the just-added shell-shows-desktop GtkSetting to determine if we
should also show the "Desktop" folder in the places sidebar.
https://bugzilla.gnome.org/show_bug.cgi?id=712302
2013-11-14 15:03:04 -05:00
3f5af532f7
GtkPlacesSidebar: Show unmounted bookmarks
...
The GtkFileInfo is only used if there's no bookmark name,
or to get the icon for the remote share or local folder.
https://bugzilla.gnome.org/show_bug.cgi?id=711548
2013-11-13 23:23:50 -05:00
8b7940c0b1
Silence a compiler warning
2013-11-09 19:26:22 -05:00
2a6039e47f
Filter out duplicate application shortcuts
...
The file chooser used to do this, the places sidebar
still needs to learn it.
https://bugzilla.gnome.org/show_bug.cgi?id=711636
2013-11-09 19:01:27 -05:00
9e5a8b7ae1
GtkPlacesSidebar: Add local-only
...
This is necessary to implement the filechooser property
of the same name.
https://bugzilla.gnome.org/show_bug.cgi?id=711574
2013-11-09 18:32:51 -05:00
bce6185494
Update coding style
...
gtkplacessidebar.c was looking foreign.
2013-11-09 18:32:51 -05:00
3abae96740
Properly set drop targets
...
Pointed out in by Nelson Benitez in bug 707679.
2013-11-09 15:20:02 -05:00
cf00c43154
Revert "GtkPlacesSidebar: support switching locations for XDS drag types"
...
This reverts commit 588ffa8c32
2013-10-23 15:55:14 -04:00
c9f8d22094
Revert "GtkPlacesSidebar: support open locations when dragging text"
...
This reverts commit 1b839d4b72
2013-10-23 15:54:52 -04:00
aa7bb22685
Revert "GtkPlacesSidebar: use gtk api to add dnd uri targets"
...
This reverts commit 7fa27dff25
2013-10-23 15:54:44 -04:00
7fa27dff25
GtkPlacesSidebar: use gtk api to add dnd uri targets
...
Instead of hardcoding it in the dnd drop targets list.
Part of bug 707679
2013-10-23 20:20:33 +02:00
1b839d4b72
GtkPlacesSidebar: support open locations when dragging text
...
Make GtkPlacesSidebar also open locations when hovered by
text dnd targets.
Part of bug 707679
2013-10-23 20:20:33 +02:00
588ffa8c32
GtkPlacesSidebar: support switching locations for XDS drag types
...
Make GtkPlacesSidebar also change locations when hovered
by XDS dnd targets (eg. dragging a file from file-roller).
Part of bug 707679
2013-10-23 20:20:33 +02:00
438cd857c4
all: Add names to timeouts
...
Add names to every timeout we setup, so it's easier to track their
usage, and debug possible misbehaviour.
https://bugzilla.gnome.org/show_bug.cgi?id=710651
2013-10-23 13:31:18 +02:00
17a1f4abad
Populate GtkPlacesSidebar at initialization
...
Previously, the "Places" sidebar was populated by the update_places()
call from within gtk_places_sidebar_style_set(). After
742a2f11a9https://bugzilla.gnome.org/show_bug.cgi?id=709522
2013-10-06 16:06:14 -04:00
35be1c8b56
places sidebar: Small cleanup
2013-10-03 18:30:39 +02:00
e5317f0f9a
Improve struct packing in various places
2013-09-21 23:50:55 -04:00
1e5dde7eab
places sidebar: Don't activate the bookmark if Eject was clicked
...
This should really fix https://bugzilla.gnome.org/show_bug.cgi?id=704087 ...
Signed-off-by: Federico Mena Quintero <federico@gnome.org >
2013-09-20 21:14:00 -05:00
24751cba8e
places sidebar: don't open a bookmark when clicking eject
...
Trying to open a bookmark which is being ejected is at best confusing.
https://bugzilla.gnome.org/show_bug.cgi?id=704087
2013-09-19 18:05:49 -05:00
6aa56979dc
More documentation fixes
2013-09-17 01:28:39 -04:00
624ec0fb7d
Add a style class for context menus
...
Attached widgets inherit from the style of the widget they are
attached to. This can sometimes have unintended consequences,
like a context menu in the main view of gedit inheriting the font
that is configured for documents, or the context menu of the preview
in the font chooser coming up with humongous font size.
To fix this problem, we introduce a context menu style class
and use it for all menus that are used like that. The theme
can then set a font for this style class.
https://bugzilla.gnome.org/show_bug.cgi?id=697127
2013-08-18 13:46:48 -04:00
2f1fa7cdc3
Drop some unnecessary includes
...
Drop includes of deprecated headers where they are
no longer needed.
2013-07-19 22:32:23 -04:00
0aa57d26b5
Move wholly deprecated classes to gtk/deprecated/
...
We've recently a number of classes wholly. For these cases,
move the headers and sources to gtk/deprecated/ and adjust
Makefiles and includes accordingly.
Affected classes:
GtkAction
GtkActionGroup
GtkActivatable
GtkIconFactory
GtkImageMenuItem
GtkRadioAction
GtkRecentAction
GtkStock
GtkToggleAction
GtkUIManager
2013-07-19 21:39:47 -04:00
a4332e7f69
Set reasonable minimum size for the file chooser
...
At small sizes it just looks broken.
2013-07-17 20:48:59 -04:00
dae6afc847
Deprecate and ignore timeout-expand setting
2013-07-11 17:08:15 -04:00
d0a2e06c7d
places sidedbar: deal with lack of symbolics
...
Use g_themed_icon_new_with_default_fallbacks, so we don't end up
without icons when the theme doesn't have symbolic icons.
https://bugzilla.gnome.org/show_bug.cgi?id=703606
2013-07-09 07:12:18 -04:00
aef9dca9d5
Deprecate GtkIconFactory, GtkIconSet, GtkIconSource
...
We want to use GtkIconTheme instead. It is worth noting that
the parts that remain undeprecated are GtkIconSize and gtk_icon_size_lookup.
2013-06-26 20:02:27 -04:00
02c793f24a
Start migrating internals away from GtkStock
2013-06-24 22:20:49 -04:00
b08fe39cd8
GtkPlacesSidebar: do not unref mount
...
Do not unref mount has we grabbed its pointer without taking
a reference.
Otherwise the following call to g_list_free_full on network_mounts
frees it a second time. Segfault in nautilus ensue.
https://bugzilla.gnome.org/show_bug.cgi?id=700979
2013-05-26 00:03:13 -04:00
dc2f399dd0
GtkPlacesSidebar: Only create bookmarks for folders, not files
...
https://bugzilla.gnome.org/show_bug.cgi?id=561221
Signed-off-by: Federico Mena Quintero <federico@gnome.org >
2013-05-22 17:22:28 -05:00
67c8ebc5d5
GtkPlacesSidebar: Fixed tooltip capitalization
...
Use sentence capitalization for the tooltip on the file system disk under Devices.
https://bugzilla.gnome.org/show_bug.cgi?id=698933
2013-05-13 05:47:05 -04:00
34c0deb006
GtkPlacesSidebar: Fix an uninitialized variable in the error code path
...
Initialize it to NULL early so that we won't try to free an
uninitialized variable when handling an error.
2013-05-07 14:01:54 +02:00
c6894cd606
Try this again
...
When the hostnamed call is cancelled, we get a G_IO_ERROR_CANCELLED
error back. Handle it properly.
2013-05-02 09:29:35 -04:00
f7f63ae3ee
Revert "Remove a superfluous ref"
...
This reverts commit f326c0eac8
2013-05-02 08:23:58 -04:00
f326c0eac8
Remove a superfluous ref
...
If we cancel the call in dispose, no need to ref the object
we pass as userdata. Avoids the risk of leaking the ref if
the call is actually canceled.
2013-05-02 05:53:40 -04:00
2f0a5dd541
GtkPlacesSidebar: Correct all since tags
2013-05-01 21:19:37 -04:00
5322420145
Use friendlier property names for Glade
2013-04-22 15:46:59 -04:00
9b91e06513
Oops, only show 'Connect to server' if the caller enabled it
2013-04-21 18:20:46 -04:00
9d8e3be6d7
Add a selected_volume argument to ::populate-popup
...
Nautilus needs this in order to implement a Format command for a volume's popup menu.
Signed-off-by: Federico Mena Quintero <federico@gnome.org >
2013-04-21 12:41:33 -04:00
9ded1c0c99
Sync from nautilus commit 500770e8de18b07392ffa4435372525d5d03c688
...
Add a Connect to Server menu item, a show-connect-to-server property, and a show-connect-to-server signal.
2013-04-20 19:14:59 -04:00
2d84ebeeb8
Remove the switch location timer during drag_leave
...
So that hovering in and out of the sidebar quickly doesn't cause a location change in the caller.
2013-04-20 16:21:33 -04:00
e9c4dcd3f8
Sync from nautilus commit d2bfffc574c1e6305d862c041b35c9c45ba67674
...
Coding style fix.
2013-04-20 15:59:04 -04:00
755e37ffdf
Sync from nautilus commit 277a6a45bee8186b2493ad1b286234ac52f1aed8
...
Use gtk_tree_view_set_activate_on_single_click().
2013-04-20 15:58:55 -04:00
fa1f7d3f97
Sync nautilus commit 95400548176688f3d2f5e8888f48410756bd96b8
...
Switch location on hovering the places sidebar during a DnD operation -
kind of for spring-loaded folders.
2013-04-20 15:56:59 -04:00
3b34e70f13
Remove the drop feedback row a little time after drag_leave
...
Since ::drag-leave gets emitted before ::drag-drop, we can't just remove the drop feedback row
in drag-leave, as we *need* it during drag-drop. So, we use the same trick as in testdnd.c - we
install a timeout handler in our drag-leave callback, and remove the feedback in the timeout callback.
Signed-off-by: Federico Mena Quintero <federico@gnome.org >
2013-04-20 14:53:03 -04:00
9c38ff7dfb
Drop in the right place when the feedback row is active
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org >
2013-04-20 14:53:03 -04:00
3083308d1c
Actually use the drop_state, instead of encoding things in new_bookmark_index
...
This lets us keep the new_bookmark_index untouched even when the drop state goes from armed to unarmed.
That will in turn let us drop in the right place...
Signed-off-by: Federico Mena Quintero <federico@gnome.org >
2013-04-20 11:42:04 -04:00
a1b9bf7fbc
Adjust the drag destination row when it is above the currently highlighted row
...
This makes the feedback accurate and without hysteresis. Haven't I written this code ten times before?
Signed-off-by: Federico Mena Quintero <federico@gnome.org >
2013-04-19 17:24:03 -05:00
