Commit Graph

9163 Commits

Author SHA1 Message Date
1a312bfa3e Improve GtkBuilder error reporting
Make GtkBuilder report an error when it encounters a duplicate id,
instead of segfaulting later on
2009-04-06 20:13:35 -04:00
1ad8bfb69a Better i18n support in GtkBuilder
Let descriptions of accessible actions be translated, by specifying
the description as content of the <action> element, and allowing
"translatable", "context" and "comment" as attributes. (#518642)
2009-04-06 12:12:08 -04:00
8ab5f5673b Move G_END_DECLS before the #endif in gtkitemfactory.h
Bug 577650 – gtkitemfactory.h fails to compile

Place G_END_DECLS inside conditionals, otherwise C++ compilers
will see a closing curly bracket when including the file for
the second time.
2009-04-04 13:40:12 +02:00
b25cfb78fc fix slist/list confusion
Don't use g_list_find on a GSList in _gtk_window_set_is_toplevel
(rh#492767).
2009-04-02 10:21:15 -04:00
3b437b016c Bug 577224 – crash when setting new icon after setting icon in
2009-03-29  Christian Persch  <chpe@gnome.org>

	Bug 577224 – crash when setting new icon after setting icon in
	gtkstatusicon

	* gtk/gtkstatusicon.c: (gtk_status_icon_reset_image_data),
	(gtk_status_icon_set_from_gicon): Retain a reference when setting
	from a GIcon, and use g_object_unref on GIcon, not g_free.

svn path=/trunk/; revision=22594
2009-03-29 21:25:13 +00:00
de60fd8cfd Use gtk_entry_xxx functions rather than using GtkEntry structure directly.
See bug #576801

svn path=/trunk/; revision=22589
2009-03-27 05:22:23 +00:00
e5110c50b6 Typo correction, s/hilding/holding
svn path=/trunk/; revision=22588
2009-03-25 22:54:10 +00:00
584bd9cbc6 Bug 574283 – unused assignment and dead code in
2009-03-19  Claudio Saavedra  <csaavedra@igalia.com>

	Bug 574283 – unused assignment and dead code in
	gtk_widget_set_tooltip_window()

	* gtk/gtkwidget.c: (gtk_widget_set_tooltip_window): Remove
	an unused assignment, improving checks, and clean up method.


svn path=/trunk/; revision=22575
2009-03-19 07:47:23 +00:00
576ef4d6ea add static function gtk_scale_button_set_orientation_private() and use it
2009-03-18  Michael Natterer  <mitch@gimp.org>

	* gtk/gtkscalebutton.c: add static function
	gtk_scale_button_set_orientation_private() and use it instead of
	the public but deprecated gtk_scale_button_set_orientation().


svn path=/trunk/; revision=22574
2009-03-18 21:19:07 +00:00
f3bcc940a6 Newer mingw-w64 uses an underscore-prefixed identification macro.
2009-03-17  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkprintoperation-win32.c: Newer mingw-w64 uses an
	underscore-prefixed identification macro.


svn path=/trunk/; revision=22561
2009-03-17 12:58:40 +00:00
20708e3827 Fix problems with window positioning
svn path=/trunk/; revision=22524
2009-03-11 23:27:07 +00:00
013cd9bbda Bug 574561 – gtk_style_get "shadows" g_object_get
* gtk/gtk.symbols:
        * gtk/gtkstyle.[hc]: Rename gtk_style_get_property to
        gtk_style_get_style_property to avoid problems for language
        bindings. Pointed out by Torsten Schoenfeld.


svn path=/trunk/; revision=22502
2009-03-10 18:58:23 +00:00
4b497ad5e8 ::icon-press and ::icon-release are not action signals. Pointed out by
* gtk/gtkentry.c: ::icon-press and ::icon-release are not
        action signals. Pointed out by Murray Cumming


svn path=/trunk/; revision=22501
2009-03-10 17:45:25 +00:00
2f915bec20 Fixed regression reported in bug #574059. (search button not available in
2009-03-04  Michael Hasselmann <michaelh@openismus.com>

* gtk/gtkcomboboxentry.c (gtk_combo_box_entry_contents_changed):
Fixed regression reported in bug #574059. (search button not available in 
some cases.) The old implementation relied on bug #572478.

svn path=/trunk/; revision=22500
2009-03-10 15:57:16 +00:00
4227351c44 Clear all optionally created widget pointer in priv. Initially priv is
2009-03-10  Alexander Larsson  <alexl@redhat.com>

        * gtk/gtkmountoperation.c:
        (gtk_mount_operation_ask_password):
	Clear all optionally created widget pointer in priv. Initially
	priv is cleared so thats ok, but on a second call we may have
	leftovers from previous calls which is problematic if for instance
	we asked for the user the first time and not the second, then we
	will access the old priv->username_entry.



svn path=/trunk/; revision=22496
2009-03-10 10:29:03 +00:00
06759f3674 don't call gtk_orientable_set_orientation() because that calls
2009-03-06  Michael Natterer  <mitch@gimp.org>

	* gtk/gtkscalebutton.c (gtk_scale_button_set_property): don't call
	gtk_orientable_set_orientation() because that calls g_object_set()
	again -> infinite recursion. Call gtk_scale_button_set_orientation()
	instead.


svn path=/trunk/; revision=22478
2009-03-06 14:06:46 +00:00
a1ec034734 Improve the drawing of progress in entries, using fg/bg[SELECTED]. Add a
* gtk/gtkentry.c: Improve the drawing of progress in entries,
        using fg/bg[SELECTED]. Add a progress-border style property.
        Draw progress behind icons too.
        * gtk/gtkrc.c: Add defaults for fg/bg[SELECTED] in entries.
        Patch by Benjamin Berg.



svn path=/trunk/; revision=22445
2009-03-02 18:22:56 +00:00
d30ea97464 If additional areas got invalidated, don't try to add them to the paint
* gtk/gtktextview.c (gtk_text_view_paint): If additional areas got
        invalidated, don't try to add them to the paint region: in an expose
        handler, we cannot paint outside the area that was passed in, since
        drawing will be clipped. So stealing the update region from the
        window causes lost draws.
        Patch by Owen Taylor


svn path=/trunk/; revision=22442
2009-03-02 15:45:53 +00:00
1291ab4a18 Switch to the newly created folder on success.
* gtk/gtkfilechooserdefault.c (edited_idle_cb): Switch to the newly
        created folder on success.


svn path=/trunk/; revision=22432
2009-03-01 07:33:11 +00:00
7ab372c6ca Make gtk-doc pick up deprecation notes
svn path=/trunk/; revision=22426
2009-02-28 19:26:14 +00:00
03879f4c1f Avoid warnings
svn path=/trunk/; revision=22424
2009-02-28 06:32:27 +00:00
d65c585c28 Keep popups on the right screen. Pointed out by Morten Welinder
* gtk/gtkentrycompletion.c:
        * gtk/gtknotebook.c: Keep popups on the right screen.
        Pointed out by Morten Welinder


svn path=/trunk/; revision=22423
2009-02-28 06:13:58 +00:00
d0e7f5889e Bug 573069 – Gdk-CRITICAL warnings with Gtk 2.14 when dragging
GtkNotebook tabs

        * gtk/gtkwidget.c (_gtk_widget_synthesize_crossing): Be a little
        more careful when navigating up the parent chain.

        * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): Reset the
        pointer window thats stored on the screen when it is destroyed.


svn path=/trunk/; revision=22420
2009-02-28 05:24:07 +00:00
3a8c0e370b Handle widget being NULL. Pointed out by Wouter Bolsterlee.
* gtk/gtkpaned.c (get_child_panes): Handle widget being NULL.
        Pointed out by Wouter Bolsterlee.


svn path=/trunk/; revision=22419
2009-02-28 00:52:59 +00:00
08db83d2ac Don't leak a GtkRecentInfo. Found by Tommi Rantala
* gtk/gtkrecentchooserdefault.c (copy_activated_cb): Don't leak
        a GtkRecentInfo. Found by Tommi Rantala



svn path=/trunk/; revision=22418
2009-02-28 00:22:15 +00:00
b475130e4f Copy the right string. Pointed out by Tommi Rantala
* gtk/gtkiconview.c
        (gtk_icon_view_item_accessible_image_set_image_description): Copy
        the right string. Pointed out by Tommi Rantala


svn path=/trunk/; revision=22417
2009-02-28 00:15:01 +00:00
bb883db776 Bug 573383 – GtkMountOperation fixes for ask_password()
2009-02-27  David Zeuthen  <davidz@redhat.com>

	Bug 573383 – GtkMountOperation fixes for ask_password()

	* gtk/gtkmountoperation.c (gtk_mount_operation_ask_password):
	Split the message from GMountOperation into primary/secondary like
	we also do in gtk_mount_operation_ask_question()


svn path=/trunk/; revision=22415
2009-02-27 21:03:47 +00:00
f6eb9d4269 Bug 573383 – Setting a textview's buffer to NULL doesn't do a complete
2009-02-27  Michael Natterer  <mitch@imendio.com>

	Bug 573383 – Setting a textview's buffer to NULL doesn't do a
	complete job

	* gtk/gtktextview.c (gtk_text_view_set_buffer): always set
	text_view->layout's buffer, also if it's NULL.


svn path=/trunk/; revision=22414
2009-02-27 16:21:40 +00:00
009542c192 Bug 572904 – GtkRadioAction broken in trunk
Bug 572904 – GtkRadioAction broken in trunk

	* gtk/gtkradioaction.c: When setting non active state always
	notify the action's active state (this prevents toggle type proxies
	used with radio actions from deactivating when pressed a second time).


svn path=/trunk/; revision=22409
2009-02-26 02:33:42 +00:00
7871e09560 Bug 495320 - GtkRange does not use gdk_event_request_motions
2009-02-25  Xan Lopez  <xan@gnome.org>

        Bug 495320 - GtkRange does not use gdk_event_request_motions

        * gtk/gtkrange.c:
        (gtk_range_motion_notify): Use gdk_event_request_motions to
        request more motion events, as suggested in the docs for widgets
        using motion hints.

svn path=/trunk/; revision=22407
2009-02-25 17:38:53 +00:00
7d8930fdcc Never scroll the places horizontally. Instead, ellipsize the text.
* gtk/gtkfilechooserdefault.c (shortcuts_list_create): Never scroll
        the places horizontally. Instead, ellipsize the text.



svn path=/trunk/; revision=22397
2009-02-24 02:20:15 +00:00
a02ade3737 Added a check to not emit a "changed" signal when an already invalid
2009-02-19  Michael Hasselmann <michaelh@openismus.com>

	* gtk/gtkcombobox.c (gtk_combo_box_set_active_internal):
	Added a check to not emit a "changed" signal when an already
	invalid selection was set to invalid.

svn path=/trunk/; revision=22390
2009-02-22 17:21:37 +00:00
e6f6ee193d Rename gtk_activatable_reset to gtk_activatable_sync_action_properties,
* gtk/gtk.symbols:
        * gtk/gtkactivatable.[hc]: Rename gtk_activatable_reset to
        gtk_activatable_sync_action_properties, since the previous name
        was deemed too generic. Update all implementations.


svn path=/trunk/; revision=22389
2009-02-22 05:20:14 +00:00
632a4f6a7e Add a function to get the default window icon name
svn path=/trunk/; revision=22387
2009-02-20 05:54:53 +00:00
753bebe045 sort functions so their order is more "standard", some cosmetic cleanup
2009-02-19  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmountoperation.c: sort functions so their order is more
	"standard", some cosmetic cleanup (not changing any code).


svn path=/trunk/; revision=22377
2009-02-19 15:15:49 +00:00
9da282480f make the orientation flipping much simpler by using the GtkOrientable
2009-02-19  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkscalebutton.c: make the orientation flipping much simpler
	by using the GtkOrientable features of the involved widgets:

	(gtk_scale_button_init): create the frame, box and scale here,
	they never need to be recreated because they implement GtkOrientable.

	(gtk_scale_button_constructor): remove their construction here.

	(gtk_scale_button_set_orientation): don't destroy and re-create
	anything. Instead, simply set the orientation of the above created
	widgets and fiddle a bit with the "plus" and "minus" buttons'
	packing and the scale's "inverted" state.

	Remove separate internal GtkScaleButtonHScale and
	GtkScaleButtonVScale subclasses and simply have a
	GtkScaleButtonScale directly inherited from GtkScale.


svn path=/trunk/; revision=22375
2009-02-19 15:10:34 +00:00
9a5e06ce7b Require GLib 2.19.7 for GMountOperation::aborted.
* configure.in: Require GLib 2.19.7 for GMountOperation::aborted.

        * gtk/gtkmountoperation.c: Implement GMountOperation::aborted.

svn path=/trunk/; revision=22347
2009-02-17 06:29:21 +00:00
6aee5c0877 Set the object name to the page title. Proposed by Eitan Isaacson
* gtk/gtkassistant.c (gtk_assistant_accessible_ref_child): Set
        the object name to the page title. Proposed by Eitan Isaacson


svn path=/trunk/; revision=22345
2009-02-17 05:49:17 +00:00
b159282465 Set focus when the current page changes. Pointed out by Eitan Isaacson
* gtk/gtkassistant.c (set_current_page): Set focus when the current
        page changes. Pointed out by Eitan Isaacson


svn path=/trunk/; revision=22344
2009-02-17 05:36:12 +00:00
2ca507fbe7 Bug 570824 – [a11y] TreeView is not keyboard (re)focusable after
selecting a cell in a non-sortable column

        * gtk/gtktreeview.c (gtk_tree_view_header_focus): Don't grab
        focus to a header button if it is not focusable. Problem reported
        by Joanmarie Diggs


svn path=/trunk/; revision=22316
2009-02-11 18:53:24 +00:00
a6c640a074 Move the _GtkVolumeButton definition into the header to make it possible
* gtk/gtkvolumebutton.[hc]: Move the _GtkVolumeButton definition
        into the header to make it possible to derive from GtkVoumeButton.
        Reported by Chris Lord.

svn path=/trunk/; revision=22315
2009-02-11 16:31:47 +00:00
4ed4252613 Undeprecate gtk_binding_entry_add_signall
svn path=/trunk/; revision=22314
2009-02-11 15:52:37 +00:00
44fb5dcfc8 Fix rendering of icons in some cases
svn path=/trunk/; revision=22308
2009-02-11 07:25:57 +00:00
6bd8756269 Fix emission of file-set signal
svn path=/trunk/; revision=22307
2009-02-11 06:52:43 +00:00
89c1bb49bd Remove GTK_SIGNAL_ACTION from the file-set signal, that wasn't supposed to
* gtk/gtkfilechooserbutton.c: Remove GTK_SIGNAL_ACTION
        from the file-set signal, that wasn't supposed to have it.


svn path=/trunk/; revision=22306
2009-02-11 06:29:24 +00:00
70b08f1e64 Make the new GtkAction code work with PolicyKit-gnome's use of actions.
* gtk/gtkaction.c (gtk_action_[un]block_activate_from): Block
        the action.

        * gtk/gtkcheckmenuitem.c (gtk_check_menu_item_activatable_reset):
        * gtk/gtktogglebutton. (gtk_toggle_button_activatable_reset):
        * gtk/gtktoggletoolbutton.c (gtk_toggle_tool_button_activatable_reset):
        Work with non-toggle actions without complaining.

        * gtk/gtktoolbutton.c (gtk_tool_button_activatable_update): Updating
        the icon-name should not remove the label.

        * gtk/gtkimagemenuitem.c (activatable_update_icon_name): Also
        update the image when the icon name is set to NULL.


svn path=/trunk/; revision=22290
2009-02-07 03:17:43 +00:00
302cc82c71 Accept a NULL string.
2009-02-06  Matthew Barnes  <mbarnes@redhat.com>

	* gtk/gtklabel.c (gtk_label_set_label): Accept a NULL string.


svn path=/trunk/; revision=22289
2009-02-06 15:49:26 +00:00
4995ea0fcb Set the root coordinates in the event correctly. Patch by Kristian
* gtk/gtktooltip.c (gtk_tooltip_trigger_query): Set the root
        coordinates in the event correctly. Patch by Kristian Rietveld.


svn path=/trunk/; revision=22277
2009-02-04 01:16:35 +00:00
ebb342a246 2.15.3
svn path=/trunk/; revision=22273
2009-02-03 01:55:28 +00:00
03e5467b68 Change the "gtk-fontconfig-timestamp" property from int to uint. Doesn't
2009-02-01  Behdad Esfahbod  <behdad@gnome.org>

        * gtk/gtksettings.c (gtk_settings_class_init): Change the 
        "gtk-fontconfig-timestamp" property from int to uint.  Doesn't affect
        anything in practice, except that  it overflows years later...


svn path=/trunk/; revision=22270
2009-02-01 06:04:12 +00:00