52af9aede6
GtkNotebook: Clarify a switch statement
...
We were intentionally falling through here, this commit
just adds comments to make that explicit.
2012-11-29 23:10:34 -05:00
4557e4d7a5
GtkCellAccessible: Add missing break statements
...
This switch was entirely breakless. Amazing accessibility code,
found by Coverity.
2012-11-29 23:10:34 -05:00
9ba32fec6e
GtkExpander: Clarify a nested switch
...
This code confused Coverity into thinking we were falling through,
when we were not. Add a few explicit breaks to clear that up.
2012-11-29 23:10:34 -05:00
6400eeba35
Add a forgotten break in render_border
...
The GTK_BORDER_STYLE_DOUBLE case was clearly not meant to
fall through to the subsequent cases, yet it did.
Found by Coverity.
2012-11-29 23:10:34 -05:00
a7ed598d37
GtkIconViewAccessible: Fix a copy-paste error
...
Don't access vadjustment after checking hadjustment for
not being NULL. Found by Coverity.
2012-11-29 23:10:34 -05:00
3519226c5a
GtkActionHelper: Fix a copy-paste error
...
The code clearly meant to reset action->active here.
This was found by Coverity.
2012-11-29 23:10:34 -05:00
bf26d46cb2
gtk_css_value_bg_size_equal: actually compare contain values
...
Due to a copy-paste error, the code failed to compare the
contain members of value1 and value2.
This was found by Coverity.
2012-11-29 23:10:34 -05:00
ce6f43a522
Don't check the same crossing mode twice
...
This was broken since commit b2aaa94
2012-11-29 23:10:34 -05:00
5230cfe805
GtkLabel: Fix a pointless expression
...
Clearly, what was meant here was that we create a new attribute
list if either of the input attribute lists are non-NULL.
This was found by Coverity.
2012-11-29 23:10:34 -05:00
256f168525
Obtain the recent files max age setting from xsettings
...
This will help with implementing desktop-wide policy for
retaining of history.
https://bugzilla.gnome.org/show_bug.cgi?id=689047
2012-11-29 23:10:33 -05:00
50acce4074
In the file chooser, use a proper apostrophe rather than a prime mark (tick mark)
...
https://bugzilla.gnome.org/show_bug.cgi?id=689012
2012-11-29 11:34:29 -06:00
149de71624
Fix broken function pointer declarations on windows
...
Both flashing a window and setting the window opacity were using
incorrect declarations for function pointers. They were missing the
WINAPI annotation as defined in windows.h. As a result, the stack
could be corrupted when these functions were invoked.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=689235
(cherry picked from commit 5637ef1f97ee46666c97707ed7f6bae459007163)
2012-11-29 15:07:42 +01:00
709f12b9ac
quartz: add mountain lion as version 8 to enum GdkOSXVersion
...
Also use GDK_OSX_UNSUPPORTED instead of 0 in gdk_quartz_osx_version().
(cherry picked from commit 9644e910a85f97aedf3f5f4fee974229f29766c3)
2012-11-29 15:00:57 +01:00
e2144fbb7e
quartz: call Gestalt() only once per session in gdk_quartz_osx_version()
...
Thanks to Paul Davis for pointing this out.
(cherry picked from commit d6533ffc44d77b42cce7987f249fa481581b7c50)
2012-11-29 15:00:38 +01:00
fd301e7847
Use the ppd groups "name" instead of "text" (bug #687065 )
...
This commit fixes a regression caused by a patch to remove Cups 1.2
ifdefs. This resulted in the "installable options" to appear in the
print dialog.
2012-11-29 10:02:08 +01:00
4d0ca91c72
menuitem: Remove unused variables
2012-11-28 21:15:05 +01:00
29c8420746
tests: Add CSS test for comment detection
...
Tests recent fix.
2012-11-28 21:11:48 +01:00
7f3595a6be
cssparser: Don't detect /*/ as a comment
2012-11-28 21:11:48 +01:00
ea415cd350
menubar: deprecate internal-padding style property
...
https://bugzilla.gnome.org/show_bug.cgi?id=689168
2012-11-28 10:09:16 -05:00
1a79ee4d3e
menubar: add support for CSS padding
...
In preparation for the removal of the internal-padding style property.
https://bugzilla.gnome.org/show_bug.cgi?id=689168
2012-11-28 10:09:16 -05:00
01dc23cdec
menu: deprecate horizontal-padding and vertical-padding
...
https://bugzilla.gnome.org/show_bug.cgi?id=689168
2012-11-28 10:09:16 -05:00
a69619edbc
menuitem: deprecate horizontal-padding style property
...
https://bugzilla.gnome.org/show_bug.cgi?id=689168
2012-11-28 10:09:16 -05:00
d3051ca79c
Assamese translation updated
2012-11-28 13:49:44 +05:30
9ac005abee
Assamese translation updated
2012-11-28 13:47:38 +05:30
943de24211
Updated Slovenian translation
2012-11-26 21:12:00 +01:00
db6d6fcc84
Updated Slovenian translation
2012-11-26 21:07:25 +01:00
941851fc86
docs: Add gtk-doc comment for GtkTreeRowReference
...
https://bugzilla.gnome.org/show_bug.cgi?id=93381
2012-11-26 14:12:14 +00:00
e8659679cd
Sanitize memory handling in cups_request_printer_list_cb
...
gtk+ was trying to display already freed strings, leaking memory,
...I noticed this because I was getting weird blinking characters
as the status of my cups printers, and valgrind confirmed something
was wrong.
https://bugzilla.gnome.org/show_bug.cgi?id=683072
2012-11-26 10:19:31 +01:00
693581250e
i18n: Update British English translation
2012-11-26 09:00:59 +00:00
ceb866dfe6
Bug 595615 — Use proper ellipses
...
Use ‘…’ instead of ‘...’ in translatable strings.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=595615
2012-11-26 08:59:27 +00:00
788f1a0934
Updated POTFILES.skip
2012-11-26 00:46:05 +01:00
6b33ee9c53
reftests: Add reftest for broken fixed height mode
...
https://bugzilla.gnome.org/show_bug.cgi?id=687816
2012-11-26 00:09:35 +01:00
239c631ad3
treeview: Delay computing fixed height
...
In the setter, we only set fixed height mode and queue a revalidation of
the row heights.
https://bugzilla.gnome.org/show_bug.cgi?id=687816
2012-11-26 00:09:35 +01:00
4498ff314e
sizegroup: Use g_hash_table_add()
...
This is the function to use when treating hash tables as a set.
2012-11-25 22:58:19 +01:00
87b351e6e6
styleproperty: Use _gtk_css_initial_value_get()
...
See previous commit(s).
2012-11-25 22:29:14 +01:00
1d805139db
cssvalue: Use _gtk_css_initial_value_get() for the inherit value
...
See previous commit(s).
2012-11-25 22:29:14 +01:00
f204473ee0
cssvalue: Add _gtk_css_initial_value_get()
...
... so we don't bump a refcount whenever we get the initial singleton.
We want to use this function instead of
_gtk_css_style_property_get_initial_value() everywhere where we compute
values, because some initial values may depend on settings soon.
2012-11-25 15:31:59 +01:00
2ab65ef771
izegroup: Improve performance
...
Keep a list of all groups and avoid groups we already handled. Speeds up
GtkToolpalette a lot.
2012-11-25 13:32:21 +01:00
da7a4089fe
widget: Remove an unneeded queue_resize()
...
Resizes are queued via
gtk_widget_propagate_state()
=> gtk_style_context_set_state()
=> gtk_style_context_queue_invalidate()
=> gtk_style_context_validate()
=> _gtk_widget_style_context_invalidated()
so there's no need to queue an extra one.
2012-11-25 04:46:36 +01:00
41486895d5
deprecations: Move files into deprecated/ dir
2012-11-25 04:16:43 +01:00
0862afaded
gtkgradient: Deprecate
2012-11-25 03:47:51 +01:00
fb643c1c12
symboliccolor: Deprecate
...
Symbolic colors are an implementation detail of the CSS engine and have
been superceded by GtkCssColorValue. We don't want them clobbering the
public API. In particular because the only use I could find in the
public API is people using it to shade colors.
2012-11-25 03:43:28 +01:00
df25349d63
themingengine: Do shading with GtkHSLA
...
... instead of with symbolic colors.
2012-11-25 03:34:02 +01:00
9aac4dffc5
hsla: Add _gtk_hsla_shade()
...
We use it in multiple places, so better split it out.
2012-11-25 03:25:15 +01:00
4f9a8e6b3d
symboliccolor: Remove extra includes
...
That header was included in way too many places.
2012-11-25 02:59:15 +01:00
42dc0ea0fd
styleprovider: Change function prototype
...
Make _gtk_style_provider_private_get_color() return a GtkCssValue (a
GtkCssColorValue to be exact) instead of GtkSymbolicColor.
With this, the symbolic color usage inside GTK is minimized.
2012-11-25 02:45:10 +01:00
08ac1504d2
symboliccolor: Implement using GtkCssValue
2012-11-25 02:41:17 +01:00
b8e58015eb
symboliccolor: symbolic color is no longer a CssValue
...
This is not needed anymore, because we have GtkCssColorValue for that
now.
2012-11-25 01:51:18 +01:00
94b80cc774
symboliccolor: Change prototype of function
...
Makes it easier to use the function in the places where it's still used.
2012-11-24 21:56:47 +01:00
5ca35bd5dd
settings: Remove support for color schemes
...
Color schemes were unused and their interaction with CSS3 themes was
undefined. So we decided to remove support for them.
This commit does that.
2012-11-24 21:27:33 +01:00
