a3f1e02b9b
gtk: Stop using deprecated pango api
2019-01-31 14:07:28 -05:00
c23e07f60f
gtk: Add a copy of some deprecated pango api
...
We use pango_find_base_dir() in a few places, and
this api has been deprecated.
2019-01-31 14:07:28 -05:00
3da6497d9f
gdk: Stop using deprecated pango api
2019-01-31 14:07:28 -05:00
998314b8ba
gdk: Add a copy of pango_unichar_direction
...
This api has been deprecated in pango.
2019-01-31 14:07:28 -05:00
417c57e5b7
Add an explicit fribidi dependency
...
We already depend on it indirectly, via pango.
And we will use it to replace deprecated pango apis.
2019-01-31 14:07:28 -05:00
99d013994b
quartz: release linked list as we process it
...
Rather than performing the list iteration and the list free as separate
steps, free the list link while iterating.
2019-01-31 17:55:19 +01:00
ff4dcf5fa4
HighContrast: Add style for overflow buttons
...
Add missing style for overflow buttons located on scrollable dropdown
menus.
2019-01-31 16:43:39 +01:00
a7ea8248ce
HighContrast: Add menu padding
...
Add 1px padding to menus, to prevent menuitems and overflow buttons
overlapping with menu's border.
2019-01-31 16:43:30 +01:00
7395160e5b
Adwaita: Improve dropdown menu buttons
...
Improve overflow arrow buttons drawing on a scrollable dropdown menu:
reduce top button's margin-top to match size of a bottom button, add
margin-top for bottom button to compensate bottom margin (otherwise
button overlaps with menu content).
Closes https://gitlab.gnome.org/GNOME/gtk/issues/1539
2019-01-31 16:42:32 +01:00
cfad43b80d
macOS: Fix bug that entry cannot press and hold a key to input accented character.
...
There're two issues in GdkQuartzView's NSTextInputClient implementation
causes this bug.
1. The -(NSRange)selectedRange should not return [NSNotFound, 0] if
there's no selection. The accented character window will not show
if returned NSRange's location is NSNotFound. Instead of that, the
NSRange's location should be the caret position in the text input
buffer.
2. The accented character window will invoke
-(void)insertText:replacementRange: with non-empty replacement
range, to replace non-accented character with accented character
after user select it from accented character window. This case is
not implemented in original code. Here I use another gobject data
to pass the information to input module and convert it into
'delete-surrounding' event.
Besides these, there's another bug cause gtk_im_context_filter_keypress()
return wrong value while user press and hold a key. When user press
and hold a key, the accented character window will consume the
repeating key down event. Is this case, gtk_im_context_filter_keypress()
should return TRUE, indicate the key press is filtered by input
method module. But it will return FALSE because
gtk_im_context_filter_keypress() assume that every key press event
will generate some text from input method module.
Fixes #1618
2019-01-30 22:07:23 -08:00
2c15e59c16
Merge branch 'issue-1631' into 'gtk-3-24'
...
switch: Take gadget clip into account
See merge request GNOME/gtk!543
2019-01-30 19:20:46 +00:00
0a9aa768d8
switch: Take gadget clip into account
...
Now that we've switched the on and off states to gadgets, we need to
ensure that the widget's clip take into account the clip of every
gadget.
Fixes #1631
2019-01-30 18:41:24 +00:00
a0129f556b
Merge branch 'get-timings-transfer-3' into 'gtk-3-24'
...
g-i: Add transfer none annotations for frame clock timings getters
See merge request GNOME/gtk!512
2019-01-29 10:36:19 +00:00
64c28f40a0
Merge branch 'adwaita-osd-spinbutton-entry-fix-3-24' into 'gtk-3-24'
...
Horizontal OSD spinbutton entry fix
See merge request GNOME/gtk!331
2019-01-29 09:40:51 +00:00
b522c59880
Adwaita: switches with no labels
...
- it's less busy and still clearer without the label
- It may be right that color alone is a poor differentiator,
but labels do still exist for the accessible theme.
2019-01-28 12:34:48 +01:00
519ff2ac6a
Merge branch 'fix-button-icon-position' into 'wip/jimmac/adwaita-3-32'
...
Adwaita: Fix wrong icon position in some buttons
See merge request GNOME/gtk!533
2019-01-28 11:57:42 +01:00
6f1e611c3b
Merge branch 'wip/jimmac/adwaita-3-32' into 'fix-button-icon-position'
...
# Conflicts:
# gtk/theme/Adwaita/_common.scss
# gtk/theme/Adwaita/gtk-contained-dark.css
# gtk/theme/Adwaita/gtk-contained.css
2019-01-28 10:46:48 +00:00
17ab084f28
Adwaita: fix padding and rounding on menubar submenus
2019-01-28 11:43:54 +01:00
4d08be5d03
Adwaita: selection mode labels
...
- when not in focus, make sure labels are legible
but flat.
Fixes issue #1562
2019-01-28 11:43:54 +01:00
b6082efdc0
Adwaita: use neutral greys for dark
...
- the hint of warm color is too subtle to even notice for most people
Fixes issue #1589
2019-01-28 11:43:54 +01:00
aa1e565fb5
Adwaita: darken dark mode
...
- match lightness of the old theme.
Fixes issue #1605
2019-01-28 11:43:54 +01:00
fec7874d0e
Reduce vertical menu padding from 8px to 4px
2019-01-28 11:43:54 +01:00
72010d7894
Adwaita: do show labels on switches
...
- now that we have I/O and not ON/OFF
2019-01-28 11:43:54 +01:00
25bf546eee
Adwaita: headerbar buttons separators
...
- make the border more aparent for when two :active buttons
are neighboring (Builder panel toggles).
2019-01-28 11:43:54 +01:00
24e6995d92
Adwaita: headerbar togglebuttons backdrop
...
- redefine overriden backdrop state
2019-01-28 11:43:54 +01:00
079aef0b8d
Adwaita: expand the headerbar button styling
...
- it's not just stackswitcher buttons, apparently. Builder uses
togglebuttons.
2019-01-28 11:43:54 +01:00
7da52e5255
Adwaita: don't do undershoot
...
- No need to indicate overflown content. No other OS does this.
fixes #1591
2019-01-28 11:43:54 +01:00
568ea3b7f9
Adwaita: update image assets
...
- mainly sliders
fixes #1590
2019-01-28 11:43:54 +01:00
0f764eb16e
Adwaita: make switcher buttons' active darker
...
- create more contrast against the headerbar background without lowering
contrast with the label and border.
- top border shaded for extra aid of the state being pressed (in the two button scenatio)
Addesses issue #1588
2019-01-28 11:43:54 +01:00
de1f87b1f4
Adwaita: tone down the window roundounding
2019-01-28 11:43:54 +01:00
86acf52032
Adwaita: button-alt toning down
...
- checkboxes and radios were too 3d
2019-01-28 11:43:54 +01:00
c514cf75e4
Adwaita: darker active state for buttons
2019-01-28 11:43:54 +01:00
5c67d7d7b1
Adwaita: selection dropdown vcentering
...
- somewhat odd off-center vertical centering on the selection
filter popover
2019-01-28 11:43:54 +01:00
5a7fc7e352
Adwaita: remove chin from circular buttons
...
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:54 +01:00
3b81932981
Adwaita: colored/darker button tweaks
...
- less contrasty border on colored buttons
- tone down edge highlight on darker buttons
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:54 +01:00
71cfb8e077
Adwaita: rounding of popovers
...
- you give Tobias a finger and he grbs the whole arm
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
37c47d70f6
Adwaita: no hardsh bottom shading
...
- felt like an inset shadow in some situations
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
0e95206697
Adwaita: non-square buttons rejiggle
...
- rather than squishing vertically, stretch horizontally.
The previous method made some non-button widgets odd looking.
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
99a48fe7e7
Adwaita: headerbar radius
...
- last occurence of window border radius, I swear :)
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
60230b4653
Adwaita: window radius
...
- found the lapo magic to fix the non-csd corner anti-aliasing
- csd headerbars to do
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
9b820cde49
Adwaita: a *hair* lighter shadows
...
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
15bd30d222
Adwaita: move button shadows down a pixel
...
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
8d205fd518
Adwaita: slightly larger radius for windows
...
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
b06712d3c9
Adwaita: modals also need the rame rounding
...
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
83a45d3bb0
Adwaita: increase window radius
...
- to match the button radius, increase the windwo border radius
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
aa1593505d
Adwaita: no 'chin' for buttons
...
- box-shadow doesn't mix with the chin
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
501bce47ea
Adwaita: buttons cast a shadow
...
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
585569f66e
Adwaita: squash buttons as per reqs
...
- not a big fan of this one
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
5541152724
Adwaita: hide close separator
...
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00
1c5071c346
Adwaita: round buttons
...
- Grumpy old man commits the first thing he dislikes on
Allan's proposal.
https://gitlab.gnome.org/GNOME/gtk/issues/1510
2019-01-28 11:43:53 +01:00