From fade865f80bc9f6389566b7b6f84feef6dd8617d Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Mon, 13 Dec 2004 20:04:40 +0000 Subject: [PATCH] Reintroduce the reverted change, since it is necessary to prevent lost 2004-12-13 Matthias Clasen * gtk/gtkmenuitem.c (gtk_real_menu_item_select): Reintroduce the reverted change, since it is necessary to prevent lost submenus. But make it work for torn-off menus as well. --- ChangeLog | 4 ++++ ChangeLog.pre-2-10 | 4 ++++ ChangeLog.pre-2-6 | 4 ++++ ChangeLog.pre-2-8 | 4 ++++ gtk/gtkmenuitem.c | 4 +++- 5 files changed, 19 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 926249eabf..631f4cbf43 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2004-12-13 Matthias Clasen + * gtk/gtkmenuitem.c (gtk_real_menu_item_select): Reintroduce + the reverted change, since it is necessary to prevent lost + submenus. But make it work for torn-off menus as well. + * gtk/gtktearoffmenuitem.c (tearoff_state_changed): Fix the signature to avoid overwriting a pspec. diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 926249eabf..631f4cbf43 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,5 +1,9 @@ 2004-12-13 Matthias Clasen + * gtk/gtkmenuitem.c (gtk_real_menu_item_select): Reintroduce + the reverted change, since it is necessary to prevent lost + submenus. But make it work for torn-off menus as well. + * gtk/gtktearoffmenuitem.c (tearoff_state_changed): Fix the signature to avoid overwriting a pspec. diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index 926249eabf..631f4cbf43 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,5 +1,9 @@ 2004-12-13 Matthias Clasen + * gtk/gtkmenuitem.c (gtk_real_menu_item_select): Reintroduce + the reverted change, since it is necessary to prevent lost + submenus. But make it work for torn-off menus as well. + * gtk/gtktearoffmenuitem.c (tearoff_state_changed): Fix the signature to avoid overwriting a pspec. diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index 926249eabf..631f4cbf43 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,5 +1,9 @@ 2004-12-13 Matthias Clasen + * gtk/gtkmenuitem.c (gtk_real_menu_item_select): Reintroduce + the reverted change, since it is necessary to prevent lost + submenus. But make it work for torn-off menus as well. + * gtk/gtktearoffmenuitem.c (tearoff_state_changed): Fix the signature to avoid overwriting a pspec. diff --git a/gtk/gtkmenuitem.c b/gtk/gtkmenuitem.c index db2dbcbc3a..3038c42f7a 100644 --- a/gtk/gtkmenuitem.c +++ b/gtk/gtkmenuitem.c @@ -838,7 +838,9 @@ gtk_real_menu_item_select (GtkItem *item) menu_item = GTK_MENU_ITEM (item); - if (menu_item->submenu) + if (menu_item->submenu && + (!GTK_WIDGET_MAPPED (menu_item->submenu) || + GTK_MENU (menu_item->submenu)->tearoff_active)) { gint popup_delay;