From f8f74b59e38b402bf78ac8b454a8f26e839f8349 Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Thu, 18 Sep 2014 13:48:35 +0200 Subject: [PATCH] scalebutton: Invert smooth scroll dy when adding to the current value On regular scrolling (ie. not natural scrolling), positive deltas in the Y axis (downwards) should actually move the value towards the adjustment minimum value to be more intuitive. This also makes the scrolling directions match between the button and the popped up scale. https://bugzilla.gnome.org/show_bug.cgi?id=736830 --- gtk/gtkscalebutton.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/gtkscalebutton.c b/gtk/gtkscalebutton.c index 24976b0acc..f797399fa4 100644 --- a/gtk/gtkscalebutton.c +++ b/gtk/gtkscalebutton.c @@ -794,7 +794,7 @@ gtk_scale_button_scroll (GtkWidget *widget, } else if (event->direction == GDK_SCROLL_SMOOTH) { - d += event->delta_y * gtk_adjustment_get_step_increment (adjustment); + d -= event->delta_y * gtk_adjustment_get_step_increment (adjustment); d = CLAMP (d, gtk_adjustment_get_lower (adjustment), gtk_adjustment_get_upper (adjustment)); }