callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't use gdk_spawn

Browse Source 
Replace the sole use of gdk_spawn in GTK+ by GAppInfo.
This commit is contained in:
Matthias Clasen
2010-12-15 02:38:43 -05:00
parent 536a7c8abb
commit ef85f112da
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
gtk/gtkprintoperation-unix.c
View File

@ -201,8 +201,8 @@ _gtk_print_operation_platform_backend_launch_preview (GtkPrintOperation *op,
GtkWindow *parent, GtkWindow *parent,
const gchar *filename) const gchar *filename)
{ {
gint argc; GAppInfo *appinfo;
gchar **argv; GAppLaunchContext *context;
gchar *cmd; gchar *cmd;
gchar *preview_cmd; gchar *preview_cmd;
GtkSettings *settings; GtkSettings *settings;
@ -276,7 +276,11 @@ _gtk_print_operation_platform_backend_launch_preview (GtkPrintOperation *op,
quoted_filename = g_shell_quote (filename); quoted_filename = g_shell_quote (filename);
quoted_settings_filename = g_shell_quote (settings_filename); quoted_settings_filename = g_shell_quote (settings_filename);
cmd = shell_command_substitute_file (preview_cmd, quoted_filename, quoted_settings_filename, &filename_used, &settings_used); cmd = shell_command_substitute_file (preview_cmd, quoted_filename, quoted_settings_filename, &filename_used, &settings_used);
g_shell_parse_argv (cmd, &argc, &argv, &error);
appinfo = g_app_info_create_from_commandline (cmd,
"Print Preview",
G_APP_INFO_CREATE_NONE,
&error);
g_free (preview_cmd); g_free (preview_cmd);
g_free (quoted_filename); g_free (quoted_filename);
@ -286,9 +290,12 @@ _gtk_print_operation_platform_backend_launch_preview (GtkPrintOperation *op,
if (error != NULL) if (error != NULL)
goto out; goto out;
gdk_spawn_on_screen (screen, NULL, argv, NULL, G_SPAWN_SEARCH_PATH, NULL, NULL, NULL, &error); context = gdk_display_get_app_launch_context (gdk_screen_get_display (screen));
gdk_app_launch_context_set_screen (GDK_APP_LAUNCH_CONTEXT (context), screen);
g_app_info_launch (appinfo, NULL, context, &error);
g_strfreev (argv); g_object_unref (context);
g_object_unref (appinfo);
if (error != NULL) if (error != NULL)
{ {
@ -311,9 +318,9 @@ _gtk_print_operation_platform_backend_launch_preview (GtkPrintOperation *op,
else else
g_error_free (error); g_error_free (error);
filename_used = FALSE; filename_used = FALSE;
settings_used = FALSE; settings_used = FALSE;
} }
if (!filename_used) if (!filename_used)
g_unlink (filename); g_unlink (filename);
@ -323,7 +330,7 @@ _gtk_print_operation_platform_backend_launch_preview (GtkPrintOperation *op,
if (fd > 0) if (fd > 0)
close (fd); close (fd);
if (key_file) if (key_file)
g_key_file_free (key_file); g_key_file_free (key_file);
g_free (data); g_free (data);