Fix module blacklisting

The handling of the module lists is a bit confusing here. There is
a global list that is populated with initial modules from GTK_MODULES,
and then there is a second list that is suppposed to hold the modules
loaded from the gtk-modules xsetting, which we attach to the GtkSettings
object. The blacklisting caused us to put the wrong modules into the
second list, and mess up the module refcounts, eventually double-freeing
memory when the setting changes repeatedly.

https://bugzilla.gnome.org/show_bug.cgi?id=659966
This commit is contained in:
Matthias Clasen
2011-09-23 16:25:33 -04:00
parent bd8e9085ab
commit dd82b30433

View File

@ -295,7 +295,9 @@ load_module (GSList *module_list,
info->ref_count++; info->ref_count++;
success = TRUE; success = TRUE;
break;
} }
info = NULL;
} }
if (!success) if (!success)