From d5465be9920e714c70916cc7d1b19f15fc195e6e Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Wed, 17 Jul 2019 17:23:13 +0100 Subject: [PATCH] Disable accessibility-dump test (aka a11ytests) It works by comparing a dump of the a11y widget tree with a known-good version, but that seems to vary unpredictably according to some unknown factor. Upstream's CI currently disables all the a11y tests, so we can't expect this to be reliable. --- debian/changelog | 6 ++++ ...ccessibility-dump-aka-a11ytests-test.patch | 34 +++++++++++++++++++ debian/patches/series | 1 + 3 files changed, 41 insertions(+) create mode 100644 debian/patches/Disable-accessibility-dump-aka-a11ytests-test.patch diff --git a/debian/changelog b/debian/changelog index ba1b729c0e..491a127e4f 100644 --- a/debian/changelog +++ b/debian/changelog @@ -14,6 +14,12 @@ gtk+3.0 (3.24.10-1) UNRELEASED; urgency=medium * d/p/docs-Add-gtk_file_chooser_add_choice-and-related-function.patch, d/p/Fix-a-string-leak.patch: Add post-release fixes from upstream gtk-3-24 branch + * d/p/Disable-accessibility-dump-aka-a11ytests-test.patch: + Disable accessibility-dump test (aka a11ytests). + It works by comparing a dump of the a11y widget tree with a known-good + version, but that seems to vary unpredictably according to some unknown + factor. Upstream's CI currently disables all the a11y tests, so we can't + expect this to be reliable. -- Simon McVittie Wed, 17 Jul 2019 10:00:01 +0100 diff --git a/debian/patches/Disable-accessibility-dump-aka-a11ytests-test.patch b/debian/patches/Disable-accessibility-dump-aka-a11ytests-test.patch new file mode 100644 index 0000000000..7ce0066dc1 --- /dev/null +++ b/debian/patches/Disable-accessibility-dump-aka-a11ytests-test.patch @@ -0,0 +1,34 @@ +From: Simon McVittie +Date: Wed, 17 Jul 2019 17:20:23 +0100 +Subject: Disable accessibility-dump (aka a11ytests) test + +This test seems to be unreliable, with its results depending on +unknown environmental factors. Upstream disable it for CI purposes, +so we should probably do the same. + +Forwarded: no +--- + testsuite/a11y/Makefile.am | 3 --- + 1 file changed, 3 deletions(-) + +diff --git a/testsuite/a11y/Makefile.am b/testsuite/a11y/Makefile.am +index 73519e9..9b475b4 100644 +--- a/testsuite/a11y/Makefile.am ++++ b/testsuite/a11y/Makefile.am +@@ -28,8 +28,6 @@ TESTS_ENVIRONMENT = \ + GTK_CSD=1 \ + G_ENABLE_DIAGNOSTIC=0 + +-TEST_PROGS += accessibility-dump +- + TEST_PROGS += tree-performance + + TEST_PROGS += text +@@ -89,7 +87,6 @@ testdata = \ + $(NULL) + + test_in_files = \ +- a11ytests.test.in \ + a11ychildren.test.in \ + a11ytree.test.in \ + a11yvalue.test.in \ diff --git a/debian/patches/series b/debian/patches/series index 3bea9c153d..6daf48e674 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -9,3 +9,4 @@ reftest-known-fail.patch Don-t-test-default-constructed-GdkPixbuf-properties.patch gdk-Generate-gdkenumtypes.-ch-in-the-builddir.patch gdk-Don-t-distribute-generated-files-in-tarballs.patch +Disable-accessibility-dump-aka-a11ytests-test.patch