From ce2d9b430c78650c8606b7e704f34d8f1b63059e Mon Sep 17 00:00:00 2001 From: Ryan Lortie Date: Fri, 15 Nov 2013 09:32:19 -0500 Subject: [PATCH] defaultvalue test: ignore show-desktop Ignore the "show-desktop" property on GtkPlacesSidebar for the defaultvalue test. Currently, "make check" is passing because it runs the test under a xvfb with no XSETTINGS provider, so we see the Gtk default value. No matter what we set the default value to in Gtk, however, there will be some desktop environment in which someone running the installed test outside of an xvfb will get the wrong result. Best to ignore it. https://bugzilla.gnome.org/show_bug.cgi?id=712302 --- testsuite/gtk/defaultvalue.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/testsuite/gtk/defaultvalue.c b/testsuite/gtk/defaultvalue.c index 1d9c2af76f..bdb0bb67d4 100644 --- a/testsuite/gtk/defaultvalue.c +++ b/testsuite/gtk/defaultvalue.c @@ -320,6 +320,11 @@ G_GNUC_END_IGNORE_DEPRECATIONS strcmp (pspec->name, "resize-grip-visible") == 0) continue; + /* show-desktop depends on desktop environment */ + if (g_type_is_a (type, GTK_TYPE_PLACES_SIDEBAR) && + strcmp (pspec->name, "show-desktop") == 0) + continue; + if (g_test_verbose ()) g_print ("Property %s.%s\n", g_type_name (pspec->owner_type),