Merging release_1_0 changes into the main tree.

-timj


Tue Mar 10 14:24:09 1998  Owen Taylor  <owt1@cornell.edu>

        * gtk/gtkselection.c (gtk_selection_clear): Make the return
          result reflect whether the clear event was out of data.

        * gtk/gtkeditable.c: Ignore out of date selection clear
          events.

        * gtk/gtkentry.c gtk/gtktext.c: Don't synthesize releases
          on [2/3]BUTTON presses, since we get the normal click as well.

          Claim the selection when selecting words/lines.

Tue Mar 10 13:34:29 1998  Owen Taylor  <owt1@cornell.edu>

        * gtk/gtkrange.c (gtk_range_default_[vh]trough_click):
          Take forward/back step arrows into account when computing
          position for middle button clicks.

        * gtk/gtktext.c gtk/gtkentry.c:
          - Fixes for deleting characters (don't subtract guints and get
            negative numbers!)
          - Reset cursor_virtual_x when moving by words and lines
          - Extra sanity checks
          - Fix to gtk_text_get_chars
                 (from Tony Gale <gale@daedalus.dera.gov.uk>)
This commit is contained in:
Owen Taylor
1998-03-10 22:57:26 +00:00
committed by Tim Janik
parent 120df3b8b7
commit cb6412978c
12 changed files with 293 additions and 57 deletions

View File

@ -97,8 +97,10 @@ static void gtk_delete_forward_word (GtkEntry *entry);
static void gtk_delete_backward_word (GtkEntry *entry);
static void gtk_delete_line (GtkEntry *entry);
static void gtk_delete_to_line_end (GtkEntry *entry);
static void gtk_select_word (GtkEntry *entry);
static void gtk_select_line (GtkEntry *entry);
static void gtk_select_word (GtkEntry *entry,
guint32 time);
static void gtk_select_line (GtkEntry *entry,
guint32 time);
static void gtk_entry_set_selection (GtkEditable *editable,
@ -705,7 +707,7 @@ gtk_entry_button_press (GtkWidget *widget,
entry = GTK_ENTRY (widget);
editable = GTK_EDITABLE (widget);
if (entry->button)
if (entry->button && (event->type == GDK_BUTTON_PRESS))
{
GdkEventButton release_event = *event;
@ -736,11 +738,11 @@ gtk_entry_button_press (GtkWidget *widget,
break;
case GDK_2BUTTON_PRESS:
gtk_select_word (entry);
gtk_select_word (entry, event->time);
break;
case GDK_3BUTTON_PRESS:
gtk_select_line (entry);
gtk_select_line (entry, event->time);
break;
default:
@ -1424,9 +1426,12 @@ gtk_entry_insert_text (GtkEditable *editable,
new_text_length = entry->text_max_length - entry->text_length;
/* Don't insert anything, if there was nothing to insert. */
if (new_text_length <= 0)
if (new_text_length == 0)
return;
if (new_text_length < 0)
new_text_length = strlen (new_text);
start_pos = *position;
end_pos = start_pos + new_text_length;
last_pos = new_text_length + entry->text_length;
@ -1523,14 +1528,19 @@ gtk_entry_get_chars (GtkEditable *editable,
start_pos = MIN(entry->text_length, start_pos);
end_pos = MIN(entry->text_length, end_pos);
c = entry->text[end_pos];
entry->text[end_pos] = '\0';
retval = g_strdup (&entry->text[start_pos]);
entry->text[end_pos] = c;
return retval;
if (start_pos <= end_pos)
{
c = entry->text[end_pos];
entry->text[end_pos] = '\0';
retval = g_strdup (&entry->text[start_pos]);
entry->text[end_pos] = c;
return retval;
}
else
return NULL;
}
static void
@ -1767,7 +1777,7 @@ gtk_delete_to_line_end (GtkEntry *entry)
}
static void
gtk_select_word (GtkEntry *entry)
gtk_select_word (GtkEntry *entry, guint32 time)
{
gint start_pos;
gint end_pos;
@ -1781,16 +1791,21 @@ gtk_select_word (GtkEntry *entry)
gtk_move_forward_word (entry);
end_pos = editable->current_pos;
editable->has_selection = TRUE;
gtk_entry_set_selection (editable, start_pos, end_pos);
gtk_editable_claim_selection (editable, start_pos != end_pos, time);
}
static void
gtk_select_line (GtkEntry *entry)
gtk_select_line (GtkEntry *entry, guint32 time)
{
GtkEditable *editable;
editable = GTK_EDITABLE (entry);
editable->has_selection = TRUE;
gtk_entry_set_selection (editable, 0, entry->text_length);
gtk_editable_claim_selection (editable, entry->text_length != 0, time);
editable->current_pos = editable->selection_end_pos;
}