gdkwindow: Don't bother with a return parameter for queue_antiexpose

Standard refcounting works perfectly well. Don't give us the opportunity
for more memory leaks.
This commit is contained in:
Jasper St. Pierre 2014-06-21 18:03:56 -04:00
parent dcef61ac44
commit c767d504c5
9 changed files with 15 additions and 26 deletions

View File

@ -1495,11 +1495,10 @@ _gdk_broadway_display_after_process_all_updates (GdkDisplay *display)
{ {
} }
static gboolean static void
gdk_broadway_window_queue_antiexpose (GdkWindow *window, gdk_broadway_window_queue_antiexpose (GdkWindow *window,
cairo_region_t *area) cairo_region_t *area)
{ {
return FALSE;
} }
guint32 guint32

View File

@ -542,11 +542,10 @@ gdk_offscreen_window_get_geometry (GdkWindow *window,
} }
} }
static gboolean static void
gdk_offscreen_window_queue_antiexpose (GdkWindow *window, gdk_offscreen_window_queue_antiexpose (GdkWindow *window,
cairo_region_t *area) cairo_region_t *area)
{ {
return FALSE;
} }
/** /**

View File

@ -3333,7 +3333,6 @@ static void
gdk_window_process_updates_internal (GdkWindow *window) gdk_window_process_updates_internal (GdkWindow *window)
{ {
GdkWindowImplClass *impl_class; GdkWindowImplClass *impl_class;
gboolean save_region = FALSE;
GdkRectangle clip_box; GdkRectangle clip_box;
GdkWindow *toplevel; GdkWindow *toplevel;
@ -3375,11 +3374,11 @@ gdk_window_process_updates_internal (GdkWindow *window)
cairo_region_get_extents (update_area, &clip_box); cairo_region_get_extents (update_area, &clip_box);
expose_region = cairo_region_copy (update_area); expose_region = cairo_region_copy (update_area);
impl_class = GDK_WINDOW_IMPL_GET_CLASS (window->impl); impl_class = GDK_WINDOW_IMPL_GET_CLASS (window->impl);
save_region = impl_class->queue_antiexpose (window, update_area); impl_class->queue_antiexpose (window, update_area);
impl_class->process_updates_recurse (window, expose_region); impl_class->process_updates_recurse (window, expose_region);
cairo_region_destroy (expose_region); cairo_region_destroy (expose_region);
} }
if (!save_region)
cairo_region_destroy (update_area); cairo_region_destroy (update_area);
} }

View File

@ -126,11 +126,9 @@ struct _GdkWindowImplClass
/* Called before processing updates for a window. This gives the windowing /* Called before processing updates for a window. This gives the windowing
* layer a chance to save the region for later use in avoiding duplicate * layer a chance to save the region for later use in avoiding duplicate
* exposes. The return value indicates whether the function has a saved * exposes.
* the region; if the result is TRUE, then the windowing layer is responsible
* for destroying the region later.
*/ */
gboolean (* queue_antiexpose) (GdkWindow *window, void (* queue_antiexpose) (GdkWindow *window,
cairo_region_t *update_area); cairo_region_t *update_area);
/* Called to do the windowing system specific part of gdk_window_destroy(), /* Called to do the windowing system specific part of gdk_window_destroy(),

View File

@ -2057,11 +2057,10 @@ gdk_window_quartz_set_static_gravities (GdkWindow *window,
return FALSE; return FALSE;
} }
static gboolean static void
gdk_quartz_window_queue_antiexpose (GdkWindow *window, gdk_quartz_window_queue_antiexpose (GdkWindow *window,
cairo_region_t *area) cairo_region_t *area)
{ {
return FALSE;
} }
static void static void

View File

@ -1335,11 +1335,10 @@ gdk_window_wayland_set_static_gravities (GdkWindow *window,
return TRUE; return TRUE;
} }
static gboolean static void
gdk_wayland_window_queue_antiexpose (GdkWindow *window, gdk_wayland_window_queue_antiexpose (GdkWindow *window,
cairo_region_t *area) cairo_region_t *area)
{ {
return FALSE;
} }
static void static void

View File

@ -3238,7 +3238,7 @@ gdk_win32_window_get_shape (GdkWindow *window)
return NULL; return NULL;
} }
static gboolean static void
_gdk_win32_window_queue_antiexpose (GdkWindow *window, _gdk_win32_window_queue_antiexpose (GdkWindow *window,
cairo_region_t *area) cairo_region_t *area)
{ {
@ -3251,8 +3251,6 @@ _gdk_win32_window_queue_antiexpose (GdkWindow *window,
ValidateRgn (GDK_WINDOW_HWND (window), hrgn); ValidateRgn (GDK_WINDOW_HWND (window), hrgn);
DeleteObject (hrgn); DeleteObject (hrgn);
return FALSE;
} }
static void static void

View File

@ -212,16 +212,14 @@ gdk_window_queue (GdkWindow *window,
g_queue_push_tail (display_x11->translate_queue, item); g_queue_push_tail (display_x11->translate_queue, item);
} }
gboolean void
_gdk_x11_window_queue_antiexpose (GdkWindow *window, _gdk_x11_window_queue_antiexpose (GdkWindow *window,
cairo_region_t *area) cairo_region_t *area)
{ {
GdkWindowQueueItem *item = g_new (GdkWindowQueueItem, 1); GdkWindowQueueItem *item = g_new (GdkWindowQueueItem, 1);
item->antiexpose_area = area; item->antiexpose_area = cairo_region_reference (area);
gdk_window_queue (window, item); gdk_window_queue (window, item);
return TRUE;
} }
void void

View File

@ -126,7 +126,7 @@ void _gdk_x11_window_change_property (GdkWindow *window,
void _gdk_x11_window_delete_property (GdkWindow *window, void _gdk_x11_window_delete_property (GdkWindow *window,
GdkAtom property); GdkAtom property);
gboolean _gdk_x11_window_queue_antiexpose (GdkWindow *window, void _gdk_x11_window_queue_antiexpose (GdkWindow *window,
cairo_region_t *area); cairo_region_t *area);
void _gdk_x11_window_translate (GdkWindow *window, void _gdk_x11_window_translate (GdkWindow *window,
cairo_region_t *area, cairo_region_t *area,