callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

label: Skip updating link state if we have no layout

Browse Source 
This can happen whenever the ::activate-link handler sets different
markup on the label, causing all links to be recreated. In this case,
the GtkLabelLink* passed to emit_activate_link is garbage after the
g_signal_emit call and we shouldn't try to do anything with it.

Fixes #1498
This commit is contained in:
Timm Bäder
2019-01-11 17:46:12 +01:00
committed by Matthias Clasen
parent 86d38e6ae2
commit bfe0f7dd4d
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gtk/gtklabel.c
View File

@ -6755,6 +6755,11 @@ emit_activate_link (GtkLabel *label,
GtkStateFlags state; GtkStateFlags state;
g_signal_emit (label, signals[ACTIVATE_LINK], 0, link->uri, &handled); g_signal_emit (label, signals[ACTIVATE_LINK], 0, link->uri, &handled);
/* signal handler might have invalidated the layout */
if (!priv->layout)
return;
if (handled && priv->track_links && !link->visited && if (handled && priv->track_links && !link->visited &&
priv->select_info && priv->select_info->links) priv->select_info && priv->select_info->links)
{ {