callisto-debian/gtk3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

headerbar: fix leak of start_box/end_box

Browse Source 
gtk_widget_destroy() removes widgets from their container.  However
_internal_ widgets must be unref'ed using gtk_widget_unparent() instead.
This is symmetric with the fact that these widgets were ref'ed by direct
call to gtk_widget_set_parent().  It's also the method that was used in
gtk_headerbar_destroy().

https://bugzilla.gnome.org/show_bug.cgi?id=772859
This commit is contained in:
Alan Jenkins 2016-10-12 18:03:43 +01:00 committed by Matthias Clasen
parent 4100a848a7
commit b3af460860
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gtk/gtkheaderbar.c
View File

@ -282,13 +282,13 @@ _gtk_header_bar_update_window_buttons (GtkHeaderBar *bar)
if (priv->titlebar_start_box) if (priv->titlebar_start_box)
{ {
gtk_widget_destroy (priv->titlebar_start_box); gtk_widget_unparent (priv->titlebar_start_box);
priv->titlebar_start_box = NULL; priv->titlebar_start_box = NULL;
priv->titlebar_start_separator = NULL; priv->titlebar_start_separator = NULL;
} }
if (priv->titlebar_end_box) if (priv->titlebar_end_box)
{ {
gtk_widget_destroy (priv->titlebar_end_box); gtk_widget_unparent (priv->titlebar_end_box);
priv->titlebar_end_box = NULL; priv->titlebar_end_box = NULL;
priv->titlebar_end_separator = NULL; priv->titlebar_end_separator = NULL;
} }